diff options
author | Tom Zanussi <zanussi@comcast.ne> | 2008-04-24 06:52:20 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2008-04-29 03:48:15 -0400 |
commit | c3270e577c18b3d0e984c3371493205a4807db9d (patch) | |
tree | 4a9e418798f897a580da930a575747706d17b94b | |
parent | a01e035ebb552223c03f2d9138ffc73f2d4d3965 (diff) |
relay: fix splice problem
Splice isn't always incrementing the ppos correctly, which broke
relay splice.
Signed-off-by: Tom Zanussi <zanussi@comcast.net>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r-- | fs/splice.c | 2 | ||||
-rw-r--r-- | kernel/relay.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/splice.c b/fs/splice.c index eeb1a86a7014..633f58ebfb72 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -1075,7 +1075,7 @@ long do_splice_direct(struct file *in, loff_t *ppos, struct file *out, | |||
1075 | 1075 | ||
1076 | ret = splice_direct_to_actor(in, &sd, direct_splice_actor); | 1076 | ret = splice_direct_to_actor(in, &sd, direct_splice_actor); |
1077 | if (ret > 0) | 1077 | if (ret > 0) |
1078 | *ppos += ret; | 1078 | *ppos = sd.pos; |
1079 | 1079 | ||
1080 | return ret; | 1080 | return ret; |
1081 | } | 1081 | } |
diff --git a/kernel/relay.c b/kernel/relay.c index d6204a485818..dc873fba90d2 100644 --- a/kernel/relay.c +++ b/kernel/relay.c | |||
@@ -1162,7 +1162,7 @@ static ssize_t relay_file_splice_read(struct file *in, | |||
1162 | ret = 0; | 1162 | ret = 0; |
1163 | spliced = 0; | 1163 | spliced = 0; |
1164 | 1164 | ||
1165 | while (len) { | 1165 | while (len && !spliced) { |
1166 | ret = subbuf_splice_actor(in, ppos, pipe, len, flags, &nonpad_ret); | 1166 | ret = subbuf_splice_actor(in, ppos, pipe, len, flags, &nonpad_ret); |
1167 | if (ret < 0) | 1167 | if (ret < 0) |
1168 | break; | 1168 | break; |