diff options
author | Stephen Hemminger <shemminger@osdl.org> | 2005-06-23 15:20:36 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2005-06-23 15:20:36 -0400 |
commit | 7c99c909fa69a183c1b80bd64fb9f0d11459aff3 (patch) | |
tree | ab0d06458ca3b1f78945557022a3c2f5098ed614 | |
parent | 317a76f9a44b437d6301718f4e5d08bd93f98da7 (diff) |
[TCP]: Change tcp_diag to use the existing __RTA_PUT() macro.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/tcp_diag.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c index 867acc0f79d8..a4e512036d88 100644 --- a/net/ipv4/tcp_diag.c +++ b/net/ipv4/tcp_diag.c | |||
@@ -43,13 +43,7 @@ struct tcpdiag_entry | |||
43 | static struct sock *tcpnl; | 43 | static struct sock *tcpnl; |
44 | 44 | ||
45 | #define TCPDIAG_PUT(skb, attrtype, attrlen) \ | 45 | #define TCPDIAG_PUT(skb, attrtype, attrlen) \ |
46 | ({ int rtalen = RTA_LENGTH(attrlen); \ | 46 | RTA_DATA(__RTA_PUT(skb, attrtype, attrlen)) |
47 | struct rtattr *rta; \ | ||
48 | if (skb_tailroom(skb) < RTA_ALIGN(rtalen)) goto nlmsg_failure; \ | ||
49 | rta = (void*)__skb_put(skb, RTA_ALIGN(rtalen)); \ | ||
50 | rta->rta_type = attrtype; \ | ||
51 | rta->rta_len = rtalen; \ | ||
52 | RTA_DATA(rta); }) | ||
53 | 47 | ||
54 | static int tcpdiag_fill(struct sk_buff *skb, struct sock *sk, | 48 | static int tcpdiag_fill(struct sk_buff *skb, struct sock *sk, |
55 | int ext, u32 pid, u32 seq, u16 nlmsg_flags) | 49 | int ext, u32 pid, u32 seq, u16 nlmsg_flags) |
@@ -167,6 +161,7 @@ static int tcpdiag_fill(struct sk_buff *skb, struct sock *sk, | |||
167 | nlh->nlmsg_len = skb->tail - b; | 161 | nlh->nlmsg_len = skb->tail - b; |
168 | return skb->len; | 162 | return skb->len; |
169 | 163 | ||
164 | rtattr_failure: | ||
170 | nlmsg_failure: | 165 | nlmsg_failure: |
171 | skb_trim(skb, b - skb->data); | 166 | skb_trim(skb, b - skb->data); |
172 | return -1; | 167 | return -1; |