diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-21 22:18:43 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-21 22:18:43 -0400 |
commit | 807501475fce0ebe68baedf87f202c3e4ee0d12c (patch) | |
tree | 1df7d070d9d0f30e08e58f0446a0b0567e6797cc | |
parent | 2848077044a5fdeb942bd1342c550da4c452d66a (diff) | |
parent | bc751fe6fff3ff894784acfed1bed8639b632c09 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband:
IB/ipath: Correct capitalization "IntX" -> "INTx"
IB/ipath: Remove tests of PCI_MSI in ipath_iba7220.c
IB/ipath: Remove dependency on PCI_MSI || HT_IRQ
IB/ipath: Build IBA7220 code unconditionally
IB/ipath: Remove reference to dev->class_dev
IB/ipath: Fix module parameter description for disable_sma
RDMA/nes: Remove unneeded function declarations
Fix up conflict in drivers/infiniband/hw/ipath/ipath_verbs.c (by picking
the solution from the infiniband branch)
-rw-r--r-- | drivers/infiniband/hw/ipath/Kconfig | 2 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/Makefile | 6 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_driver.c | 2 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_iba7220.c | 23 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_verbs.c | 3 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes.c | 6 | ||||
-rw-r--r-- | drivers/infiniband/hw/nes/nes_nic.c | 9 |
7 files changed, 16 insertions, 35 deletions
diff --git a/drivers/infiniband/hw/ipath/Kconfig b/drivers/infiniband/hw/ipath/Kconfig index 044da5828a78..3c7968f25ec2 100644 --- a/drivers/infiniband/hw/ipath/Kconfig +++ b/drivers/infiniband/hw/ipath/Kconfig | |||
@@ -1,6 +1,6 @@ | |||
1 | config INFINIBAND_IPATH | 1 | config INFINIBAND_IPATH |
2 | tristate "QLogic InfiniPath Driver" | 2 | tristate "QLogic InfiniPath Driver" |
3 | depends on (PCI_MSI || HT_IRQ) && 64BIT && NET | 3 | depends on 64BIT && NET |
4 | ---help--- | 4 | ---help--- |
5 | This is a driver for QLogic InfiniPath host channel adapters, | 5 | This is a driver for QLogic InfiniPath host channel adapters, |
6 | including InfiniBand verbs support. This driver allows these | 6 | including InfiniBand verbs support. This driver allows these |
diff --git a/drivers/infiniband/hw/ipath/Makefile b/drivers/infiniband/hw/ipath/Makefile index 75a6c91944c4..bf9450061986 100644 --- a/drivers/infiniband/hw/ipath/Makefile +++ b/drivers/infiniband/hw/ipath/Makefile | |||
@@ -29,11 +29,13 @@ ib_ipath-y := \ | |||
29 | ipath_user_pages.o \ | 29 | ipath_user_pages.o \ |
30 | ipath_user_sdma.o \ | 30 | ipath_user_sdma.o \ |
31 | ipath_verbs_mcast.o \ | 31 | ipath_verbs_mcast.o \ |
32 | ipath_verbs.o | 32 | ipath_verbs.o \ |
33 | ipath_iba7220.o \ | ||
34 | ipath_sd7220.o \ | ||
35 | ipath_sd7220_img.o | ||
33 | 36 | ||
34 | ib_ipath-$(CONFIG_HT_IRQ) += ipath_iba6110.o | 37 | ib_ipath-$(CONFIG_HT_IRQ) += ipath_iba6110.o |
35 | ib_ipath-$(CONFIG_PCI_MSI) += ipath_iba6120.o | 38 | ib_ipath-$(CONFIG_PCI_MSI) += ipath_iba6120.o |
36 | ib_ipath-$(CONFIG_PCI_MSI) += ipath_iba7220.o ipath_sd7220.o ipath_sd7220_img.o | ||
37 | 39 | ||
38 | ib_ipath-$(CONFIG_X86_64) += ipath_wc_x86_64.o | 40 | ib_ipath-$(CONFIG_X86_64) += ipath_wc_x86_64.o |
39 | ib_ipath-$(CONFIG_PPC64) += ipath_wc_ppc64.o | 41 | ib_ipath-$(CONFIG_PPC64) += ipath_wc_ppc64.o |
diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c b/drivers/infiniband/hw/ipath/ipath_driver.c index e0a64f070b97..acf30c06a0c0 100644 --- a/drivers/infiniband/hw/ipath/ipath_driver.c +++ b/drivers/infiniband/hw/ipath/ipath_driver.c | |||
@@ -538,7 +538,7 @@ static int __devinit ipath_init_one(struct pci_dev *pdev, | |||
538 | case PCI_DEVICE_ID_INFINIPATH_7220: | 538 | case PCI_DEVICE_ID_INFINIPATH_7220: |
539 | #ifndef CONFIG_PCI_MSI | 539 | #ifndef CONFIG_PCI_MSI |
540 | ipath_dbg("CONFIG_PCI_MSI is not enabled, " | 540 | ipath_dbg("CONFIG_PCI_MSI is not enabled, " |
541 | "using IntX for unit %u\n", dd->ipath_unit); | 541 | "using INTx for unit %u\n", dd->ipath_unit); |
542 | #endif | 542 | #endif |
543 | ipath_init_iba7220_funcs(dd); | 543 | ipath_init_iba7220_funcs(dd); |
544 | break; | 544 | break; |
diff --git a/drivers/infiniband/hw/ipath/ipath_iba7220.c b/drivers/infiniband/hw/ipath/ipath_iba7220.c index 1b2de2cfb69b..e3ec0d1bdf50 100644 --- a/drivers/infiniband/hw/ipath/ipath_iba7220.c +++ b/drivers/infiniband/hw/ipath/ipath_iba7220.c | |||
@@ -1215,13 +1215,13 @@ static int ipath_msi_enabled(struct pci_dev *pdev) | |||
1215 | 1215 | ||
1216 | /* | 1216 | /* |
1217 | * disable msi interrupt if enabled, and clear the flag. | 1217 | * disable msi interrupt if enabled, and clear the flag. |
1218 | * flag is used primarily for the fallback to IntX, but | 1218 | * flag is used primarily for the fallback to INTx, but |
1219 | * is also used in reinit after reset as a flag. | 1219 | * is also used in reinit after reset as a flag. |
1220 | */ | 1220 | */ |
1221 | static void ipath_7220_nomsi(struct ipath_devdata *dd) | 1221 | static void ipath_7220_nomsi(struct ipath_devdata *dd) |
1222 | { | 1222 | { |
1223 | dd->ipath_msi_lo = 0; | 1223 | dd->ipath_msi_lo = 0; |
1224 | #ifdef CONFIG_PCI_MSI | 1224 | |
1225 | if (ipath_msi_enabled(dd->pcidev)) { | 1225 | if (ipath_msi_enabled(dd->pcidev)) { |
1226 | /* | 1226 | /* |
1227 | * free, but don't zero; later kernels require | 1227 | * free, but don't zero; later kernels require |
@@ -1232,7 +1232,6 @@ static void ipath_7220_nomsi(struct ipath_devdata *dd) | |||
1232 | free_irq(dd->ipath_irq, dd); | 1232 | free_irq(dd->ipath_irq, dd); |
1233 | pci_disable_msi(dd->pcidev); | 1233 | pci_disable_msi(dd->pcidev); |
1234 | } | 1234 | } |
1235 | #endif | ||
1236 | } | 1235 | } |
1237 | 1236 | ||
1238 | /* | 1237 | /* |
@@ -1344,7 +1343,7 @@ static int ipath_setup_7220_config(struct ipath_devdata *dd, | |||
1344 | u32 boardrev; | 1343 | u32 boardrev; |
1345 | 1344 | ||
1346 | dd->ipath_msi_lo = 0; /* used as a flag during reset processing */ | 1345 | dd->ipath_msi_lo = 0; /* used as a flag during reset processing */ |
1347 | #ifdef CONFIG_PCI_MSI | 1346 | |
1348 | pos = pci_find_capability(pdev, PCI_CAP_ID_MSI); | 1347 | pos = pci_find_capability(pdev, PCI_CAP_ID_MSI); |
1349 | if (!strcmp(int_type, "force_msi") || !strcmp(int_type, "auto")) | 1348 | if (!strcmp(int_type, "force_msi") || !strcmp(int_type, "auto")) |
1350 | ret = pci_enable_msi(pdev); | 1349 | ret = pci_enable_msi(pdev); |
@@ -1377,10 +1376,6 @@ static int ipath_setup_7220_config(struct ipath_devdata *dd, | |||
1377 | } else | 1376 | } else |
1378 | ipath_dev_err(dd, "Can't find MSI capability, " | 1377 | ipath_dev_err(dd, "Can't find MSI capability, " |
1379 | "can't save MSI settings for reset\n"); | 1378 | "can't save MSI settings for reset\n"); |
1380 | #else | ||
1381 | ipath_dbg("PCI_MSI not configured, using IntX interrupts\n"); | ||
1382 | ipath_enable_intx(pdev); | ||
1383 | #endif | ||
1384 | 1379 | ||
1385 | dd->ipath_irq = pdev->irq; | 1380 | dd->ipath_irq = pdev->irq; |
1386 | 1381 | ||
@@ -1583,7 +1578,7 @@ static void ipath_init_7220_variables(struct ipath_devdata *dd) | |||
1583 | static int ipath_reinit_msi(struct ipath_devdata *dd) | 1578 | static int ipath_reinit_msi(struct ipath_devdata *dd) |
1584 | { | 1579 | { |
1585 | int ret = 0; | 1580 | int ret = 0; |
1586 | #ifdef CONFIG_PCI_MSI | 1581 | |
1587 | int pos; | 1582 | int pos; |
1588 | u16 control; | 1583 | u16 control; |
1589 | if (!dd->ipath_msi_lo) /* Using intX, or init problem */ | 1584 | if (!dd->ipath_msi_lo) /* Using intX, or init problem */ |
@@ -1617,10 +1612,10 @@ static int ipath_reinit_msi(struct ipath_devdata *dd) | |||
1617 | ((control & PCI_MSI_FLAGS_64BIT) ? 12 : 8), | 1612 | ((control & PCI_MSI_FLAGS_64BIT) ? 12 : 8), |
1618 | dd->ipath_msi_data); | 1613 | dd->ipath_msi_data); |
1619 | ret = 1; | 1614 | ret = 1; |
1615 | |||
1620 | bail: | 1616 | bail: |
1621 | #endif | ||
1622 | if (!ret) { | 1617 | if (!ret) { |
1623 | ipath_dbg("Using IntX, MSI disabled or not configured\n"); | 1618 | ipath_dbg("Using INTx, MSI disabled or not configured\n"); |
1624 | ipath_enable_intx(dd->pcidev); | 1619 | ipath_enable_intx(dd->pcidev); |
1625 | ret = 1; | 1620 | ret = 1; |
1626 | } | 1621 | } |
@@ -2149,12 +2144,12 @@ static void ipath_7220_read_counters(struct ipath_devdata *dd, | |||
2149 | counters[i] = ipath_snap_cntr(dd, i); | 2144 | counters[i] = ipath_snap_cntr(dd, i); |
2150 | } | 2145 | } |
2151 | 2146 | ||
2152 | /* if we are using MSI, try to fallback to IntX */ | 2147 | /* if we are using MSI, try to fallback to INTx */ |
2153 | static int ipath_7220_intr_fallback(struct ipath_devdata *dd) | 2148 | static int ipath_7220_intr_fallback(struct ipath_devdata *dd) |
2154 | { | 2149 | { |
2155 | if (dd->ipath_msi_lo) { | 2150 | if (dd->ipath_msi_lo) { |
2156 | dev_info(&dd->pcidev->dev, "MSI interrupt not detected," | 2151 | dev_info(&dd->pcidev->dev, "MSI interrupt not detected," |
2157 | " trying IntX interrupts\n"); | 2152 | " trying INTx interrupts\n"); |
2158 | ipath_7220_nomsi(dd); | 2153 | ipath_7220_nomsi(dd); |
2159 | ipath_enable_intx(dd->pcidev); | 2154 | ipath_enable_intx(dd->pcidev); |
2160 | /* | 2155 | /* |
@@ -2167,7 +2162,7 @@ static int ipath_7220_intr_fallback(struct ipath_devdata *dd) | |||
2167 | if (request_irq(dd->ipath_irq, ipath_intr, IRQF_SHARED, | 2162 | if (request_irq(dd->ipath_irq, ipath_intr, IRQF_SHARED, |
2168 | IPATH_DRV_NAME, dd)) | 2163 | IPATH_DRV_NAME, dd)) |
2169 | ipath_dev_err(dd, | 2164 | ipath_dev_err(dd, |
2170 | "Could not re-request_irq for IntX\n"); | 2165 | "Could not re-request_irq for INTx\n"); |
2171 | return 1; | 2166 | return 1; |
2172 | } | 2167 | } |
2173 | return 0; | 2168 | return 0; |
diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.c b/drivers/infiniband/hw/ipath/ipath_verbs.c index c43f2d286f8f..e63927cce5b5 100644 --- a/drivers/infiniband/hw/ipath/ipath_verbs.c +++ b/drivers/infiniband/hw/ipath/ipath_verbs.c | |||
@@ -109,7 +109,7 @@ MODULE_PARM_DESC(max_srq_wrs, "Maximum number of SRQ WRs support"); | |||
109 | 109 | ||
110 | static unsigned int ib_ipath_disable_sma; | 110 | static unsigned int ib_ipath_disable_sma; |
111 | module_param_named(disable_sma, ib_ipath_disable_sma, uint, S_IWUSR | S_IRUGO); | 111 | module_param_named(disable_sma, ib_ipath_disable_sma, uint, S_IWUSR | S_IRUGO); |
112 | MODULE_PARM_DESC(ib_ipath_disable_sma, "Disable the SMA"); | 112 | MODULE_PARM_DESC(disable_sma, "Disable the SMA"); |
113 | 113 | ||
114 | const int ib_ipath_state_ops[IB_QPS_ERR + 1] = { | 114 | const int ib_ipath_state_ops[IB_QPS_ERR + 1] = { |
115 | [IB_QPS_RESET] = 0, | 115 | [IB_QPS_RESET] = 0, |
@@ -2067,7 +2067,6 @@ int ipath_register_ib_device(struct ipath_devdata *dd) | |||
2067 | dev->phys_port_cnt = 1; | 2067 | dev->phys_port_cnt = 1; |
2068 | dev->num_comp_vectors = 1; | 2068 | dev->num_comp_vectors = 1; |
2069 | dev->dma_device = &dd->pcidev->dev; | 2069 | dev->dma_device = &dd->pcidev->dev; |
2070 | dev->dev.parent = dev->dma_device; | ||
2071 | dev->query_device = ipath_query_device; | 2070 | dev->query_device = ipath_query_device; |
2072 | dev->modify_device = ipath_modify_device; | 2071 | dev->modify_device = ipath_modify_device; |
2073 | dev->query_port = ipath_query_port; | 2072 | dev->query_port = ipath_query_port; |
diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index b00b0e3a91dc..b046262ed638 100644 --- a/drivers/infiniband/hw/nes/nes.c +++ b/drivers/infiniband/hw/nes/nes.c | |||
@@ -96,12 +96,6 @@ static LIST_HEAD(nes_dev_list); | |||
96 | 96 | ||
97 | atomic_t qps_destroyed; | 97 | atomic_t qps_destroyed; |
98 | 98 | ||
99 | static void nes_print_macaddr(struct net_device *netdev); | ||
100 | static irqreturn_t nes_interrupt(int, void *); | ||
101 | static int __devinit nes_probe(struct pci_dev *, const struct pci_device_id *); | ||
102 | static void __devexit nes_remove(struct pci_dev *); | ||
103 | static int __init nes_init_module(void); | ||
104 | static void __exit nes_exit_module(void); | ||
105 | static unsigned int ee_flsh_adapter; | 99 | static unsigned int ee_flsh_adapter; |
106 | static unsigned int sysfs_nonidx_addr; | 100 | static unsigned int sysfs_nonidx_addr; |
107 | static unsigned int sysfs_idx_addr; | 101 | static unsigned int sysfs_idx_addr; |
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 34166641f207..01cd0effc492 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c | |||
@@ -92,15 +92,6 @@ static const u32 default_msg = NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | |||
92 | | NETIF_MSG_IFUP | NETIF_MSG_IFDOWN; | 92 | | NETIF_MSG_IFUP | NETIF_MSG_IFDOWN; |
93 | static int debug = -1; | 93 | static int debug = -1; |
94 | 94 | ||
95 | |||
96 | static int nes_netdev_open(struct net_device *); | ||
97 | static int nes_netdev_stop(struct net_device *); | ||
98 | static int nes_netdev_start_xmit(struct sk_buff *, struct net_device *); | ||
99 | static struct net_device_stats *nes_netdev_get_stats(struct net_device *); | ||
100 | static void nes_netdev_tx_timeout(struct net_device *); | ||
101 | static int nes_netdev_set_mac_address(struct net_device *, void *); | ||
102 | static int nes_netdev_change_mtu(struct net_device *, int); | ||
103 | |||
104 | /** | 95 | /** |
105 | * nes_netdev_poll | 96 | * nes_netdev_poll |
106 | */ | 97 | */ |