diff options
author | Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> | 2005-08-29 16:54:55 -0400 |
---|---|---|
committer | Dave Jones <davej@redhat.com> | 2005-09-01 01:21:29 -0400 |
commit | f914be79ab2144efe291d9fc383661e0e23dca44 (patch) | |
tree | b31042a3fe103a894a26611e16459f10b7b2cbaa | |
parent | 8085e1f1f0645fc6ddefcb54fdcba95808df5049 (diff) |
[CPUFREQ] speedstep-centrino: skip extract_clock logic for acpi based centrino
speedstep_centrino.c:extract_clock() assumes the bus speed of 100MHz, which is
not true with latest laptops. Due to this assumption and due to the encoded
frequency check during initialization, speedstep-centrino driver fails even
on systems that has proper ACPI information to do the P-state transition.
The change below moves the centrino-speedstep detection to be used only
when table based P-state transition is done. For ACPI based P-state
transition, we skip the centrino_cpu identification, and as a result we
don't use the bus speed assumption in extract_clock. This change makes
speedstep-centrino work on Pentium-M based systems, which have more than 100MHz
bus speed.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Dave Jones <davej@redhat.com>
-rw-r--r-- | arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c b/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c index 327a55d4d1c6..95e15b7fce17 100644 --- a/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c +++ b/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c | |||
@@ -498,13 +498,6 @@ static int centrino_cpu_init(struct cpufreq_policy *policy) | |||
498 | if (cpu->x86_vendor != X86_VENDOR_INTEL || !cpu_has(cpu, X86_FEATURE_EST)) | 498 | if (cpu->x86_vendor != X86_VENDOR_INTEL || !cpu_has(cpu, X86_FEATURE_EST)) |
499 | return -ENODEV; | 499 | return -ENODEV; |
500 | 500 | ||
501 | for (i = 0; i < N_IDS; i++) | ||
502 | if (centrino_verify_cpu_id(cpu, &cpu_ids[i])) | ||
503 | break; | ||
504 | |||
505 | if (i != N_IDS) | ||
506 | centrino_cpu[policy->cpu] = &cpu_ids[i]; | ||
507 | |||
508 | if (is_const_loops_cpu(policy->cpu)) { | 501 | if (is_const_loops_cpu(policy->cpu)) { |
509 | centrino_driver.flags |= CPUFREQ_CONST_LOOPS; | 502 | centrino_driver.flags |= CPUFREQ_CONST_LOOPS; |
510 | } | 503 | } |
@@ -513,6 +506,13 @@ static int centrino_cpu_init(struct cpufreq_policy *policy) | |||
513 | if (policy->cpu != 0) | 506 | if (policy->cpu != 0) |
514 | return -ENODEV; | 507 | return -ENODEV; |
515 | 508 | ||
509 | for (i = 0; i < N_IDS; i++) | ||
510 | if (centrino_verify_cpu_id(cpu, &cpu_ids[i])) | ||
511 | break; | ||
512 | |||
513 | if (i != N_IDS) | ||
514 | centrino_cpu[policy->cpu] = &cpu_ids[i]; | ||
515 | |||
516 | if (!centrino_cpu[policy->cpu]) { | 516 | if (!centrino_cpu[policy->cpu]) { |
517 | dprintk(KERN_INFO PFX "found unsupported CPU with " | 517 | dprintk(KERN_INFO PFX "found unsupported CPU with " |
518 | "Enhanced SpeedStep: send /proc/cpuinfo to " | 518 | "Enhanced SpeedStep: send /proc/cpuinfo to " |