diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-11-28 12:12:06 -0500 |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2009-12-07 16:23:24 -0500 |
commit | e15c1c1f3f903f679c9782b540f9d52c80c99610 (patch) | |
tree | dc7c18f9f783b0f1c689e5ddd3ae7873421912eb | |
parent | 6ec22f9b037fc0c2e00ddb7023fad279c365324d (diff) |
pcmcia: remove unused IRQ_FIRST_SHARED
Komuro pointed out that IRQ_FIRST_SHARED is not used at all in the
PCMCIA subsystem, so remove it. Also, remove two bogus assignments.
CC: Karsten Keil <keil@b1-systems.de>
CC: netdev@vger.kernel.org
CC: alsa-devel@alsa-project.org
CC: Komuro <komurojun-mbn@nifty.com>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
-rw-r--r-- | drivers/isdn/hardware/avm/avm_cs.c | 3 | ||||
-rw-r--r-- | drivers/isdn/hisax/avma1_cs.c | 3 | ||||
-rw-r--r-- | drivers/isdn/hisax/elsa_cs.c | 2 | ||||
-rw-r--r-- | drivers/isdn/hisax/sedlbauer_cs.c | 2 | ||||
-rw-r--r-- | drivers/isdn/hisax/teles_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/axnet_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/fmvj18x_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/pcnet_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/smc91c92_cs.c | 2 | ||||
-rw-r--r-- | drivers/net/pcmcia/xirc2ps_cs.c | 2 | ||||
-rw-r--r-- | include/pcmcia/cs.h | 4 | ||||
-rw-r--r-- | sound/pcmcia/pdaudiocf/pdaudiocf.c | 3 |
12 files changed, 14 insertions, 15 deletions
diff --git a/drivers/isdn/hardware/avm/avm_cs.c b/drivers/isdn/hardware/avm/avm_cs.c index 5a6ae646a636..94b796d84053 100644 --- a/drivers/isdn/hardware/avm/avm_cs.c +++ b/drivers/isdn/hardware/avm/avm_cs.c | |||
@@ -108,8 +108,7 @@ static int avmcs_probe(struct pcmcia_device *p_dev) | |||
108 | p_dev->io.NumPorts2 = 0; | 108 | p_dev->io.NumPorts2 = 0; |
109 | 109 | ||
110 | /* Interrupt setup */ | 110 | /* Interrupt setup */ |
111 | p_dev->irq.Attributes = IRQ_TYPE_EXCLUSIVE; | 111 | p_dev->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
112 | p_dev->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | ||
113 | 112 | ||
114 | /* General socket configuration */ | 113 | /* General socket configuration */ |
115 | p_dev->conf.Attributes = CONF_ENABLE_IRQ; | 114 | p_dev->conf.Attributes = CONF_ENABLE_IRQ; |
diff --git a/drivers/isdn/hisax/avma1_cs.c b/drivers/isdn/hisax/avma1_cs.c index f9bdff39cf4a..e5deb15cf40c 100644 --- a/drivers/isdn/hisax/avma1_cs.c +++ b/drivers/isdn/hisax/avma1_cs.c | |||
@@ -120,8 +120,7 @@ static int avma1cs_probe(struct pcmcia_device *p_dev) | |||
120 | p_dev->io.IOAddrLines = 5; | 120 | p_dev->io.IOAddrLines = 5; |
121 | 121 | ||
122 | /* Interrupt setup */ | 122 | /* Interrupt setup */ |
123 | p_dev->irq.Attributes = IRQ_TYPE_EXCLUSIVE; | 123 | p_dev->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
124 | p_dev->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | ||
125 | 124 | ||
126 | /* General socket configuration */ | 125 | /* General socket configuration */ |
127 | p_dev->conf.Attributes = CONF_ENABLE_IRQ; | 126 | p_dev->conf.Attributes = CONF_ENABLE_IRQ; |
diff --git a/drivers/isdn/hisax/elsa_cs.c b/drivers/isdn/hisax/elsa_cs.c index a2f709f53974..c9a30b1c9237 100644 --- a/drivers/isdn/hisax/elsa_cs.c +++ b/drivers/isdn/hisax/elsa_cs.c | |||
@@ -137,7 +137,7 @@ static int elsa_cs_probe(struct pcmcia_device *link) | |||
137 | local->cardnr = -1; | 137 | local->cardnr = -1; |
138 | 138 | ||
139 | /* Interrupt setup */ | 139 | /* Interrupt setup */ |
140 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 140 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
141 | link->irq.Handler = NULL; | 141 | link->irq.Handler = NULL; |
142 | 142 | ||
143 | /* | 143 | /* |
diff --git a/drivers/isdn/hisax/sedlbauer_cs.c b/drivers/isdn/hisax/sedlbauer_cs.c index af5d393cc2d0..7836ec3c7f86 100644 --- a/drivers/isdn/hisax/sedlbauer_cs.c +++ b/drivers/isdn/hisax/sedlbauer_cs.c | |||
@@ -144,7 +144,7 @@ static int sedlbauer_probe(struct pcmcia_device *link) | |||
144 | link->priv = local; | 144 | link->priv = local; |
145 | 145 | ||
146 | /* Interrupt setup */ | 146 | /* Interrupt setup */ |
147 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 147 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
148 | link->irq.Handler = NULL; | 148 | link->irq.Handler = NULL; |
149 | 149 | ||
150 | /* | 150 | /* |
diff --git a/drivers/isdn/hisax/teles_cs.c b/drivers/isdn/hisax/teles_cs.c index ea705394ce2b..b0c5976cbdb3 100644 --- a/drivers/isdn/hisax/teles_cs.c +++ b/drivers/isdn/hisax/teles_cs.c | |||
@@ -127,7 +127,7 @@ static int teles_probe(struct pcmcia_device *link) | |||
127 | link->priv = local; | 127 | link->priv = local; |
128 | 128 | ||
129 | /* Interrupt setup */ | 129 | /* Interrupt setup */ |
130 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 130 | link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING; |
131 | link->irq.Handler = NULL; | 131 | link->irq.Handler = NULL; |
132 | 132 | ||
133 | /* | 133 | /* |
diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c index 800597b82d18..cb2ce03bd681 100644 --- a/drivers/net/pcmcia/axnet_cs.c +++ b/drivers/net/pcmcia/axnet_cs.c | |||
@@ -270,7 +270,7 @@ static int try_io_port(struct pcmcia_device *link) | |||
270 | /* for master/slave multifunction cards */ | 270 | /* for master/slave multifunction cards */ |
271 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; | 271 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; |
272 | link->irq.Attributes = | 272 | link->irq.Attributes = |
273 | IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 273 | IRQ_TYPE_DYNAMIC_SHARING; |
274 | } | 274 | } |
275 | } else { | 275 | } else { |
276 | /* This should be two 16-port windows */ | 276 | /* This should be two 16-port windows */ |
diff --git a/drivers/net/pcmcia/fmvj18x_cs.c b/drivers/net/pcmcia/fmvj18x_cs.c index 6e3e1ced6db4..fc5a890ba0a9 100644 --- a/drivers/net/pcmcia/fmvj18x_cs.c +++ b/drivers/net/pcmcia/fmvj18x_cs.c | |||
@@ -426,7 +426,7 @@ static int fmvj18x_config(struct pcmcia_device *link) | |||
426 | 426 | ||
427 | if (link->io.NumPorts2 != 0) { | 427 | if (link->io.NumPorts2 != 0) { |
428 | link->irq.Attributes = | 428 | link->irq.Attributes = |
429 | IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 429 | IRQ_TYPE_DYNAMIC_SHARING; |
430 | ret = mfc_try_io_port(link); | 430 | ret = mfc_try_io_port(link); |
431 | if (ret != 0) goto failed; | 431 | if (ret != 0) goto failed; |
432 | } else if (cardtype == UNGERMANN) { | 432 | } else if (cardtype == UNGERMANN) { |
diff --git a/drivers/net/pcmcia/pcnet_cs.c b/drivers/net/pcmcia/pcnet_cs.c index cbe462ed221f..f41fbcc34327 100644 --- a/drivers/net/pcmcia/pcnet_cs.c +++ b/drivers/net/pcmcia/pcnet_cs.c | |||
@@ -490,7 +490,7 @@ static int try_io_port(struct pcmcia_device *link) | |||
490 | /* for master/slave multifunction cards */ | 490 | /* for master/slave multifunction cards */ |
491 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; | 491 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; |
492 | link->irq.Attributes = | 492 | link->irq.Attributes = |
493 | IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 493 | IRQ_TYPE_DYNAMIC_SHARING; |
494 | } | 494 | } |
495 | } else { | 495 | } else { |
496 | /* This should be two 16-port windows */ | 496 | /* This should be two 16-port windows */ |
diff --git a/drivers/net/pcmcia/smc91c92_cs.c b/drivers/net/pcmcia/smc91c92_cs.c index 9e0da370912e..49185c3c1201 100644 --- a/drivers/net/pcmcia/smc91c92_cs.c +++ b/drivers/net/pcmcia/smc91c92_cs.c | |||
@@ -454,7 +454,7 @@ static int mhz_mfc_config(struct pcmcia_device *link) | |||
454 | link->conf.Attributes |= CONF_ENABLE_SPKR; | 454 | link->conf.Attributes |= CONF_ENABLE_SPKR; |
455 | link->conf.Status = CCSR_AUDIO_ENA; | 455 | link->conf.Status = CCSR_AUDIO_ENA; |
456 | link->irq.Attributes = | 456 | link->irq.Attributes = |
457 | IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 457 | IRQ_TYPE_DYNAMIC_SHARING; |
458 | link->io.IOAddrLines = 16; | 458 | link->io.IOAddrLines = 16; |
459 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; | 459 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; |
460 | link->io.NumPorts2 = 8; | 460 | link->io.NumPorts2 = 8; |
diff --git a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c index fe504b7f369f..55fa5ca245d1 100644 --- a/drivers/net/pcmcia/xirc2ps_cs.c +++ b/drivers/net/pcmcia/xirc2ps_cs.c | |||
@@ -841,7 +841,7 @@ xirc2ps_config(struct pcmcia_device * link) | |||
841 | link->conf.Attributes |= CONF_ENABLE_SPKR; | 841 | link->conf.Attributes |= CONF_ENABLE_SPKR; |
842 | link->conf.Status |= CCSR_AUDIO_ENA; | 842 | link->conf.Status |= CCSR_AUDIO_ENA; |
843 | } | 843 | } |
844 | link->irq.Attributes |= IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED ; | 844 | link->irq.Attributes |= IRQ_TYPE_DYNAMIC_SHARING; |
845 | link->io.NumPorts2 = 8; | 845 | link->io.NumPorts2 = 8; |
846 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; | 846 | link->io.Attributes2 = IO_DATA_PATH_WIDTH_8; |
847 | if (local->dingo) { | 847 | if (local->dingo) { |
diff --git a/include/pcmcia/cs.h b/include/pcmcia/cs.h index afc2bfb9e917..75fa3530345b 100644 --- a/include/pcmcia/cs.h +++ b/include/pcmcia/cs.h | |||
@@ -126,8 +126,8 @@ typedef struct irq_req_t { | |||
126 | #define IRQ_TYPE_TIME 0x01 | 126 | #define IRQ_TYPE_TIME 0x01 |
127 | #define IRQ_TYPE_DYNAMIC_SHARING 0x02 | 127 | #define IRQ_TYPE_DYNAMIC_SHARING 0x02 |
128 | #define IRQ_FORCED_PULSE 0x04 | 128 | #define IRQ_FORCED_PULSE 0x04 |
129 | #define IRQ_FIRST_SHARED 0x08 | 129 | #define IRQ_FIRST_SHARED 0x08 /* unused */ |
130 | //#define IRQ_HANDLE_PRESENT 0x10 | 130 | #define IRQ_HANDLE_PRESENT 0x10 /* unused */ |
131 | #define IRQ_PULSE_ALLOCATED 0x100 | 131 | #define IRQ_PULSE_ALLOCATED 0x100 |
132 | 132 | ||
133 | /* Bits in IRQInfo1 field */ | 133 | /* Bits in IRQInfo1 field */ |
diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c index 7717e01fc071..edaa729126bb 100644 --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c | |||
@@ -143,7 +143,8 @@ static int snd_pdacf_probe(struct pcmcia_device *link) | |||
143 | link->io.NumPorts1 = 16; | 143 | link->io.NumPorts1 = 16; |
144 | 144 | ||
145 | link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_FORCED_PULSE; | 145 | link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_FORCED_PULSE; |
146 | // link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED; | 146 | /* FIXME: This driver should be updated to allow for dynamic IRQ sharing */ |
147 | /* link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING | IRQ_FORCED_PULSE; */ | ||
147 | 148 | ||
148 | link->irq.Handler = pdacf_interrupt; | 149 | link->irq.Handler = pdacf_interrupt; |
149 | link->conf.Attributes = CONF_ENABLE_IRQ; | 150 | link->conf.Attributes = CONF_ENABLE_IRQ; |