Merge branch 'master' of ssh://cvs.cs.unc.edu/cvs/proj/litmus/repo/litmus2010 into wip-edf-hsb

5 files changed, 18 insertions, 14 deletions

diff --git a/include/litmus/litmus.h b/include/litmus/litmus.h
index 94086e2b38db..e7769ca36ec0 100644
--- a/include/litmus/litmus.h
+++ b/include/litmus/litmus.h
@@ -26,7 +26,7 @@ static inline int in_list(struct list_head* list)
                 );
 }
 
-struct task_struct* waitqueue_first(wait_queue_head_t *wq);
+struct task_struct* __waitqueue_remove_first(wait_queue_head_t *wq);
 
 #define NO_CPU                  0xffffffff
 
diff --git a/litmus/litmus.c b/litmus/litmus.c
index 657b4eda96e6..64f82aa0e246 100644
--- a/litmus/litmus.c
+++ b/litmus/litmus.c
@@ -111,6 +111,14 @@ asmlinkage long sys_set_rt_task_param(pid_t pid, struct rt_task __user * param)
                        "because wcet > period\n", pid);
                 goto out_unlock;
         }
+        if (    tp.cls != RT_CLASS_HARD &&
+                tp.cls != RT_CLASS_SOFT &&
+                tp.cls != RT_CLASS_BEST_EFFORT)
+        {
+                printk(KERN_INFO "litmus: real-time task %d rejected "
+                                 "because its class is invalid\n");
+                goto out_unlock;
+        }
         if (tp.budget_policy != NO_ENFORCEMENT &&
             tp.budget_policy != QUANTUM_ENFORCEMENT &&
             tp.budget_policy != PRECISE_ENFORCEMENT)
diff --git a/litmus/locking.c b/litmus/locking.c
index 728b56835cf7..2693f1aca859 100644
--- a/litmus/locking.c
+++ b/litmus/locking.c
@@ -107,16 +107,18 @@ asmlinkage long sys_litmus_unlock(int lock_od)
         return err;
 }
 
-struct task_struct* waitqueue_first(wait_queue_head_t *wq)
+struct task_struct* __waitqueue_remove_first(wait_queue_head_t *wq)
 {
-        wait_queue_t *q;
+        wait_queue_t* q;
+        struct task_struct* t = NULL;
 
         if (waitqueue_active(wq)) {
                 q = list_entry(wq->task_list.next,
                                wait_queue_t, task_list);
-                return (struct task_struct*) q->private;
-        } else
-                return NULL;
+                t = (struct task_struct*) q->private;
+                __remove_wait_queue(wq, q);
+        }
+        return(t);
 }
 
 
diff --git a/litmus/sched_gsn_edf.c b/litmus/sched_gsn_edf.c
index 2a649beed791..3092797480f8 100644
--- a/litmus/sched_gsn_edf.c
+++ b/litmus/sched_gsn_edf.c
@@ -778,8 +778,6 @@ int gsnedf_fmlp_lock(struct litmus_lock* l)
                  * ->owner. We can thus check it without acquiring the spin
                  * lock. */
                 BUG_ON(sem->owner != t);
-
-                remove_wait_queue(&sem->wait, &wait);
         } else {
                 /* it's ours now */
                 sem->owner = t;
@@ -805,7 +803,7 @@ int gsnedf_fmlp_unlock(struct litmus_lock* l)
         }
 
         /* check if there are jobs waiting for this resource */
-        next = waitqueue_first(&sem->wait);
+        next = __waitqueue_remove_first(&sem->wait);
         if (next) {
                 /* next becomes the resouce holder */
                 sem->owner = next;
diff --git a/litmus/sched_psn_edf.c b/litmus/sched_psn_edf.c
index abb06fa53e3a..71c02409efa2 100644
--- a/litmus/sched_psn_edf.c
+++ b/litmus/sched_psn_edf.c
@@ -442,10 +442,6 @@ int psnedf_fmlp_lock(struct litmus_lock* l)
                  * ->owner. We can thus check it without acquiring the spin
                  * lock. */
                 BUG_ON(sem->owner != t);
-
-                /* FIXME: could we punt the dequeuing to the previous job,
-                 * which is holding the spinlock anyway? */
-                remove_wait_queue(&sem->wait, &wait);
         } else {
                 /* it's ours now */
                 sem->owner = t;
@@ -478,7 +474,7 @@ int psnedf_fmlp_unlock(struct litmus_lock* l)
         unboost_priority(t);
 
         /* check if there are jobs waiting for this resource */
-        next = waitqueue_first(&sem->wait);
+        next = __waitqueue_remove_first(&sem->wait);
         if (next) {
                 /* boost next job */
                 boost_priority(next);