aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrishna Kumar <krkumar2@in.ibm.com>2011-11-23 17:17:14 -0500
committerDavid S. Miller <davem@davemloft.net>2011-12-20 13:45:55 -0500
commitef0002b577b52941fb147128f30bd1ecfdd3ff6d (patch)
tree8974f323c84eb97ebfb2ff817b7798ee96ceccc6
parent89efea25cdceb9093e3f7fb717d3b4063f7f8749 (diff)
macvtap: Fix macvtap_get_queue to use rxhash first
It was reported that the macvtap device selects a Acked-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/macvtap.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 7c88d136e723..58dc117a8d78 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -175,6 +175,14 @@ static struct macvtap_queue *macvtap_get_queue(struct net_device *dev,
175 if (!numvtaps) 175 if (!numvtaps)
176 goto out; 176 goto out;
177 177
178 /* Check if we can use flow to select a queue */
179 rxq = skb_get_rxhash(skb);
180 if (rxq) {
181 tap = rcu_dereference(vlan->taps[rxq % numvtaps]);
182 if (tap)
183 goto out;
184 }
185
178 if (likely(skb_rx_queue_recorded(skb))) { 186 if (likely(skb_rx_queue_recorded(skb))) {
179 rxq = skb_get_rx_queue(skb); 187 rxq = skb_get_rx_queue(skb);
180 188
@@ -186,14 +194,6 @@ static struct macvtap_queue *macvtap_get_queue(struct net_device *dev,
186 goto out; 194 goto out;
187 } 195 }
188 196
189 /* Check if we can use flow to select a queue */
190 rxq = skb_get_rxhash(skb);
191 if (rxq) {
192 tap = rcu_dereference(vlan->taps[rxq % numvtaps]);
193 if (tap)
194 goto out;
195 }
196
197 /* Everything failed - find first available queue */ 197 /* Everything failed - find first available queue */
198 for (rxq = 0; rxq < MAX_MACVTAP_QUEUES; rxq++) { 198 for (rxq = 0; rxq < MAX_MACVTAP_QUEUES; rxq++) {
199 tap = rcu_dereference(vlan->taps[rxq]); 199 tap = rcu_dereference(vlan->taps[rxq]);