diff options
| author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-12-13 00:57:50 -0500 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2009-01-04 17:50:34 -0500 |
| commit | c1fc58d63d754b82070881c62601551464afa19d (patch) | |
| tree | 3f4e1bc9a884aaea4fbfbb077e3865d2821d681d | |
| parent | cbe7dd699e0bdda85a9279f2659b51b92e6782e3 (diff) | |
ieee1394: consolidate uses of IEEE1934_BUSID_MAGIC
Move the definition out of nodemgr.h and use it in csr.c/pcilynx.c
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| -rw-r--r-- | drivers/ieee1394/csr.c | 4 | ||||
| -rw-r--r-- | drivers/ieee1394/ieee1394.h | 3 | ||||
| -rw-r--r-- | drivers/ieee1394/nodemgr.h | 3 | ||||
| -rw-r--r-- | drivers/ieee1394/pcilynx.c | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/drivers/ieee1394/csr.c b/drivers/ieee1394/csr.c index 9029b6839f0b..31400c8ae051 100644 --- a/drivers/ieee1394/csr.c +++ b/drivers/ieee1394/csr.c | |||
| @@ -217,7 +217,7 @@ static void add_host(struct hpsb_host *host) | |||
| 217 | 217 | ||
| 218 | host->csr.generation = 2; | 218 | host->csr.generation = 2; |
| 219 | 219 | ||
| 220 | bus_info[1] = __constant_cpu_to_be32(0x31333934); | 220 | bus_info[1] = IEEE1394_BUSID_MAGIC; |
| 221 | bus_info[2] = cpu_to_be32((hpsb_disable_irm ? 0 : 1 << CSR_IRMC_SHIFT) | | 221 | bus_info[2] = cpu_to_be32((hpsb_disable_irm ? 0 : 1 << CSR_IRMC_SHIFT) | |
| 222 | (1 << CSR_CMC_SHIFT) | | 222 | (1 << CSR_CMC_SHIFT) | |
| 223 | (1 << CSR_ISC_SHIFT) | | 223 | (1 << CSR_ISC_SHIFT) | |
| @@ -250,7 +250,7 @@ static void remove_host(struct hpsb_host *host) | |||
| 250 | { | 250 | { |
| 251 | quadlet_t bus_info[CSR_BUS_INFO_SIZE]; | 251 | quadlet_t bus_info[CSR_BUS_INFO_SIZE]; |
| 252 | 252 | ||
| 253 | bus_info[1] = __constant_cpu_to_be32(0x31333934); | 253 | bus_info[1] = IEEE1394_BUSID_MAGIC; |
| 254 | bus_info[2] = cpu_to_be32((0 << CSR_IRMC_SHIFT) | | 254 | bus_info[2] = cpu_to_be32((0 << CSR_IRMC_SHIFT) | |
| 255 | (0 << CSR_CMC_SHIFT) | | 255 | (0 << CSR_CMC_SHIFT) | |
| 256 | (0 << CSR_ISC_SHIFT) | | 256 | (0 << CSR_ISC_SHIFT) | |
diff --git a/drivers/ieee1394/ieee1394.h b/drivers/ieee1394/ieee1394.h index 40492074c013..e0ae0d3d747f 100644 --- a/drivers/ieee1394/ieee1394.h +++ b/drivers/ieee1394/ieee1394.h | |||
| @@ -121,6 +121,9 @@ extern const char *hpsb_speedto_str[]; | |||
| 121 | 121 | ||
| 122 | #include <asm/byteorder.h> | 122 | #include <asm/byteorder.h> |
| 123 | 123 | ||
| 124 | /* '1' '3' '9' '4' in ASCII */ | ||
| 125 | #define IEEE1394_BUSID_MAGIC cpu_to_be32(0x31333934) | ||
| 126 | |||
| 124 | #ifdef __BIG_ENDIAN_BITFIELD | 127 | #ifdef __BIG_ENDIAN_BITFIELD |
| 125 | 128 | ||
| 126 | struct selfid { | 129 | struct selfid { |
diff --git a/drivers/ieee1394/nodemgr.h b/drivers/ieee1394/nodemgr.h index 4f287a3561ba..15ea09733e84 100644 --- a/drivers/ieee1394/nodemgr.h +++ b/drivers/ieee1394/nodemgr.h | |||
| @@ -31,9 +31,6 @@ struct csr1212_keyval; | |||
| 31 | struct hpsb_host; | 31 | struct hpsb_host; |
| 32 | struct ieee1394_device_id; | 32 | struct ieee1394_device_id; |
| 33 | 33 | ||
| 34 | /* '1' '3' '9' '4' in ASCII */ | ||
| 35 | #define IEEE1394_BUSID_MAGIC __constant_cpu_to_be32(0x31333934) | ||
| 36 | |||
| 37 | /* This is the start of a Node entry structure. It should be a stable API | 34 | /* This is the start of a Node entry structure. It should be a stable API |
| 38 | * for which to gather info from the Node Manager about devices attached | 35 | * for which to gather info from the Node Manager about devices attached |
| 39 | * to the bus. */ | 36 | * to the bus. */ |
diff --git a/drivers/ieee1394/pcilynx.c b/drivers/ieee1394/pcilynx.c index 7aee1ac97c80..dc15cadb06ef 100644 --- a/drivers/ieee1394/pcilynx.c +++ b/drivers/ieee1394/pcilynx.c | |||
| @@ -1463,7 +1463,7 @@ static int __devinit add_card(struct pci_dev *dev, | |||
| 1463 | 1463 | ||
| 1464 | /* info_length, crc_length and 1394 magic number to check, if it is really a bus info block */ | 1464 | /* info_length, crc_length and 1394 magic number to check, if it is really a bus info block */ |
| 1465 | if (((be32_to_cpu(lynx->bus_info_block[0]) & 0xffff0000) == 0x04040000) && | 1465 | if (((be32_to_cpu(lynx->bus_info_block[0]) & 0xffff0000) == 0x04040000) && |
| 1466 | (lynx->bus_info_block[1] == __constant_cpu_to_be32(0x31333934))) | 1466 | (lynx->bus_info_block[1] == IEEE1394_BUSID_MAGIC)) |
| 1467 | { | 1467 | { |
| 1468 | PRINT(KERN_DEBUG, lynx->id, "read a valid bus info block from"); | 1468 | PRINT(KERN_DEBUG, lynx->id, "read a valid bus info block from"); |
| 1469 | } else { | 1469 | } else { |
