aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Zijlstra <a.p.zijlstra@chello.nl>2009-06-04 09:00:45 -0400
committerIngo Molnar <mingo@elte.hu>2009-06-04 08:04:50 -0400
commit95ed6fd06e52bf850cd17524f0b36ed14300c10d (patch)
treea12216f91e935fd8cab81e6bd8c9d6b2ce0d1748
parentaf794b94ae8a16fb4a9da6ce640c122efb44e2a0 (diff)
perf report: Simplify symbol output
The DSO can be printed already - no need to repeat it in the symbol field. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--Documentation/perf_counter/builtin-report.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/Documentation/perf_counter/builtin-report.c b/Documentation/perf_counter/builtin-report.c
index ff6f657476a9..56c664d1b628 100644
--- a/Documentation/perf_counter/builtin-report.c
+++ b/Documentation/perf_counter/builtin-report.c
@@ -382,7 +382,7 @@ sort__comm_print(FILE *fp, struct hist_entry *self)
382} 382}
383 383
384static struct sort_entry sort_comm = { 384static struct sort_entry sort_comm = {
385 .header = " Command", 385 .header = " Command",
386 .cmp = sort__comm_cmp, 386 .cmp = sort__comm_cmp,
387 .collapse = sort__comm_collapse, 387 .collapse = sort__comm_collapse,
388 .print = sort__comm_print, 388 .print = sort__comm_print,
@@ -414,11 +414,11 @@ sort__dso_print(FILE *fp, struct hist_entry *self)
414 if (self->dso) 414 if (self->dso)
415 return fprintf(fp, " %-25s", self->dso->name); 415 return fprintf(fp, " %-25s", self->dso->name);
416 416
417 return fprintf(fp, " %016llx", (__u64)self->ip); 417 return fprintf(fp, " %016llx ", (__u64)self->ip);
418} 418}
419 419
420static struct sort_entry sort_dso = { 420static struct sort_entry sort_dso = {
421 .header = " Shared Object ", 421 .header = " Shared Object ",
422 .cmp = sort__dso_cmp, 422 .cmp = sort__dso_cmp,
423 .print = sort__dso_print, 423 .print = sort__dso_print,
424}; 424};
@@ -447,21 +447,16 @@ sort__sym_print(FILE *fp, struct hist_entry *self)
447 if (verbose) 447 if (verbose)
448 ret += fprintf(fp, " %#018llx", (__u64)self->ip); 448 ret += fprintf(fp, " %#018llx", (__u64)self->ip);
449 449
450 if (self->dso)
451 ret += fprintf(fp, " %s: ", self->dso->name);
452 else
453 ret += fprintf(fp, " %#016llx: ", (__u64)self->ip);
454
455 if (self->sym) 450 if (self->sym)
456 ret += fprintf(fp, "%s", self->sym->name); 451 ret += fprintf(fp, " %s", self->sym->name);
457 else 452 else
458 ret += fprintf(fp, "%#016llx", (__u64)self->ip); 453 ret += fprintf(fp, " %#016llx", (__u64)self->ip);
459 454
460 return ret; 455 return ret;
461} 456}
462 457
463static struct sort_entry sort_sym = { 458static struct sort_entry sort_sym = {
464 .header = " Shared Object: Symbol", 459 .header = " Symbol",
465 .cmp = sort__sym_cmp, 460 .cmp = sort__sym_cmp,
466 .print = sort__sym_print, 461 .print = sort__sym_print,
467}; 462};