diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-06-27 18:42:26 -0400 |
---|---|---|
committer | Nathan Scott <nathans@sgi.com> | 2006-06-27 18:42:26 -0400 |
commit | 73024cf11522c0233228453984b2a2b37885e336 (patch) | |
tree | a779d55555711b23459510f99e321e36e1e69e3c | |
parent | 97dfd70c8958a634157e0b35711cca01ff6f959b (diff) |
[XFS] Fix realtime subvolume expansion, a porting bug b0rked it. Coverity
made me look at this code (bug id #344). We only return with
XFS_ERROR(EINVAL) if mp->m_rtdev_targp is valid and pass it otherwise to
xfs_read_buf() where some function calls later it gets dereferenced by an
assert.
SGI-PV: 954266
SGI-Modid: xfs-linux-melb:xfs-kern:26363a
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Nathan Scott <nathans@sgi.com>
-rw-r--r-- | fs/xfs/xfs_rtalloc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c index 0c1e42b037ef..5a0b678956e0 100644 --- a/fs/xfs/xfs_rtalloc.c +++ b/fs/xfs/xfs_rtalloc.c | |||
@@ -1929,7 +1929,7 @@ xfs_growfs_rt( | |||
1929 | /* | 1929 | /* |
1930 | * Initial error checking. | 1930 | * Initial error checking. |
1931 | */ | 1931 | */ |
1932 | if (mp->m_rtdev_targp || mp->m_rbmip == NULL || | 1932 | if (mp->m_rtdev_targp == NULL || mp->m_rbmip == NULL || |
1933 | (nrblocks = in->newblocks) <= sbp->sb_rblocks || | 1933 | (nrblocks = in->newblocks) <= sbp->sb_rblocks || |
1934 | (sbp->sb_rblocks && (in->extsize != sbp->sb_rextsize))) | 1934 | (sbp->sb_rblocks && (in->extsize != sbp->sb_rextsize))) |
1935 | return XFS_ERROR(EINVAL); | 1935 | return XFS_ERROR(EINVAL); |