aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2008-04-27 09:38:24 -0400
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2008-04-27 09:38:24 -0400
commitcc12175ff2eadb0918d573169af88429440a21ae (patch)
treef629ab2033937c2d05b7044769db827e85bc5c2f
parentef87f8d09639cbe22201c7dfe07586c43b255108 (diff)
ide: remove obsoleted "hdx=noautotune" kernel parameter
Remove obsoleted "hdx=noautotune" kernel parameter (it has been obsoleted since 1 Nov 2004). Then make ide_hwif_t.autotune a single bit flag and remove no longer needed IDE_TUNE_* defines. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r--drivers/ide/ide-cd.c4
-rw-r--r--drivers/ide/ide-probe.c10
-rw-r--r--drivers/ide/ide.c7
-rw-r--r--include/linux/ide.h9
4 files changed, 6 insertions, 24 deletions
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index ad984322da94..164adc3a48a2 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1909,9 +1909,7 @@ static int ide_cdrom_setup(ide_drive_t *drive)
1909 /* set correct block size */ 1909 /* set correct block size */
1910 blk_queue_hardsect_size(drive->queue, CD_FRAMESIZE); 1910 blk_queue_hardsect_size(drive->queue, CD_FRAMESIZE);
1911 1911
1912 if (drive->autotune == IDE_TUNE_DEFAULT || 1912 drive->dsc_overlap = (drive->next != drive);
1913 drive->autotune == IDE_TUNE_AUTO)
1914 drive->dsc_overlap = (drive->next != drive);
1915 1913
1916 if (ide_cdrom_register(drive, nslots)) { 1914 if (ide_cdrom_register(drive, nslots)) {
1917 printk(KERN_ERR "%s: %s failed to register device with the" 1915 printk(KERN_ERR "%s: %s failed to register device with the"
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 004062b5751e..9b0a3cba2b03 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -472,9 +472,7 @@ static int do_probe (ide_drive_t *drive, u8 cmd)
472 if (stat == (BUSY_STAT | READY_STAT)) 472 if (stat == (BUSY_STAT | READY_STAT))
473 return 4; 473 return 4;
474 474
475 if ((rc == 1 && cmd == WIN_PIDENTIFY) && 475 if (rc == 1 && cmd == WIN_PIDENTIFY) {
476 ((drive->autotune == IDE_TUNE_DEFAULT) ||
477 (drive->autotune == IDE_TUNE_AUTO))) {
478 printk(KERN_ERR "%s: no response (status = 0x%02x), " 476 printk(KERN_ERR "%s: no response (status = 0x%02x), "
479 "resetting drive\n", drive->name, stat); 477 "resetting drive\n", drive->name, stat);
480 msleep(50); 478 msleep(50);
@@ -829,13 +827,9 @@ static void ide_port_tune_devices(ide_hwif_t *hwif)
829 ide_drive_t *drive = &hwif->drives[unit]; 827 ide_drive_t *drive = &hwif->drives[unit];
830 828
831 if (drive->present) { 829 if (drive->present) {
832 if (drive->autotune == IDE_TUNE_AUTO) 830 if (drive->autotune)
833 ide_set_max_pio(drive); 831 ide_set_max_pio(drive);
834 832
835 if (drive->autotune != IDE_TUNE_DEFAULT &&
836 drive->autotune != IDE_TUNE_AUTO)
837 continue;
838
839 drive->nice1 = 1; 833 drive->nice1 = 1;
840 834
841 if (hwif->dma_ops) 835 if (hwif->dma_ops)
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index a33840d11770..8eb7f83b0dda 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -900,7 +900,7 @@ static int __init ide_setup(char *s)
900 if (s[0] == 'h' && s[1] == 'd' && s[2] >= 'a' && s[2] <= max_drive) { 900 if (s[0] == 'h' && s[1] == 'd' && s[2] >= 'a' && s[2] <= max_drive) {
901 const char *hd_words[] = { 901 const char *hd_words[] = {
902 "none", "noprobe", "nowerr", "cdrom", "nodma", 902 "none", "noprobe", "nowerr", "cdrom", "nodma",
903 "autotune", "noautotune", "-8", "-9", "-10", 903 "autotune", "-7", "-8", "-9", "-10",
904 "noflush", "remap", "remap63", "scsi", NULL }; 904 "noflush", "remap", "remap63", "scsi", NULL };
905 unit = s[2] - 'a'; 905 unit = s[2] - 'a';
906 hw = unit / MAX_DRIVES; 906 hw = unit / MAX_DRIVES;
@@ -929,10 +929,7 @@ static int __init ide_setup(char *s)
929 drive->nodma = 1; 929 drive->nodma = 1;
930 goto done; 930 goto done;
931 case -6: /* "autotune" */ 931 case -6: /* "autotune" */
932 drive->autotune = IDE_TUNE_AUTO; 932 drive->autotune = 1;
933 goto obsolete_option;
934 case -7: /* "noautotune" */
935 drive->autotune = IDE_TUNE_NOAUTO;
936 goto obsolete_option; 933 goto obsolete_option;
937 case -11: /* noflush */ 934 case -11: /* noflush */
938 drive->noflush = 1; 935 drive->noflush = 1;
diff --git a/include/linux/ide.h b/include/linux/ide.h
index 5f8df20a9e39..78e5fcaebd79 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -48,13 +48,6 @@ typedef unsigned char byte; /* used everywhere */
48#define ERROR_RECAL 1 /* Recalibrate every 2nd retry */ 48#define ERROR_RECAL 1 /* Recalibrate every 2nd retry */
49 49
50/* 50/*
51 * Tune flags
52 */
53#define IDE_TUNE_NOAUTO 2
54#define IDE_TUNE_AUTO 1
55#define IDE_TUNE_DEFAULT 0
56
57/*
58 * state flags 51 * state flags
59 */ 52 */
60 53
@@ -328,7 +321,7 @@ typedef struct ide_drive_s {
328 unsigned atapi_overlap : 1; /* ATAPI overlap (not supported) */ 321 unsigned atapi_overlap : 1; /* ATAPI overlap (not supported) */
329 unsigned doorlocking : 1; /* for removable only: door lock/unlock works */ 322 unsigned doorlocking : 1; /* for removable only: door lock/unlock works */
330 unsigned nodma : 1; /* disallow DMA */ 323 unsigned nodma : 1; /* disallow DMA */
331 unsigned autotune : 2; /* 0=default, 1=autotune, 2=noautotune */ 324 unsigned autotune : 1; /* 0=default, 1=autotune */
332 unsigned remap_0_to_1 : 1; /* 0=noremap, 1=remap 0->1 (for EZDrive) */ 325 unsigned remap_0_to_1 : 1; /* 0=noremap, 1=remap 0->1 (for EZDrive) */
333 unsigned blocked : 1; /* 1=powermanagment told us not to do anything, so sleep nicely */ 326 unsigned blocked : 1; /* 1=powermanagment told us not to do anything, so sleep nicely */
334 unsigned vdma : 1; /* 1=doing PIO over DMA 0=doing normal DMA */ 327 unsigned vdma : 1; /* 1=doing PIO over DMA 0=doing normal DMA */