diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-05 18:41:44 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2010-08-05 18:46:47 -0400 |
commit | 71e7cf3a37ba6189fa7215555e8e760b400fc23b (patch) | |
tree | 6b0fcb189beca167f8376e9d6ab9b3f598d861ae | |
parent | 33e26a1b492d21283d1372ddd547562d371dab98 (diff) |
perf report: Speed up exit path
When cmd_record exits the whole perf binary will exit right after,
so no need to traverse lots of complex data structures freeing them.
Sticked a comment for leak detectives and for a experiment with obstacks
to be performed so that we can speed up freeing that memory.
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-report.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 4a7a74362451..55fc1f46892a 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -348,7 +348,18 @@ static int __cmd_report(void) | |||
348 | hists__tty_browse_tree(&session->hists_tree, help); | 348 | hists__tty_browse_tree(&session->hists_tree, help); |
349 | 349 | ||
350 | out_delete: | 350 | out_delete: |
351 | perf_session__delete(session); | 351 | /* |
352 | * Speed up the exit process, for large files this can | ||
353 | * take quite a while. | ||
354 | * | ||
355 | * XXX Enable this when using valgrind or if we ever | ||
356 | * librarize this command. | ||
357 | * | ||
358 | * Also experiment with obstacks to see how much speed | ||
359 | * up we'll get here. | ||
360 | * | ||
361 | * perf_session__delete(session); | ||
362 | */ | ||
352 | return ret; | 363 | return ret; |
353 | } | 364 | } |
354 | 365 | ||