diff options
author | Jan Kara <jack@suse.cz> | 2009-08-11 11:27:21 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2009-09-16 11:44:10 -0400 |
commit | 3adae9da0b35d2ca908039f42a1e90395c335181 (patch) | |
tree | bc7d971ffb673dab926a4c3d02411a2b78b58f6a | |
parent | 9c28cbccec66a5ca292c6659bf5a0fe0c8459fa7 (diff) |
jbd: Annotate transaction start also for journal_restart()
lockdep annotation for a transaction start has been at the end of
journal_start(). But a transaction is also started from journal_restart(). Move
the lockdep annotation to start_this_handle() which covers both cases.
Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r-- | fs/jbd/transaction.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index 833c1675a00c..006f9ad838a2 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c | |||
@@ -229,6 +229,8 @@ repeat_locked: | |||
229 | __log_space_left(journal)); | 229 | __log_space_left(journal)); |
230 | spin_unlock(&transaction->t_handle_lock); | 230 | spin_unlock(&transaction->t_handle_lock); |
231 | spin_unlock(&journal->j_state_lock); | 231 | spin_unlock(&journal->j_state_lock); |
232 | |||
233 | lock_map_acquire(&handle->h_lockdep_map); | ||
232 | out: | 234 | out: |
233 | if (unlikely(new_transaction)) /* It's usually NULL */ | 235 | if (unlikely(new_transaction)) /* It's usually NULL */ |
234 | kfree(new_transaction); | 236 | kfree(new_transaction); |
@@ -293,9 +295,6 @@ handle_t *journal_start(journal_t *journal, int nblocks) | |||
293 | handle = ERR_PTR(err); | 295 | handle = ERR_PTR(err); |
294 | goto out; | 296 | goto out; |
295 | } | 297 | } |
296 | |||
297 | lock_map_acquire(&handle->h_lockdep_map); | ||
298 | |||
299 | out: | 298 | out: |
300 | return handle; | 299 | return handle; |
301 | } | 300 | } |
@@ -417,6 +416,7 @@ int journal_restart(handle_t *handle, int nblocks) | |||
417 | __log_start_commit(journal, transaction->t_tid); | 416 | __log_start_commit(journal, transaction->t_tid); |
418 | spin_unlock(&journal->j_state_lock); | 417 | spin_unlock(&journal->j_state_lock); |
419 | 418 | ||
419 | lock_map_release(&handle->h_lockdep_map); | ||
420 | handle->h_buffer_credits = nblocks; | 420 | handle->h_buffer_credits = nblocks; |
421 | ret = start_this_handle(journal, handle); | 421 | ret = start_this_handle(journal, handle); |
422 | return ret; | 422 | return ret; |