diff options
| author | Samuel Ortiz <samuel@sortiz.org> | 2006-09-28 01:50:06 -0400 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-09-28 21:02:54 -0400 |
| commit | febac9b93724f3ee293e7e5450043ae28e61531a (patch) | |
| tree | 4671a821410ffa228d8b6aac8457c444e0dbac9e | |
| parent | 895de090d4302a02a77cdf366fc6e54fc2001857 (diff) | |
[IrDA] stir4200: removing undocumented bits handling
FIFOCTL_RXERR and FIFOCTL_TXERR are undocumented bits, according to the
Sigmatel datasheet. We should thus not take any assumption on their values
and semantics.
Problem spotted by andrzej zaborowski <balrogg@gmail.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/irda/stir4200.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c index d61b208b52a2..12103c93f7ef 100644 --- a/drivers/net/irda/stir4200.c +++ b/drivers/net/irda/stir4200.c | |||
| @@ -149,8 +149,6 @@ enum StirFifoCtlMask { | |||
| 149 | FIFOCTL_DIR = 0x10, | 149 | FIFOCTL_DIR = 0x10, |
| 150 | FIFOCTL_CLR = 0x08, | 150 | FIFOCTL_CLR = 0x08, |
| 151 | FIFOCTL_EMPTY = 0x04, | 151 | FIFOCTL_EMPTY = 0x04, |
| 152 | FIFOCTL_RXERR = 0x02, | ||
| 153 | FIFOCTL_TXERR = 0x01, | ||
| 154 | }; | 152 | }; |
| 155 | 153 | ||
| 156 | enum StirDiagMask { | 154 | enum StirDiagMask { |
| @@ -615,19 +613,6 @@ static int fifo_txwait(struct stir_cb *stir, int space) | |||
| 615 | 613 | ||
| 616 | pr_debug("fifo status 0x%lx count %lu\n", status, count); | 614 | pr_debug("fifo status 0x%lx count %lu\n", status, count); |
| 617 | 615 | ||
| 618 | /* error when receive/transmit fifo gets confused */ | ||
| 619 | if (status & FIFOCTL_RXERR) { | ||
| 620 | stir->stats.rx_fifo_errors++; | ||
| 621 | stir->stats.rx_errors++; | ||
| 622 | break; | ||
| 623 | } | ||
| 624 | |||
| 625 | if (status & FIFOCTL_TXERR) { | ||
| 626 | stir->stats.tx_fifo_errors++; | ||
| 627 | stir->stats.tx_errors++; | ||
| 628 | break; | ||
| 629 | } | ||
| 630 | |||
| 631 | /* is fifo receiving already, or empty */ | 616 | /* is fifo receiving already, or empty */ |
| 632 | if (!(status & FIFOCTL_DIR) | 617 | if (!(status & FIFOCTL_DIR) |
| 633 | || (status & FIFOCTL_EMPTY)) | 618 | || (status & FIFOCTL_EMPTY)) |
