diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-11-12 11:00:25 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-11-12 11:00:25 -0500 |
| commit | fe7e96f66b2622d8492ee9dd7fc08b811086caca (patch) | |
| tree | 524b78f3a5a9c35bee8b437e9c4738d42fc454a7 | |
| parent | 0f90933c477c061df6daf42d814ff2012aea43cc (diff) | |
| parent | a26d279ea87e9fef2cf8a44b371e48e6091975a6 (diff) | |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6:
APPARMOR: Fix memory leak of apparmor_init()
APPARMOR: Fix memory leak of alloc_namespace()
| -rw-r--r-- | security/apparmor/lsm.c | 6 | ||||
| -rw-r--r-- | security/apparmor/policy.c | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index cf1de4462ccd..b7106f192b75 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c | |||
| @@ -922,7 +922,7 @@ static int __init apparmor_init(void) | |||
| 922 | error = register_security(&apparmor_ops); | 922 | error = register_security(&apparmor_ops); |
| 923 | if (error) { | 923 | if (error) { |
| 924 | AA_ERROR("Unable to register AppArmor\n"); | 924 | AA_ERROR("Unable to register AppArmor\n"); |
| 925 | goto register_security_out; | 925 | goto set_init_cxt_out; |
| 926 | } | 926 | } |
| 927 | 927 | ||
| 928 | /* Report that AppArmor successfully initialized */ | 928 | /* Report that AppArmor successfully initialized */ |
| @@ -936,6 +936,9 @@ static int __init apparmor_init(void) | |||
| 936 | 936 | ||
| 937 | return error; | 937 | return error; |
| 938 | 938 | ||
| 939 | set_init_cxt_out: | ||
| 940 | aa_free_task_context(current->real_cred->security); | ||
| 941 | |||
| 939 | register_security_out: | 942 | register_security_out: |
| 940 | aa_free_root_ns(); | 943 | aa_free_root_ns(); |
| 941 | 944 | ||
| @@ -944,7 +947,6 @@ alloc_out: | |||
| 944 | 947 | ||
| 945 | apparmor_enabled = 0; | 948 | apparmor_enabled = 0; |
| 946 | return error; | 949 | return error; |
| 947 | |||
| 948 | } | 950 | } |
| 949 | 951 | ||
| 950 | security_initcall(apparmor_init); | 952 | security_initcall(apparmor_init); |
diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c index 52cc865f1464..4f0eadee78b8 100644 --- a/security/apparmor/policy.c +++ b/security/apparmor/policy.c | |||
| @@ -306,7 +306,7 @@ static struct aa_namespace *alloc_namespace(const char *prefix, | |||
| 306 | return ns; | 306 | return ns; |
| 307 | 307 | ||
| 308 | fail_unconfined: | 308 | fail_unconfined: |
| 309 | kzfree(ns->base.name); | 309 | kzfree(ns->base.hname); |
| 310 | fail_ns: | 310 | fail_ns: |
| 311 | kzfree(ns); | 311 | kzfree(ns); |
| 312 | return NULL; | 312 | return NULL; |
