diff options
| author | Heiko Carstens <heiko.carstens@de.ibm.com> | 2008-08-01 10:39:23 -0400 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2008-08-01 10:39:36 -0400 |
| commit | fc7e1e4b1ca69109d0f694e47ef2328dcb0ebe6e (patch) | |
| tree | 2435a59d78c10b5bd475f126cbed3251c99bd781 | |
| parent | 26f746f3e3bb44b37a894318aa8e808b914ad663 (diff) | |
[S390] dont use kthread for smp_rescan_cpus().
Since git commit 3da1c84c00c7e5fa8348336bd8c342f9128b0f14
"workqueues: make get_online_cpus() useable for work->func()"
it is safe to call get_online_cpus() from workqueue context.
So remove the kthread workaround again.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
| -rw-r--r-- | drivers/s390/char/sclp_config.c | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/drivers/s390/char/sclp_config.c b/drivers/s390/char/sclp_config.c index fff4ff485d9b..4cebd6ee6d27 100644 --- a/drivers/s390/char/sclp_config.c +++ b/drivers/s390/char/sclp_config.c | |||
| @@ -8,7 +8,6 @@ | |||
| 8 | #include <linux/init.h> | 8 | #include <linux/init.h> |
| 9 | #include <linux/errno.h> | 9 | #include <linux/errno.h> |
| 10 | #include <linux/cpu.h> | 10 | #include <linux/cpu.h> |
| 11 | #include <linux/kthread.h> | ||
| 12 | #include <linux/sysdev.h> | 11 | #include <linux/sysdev.h> |
| 13 | #include <linux/workqueue.h> | 12 | #include <linux/workqueue.h> |
| 14 | #include <asm/smp.h> | 13 | #include <asm/smp.h> |
| @@ -41,19 +40,9 @@ static void sclp_cpu_capability_notify(struct work_struct *work) | |||
| 41 | put_online_cpus(); | 40 | put_online_cpus(); |
| 42 | } | 41 | } |
| 43 | 42 | ||
| 44 | static int sclp_cpu_kthread(void *data) | ||
| 45 | { | ||
| 46 | smp_rescan_cpus(); | ||
| 47 | return 0; | ||
| 48 | } | ||
| 49 | |||
| 50 | static void __ref sclp_cpu_change_notify(struct work_struct *work) | 43 | static void __ref sclp_cpu_change_notify(struct work_struct *work) |
| 51 | { | 44 | { |
| 52 | /* Can't call smp_rescan_cpus() from workqueue context since it may | 45 | smp_rescan_cpus(); |
| 53 | * deadlock in case of cpu hotplug. So we have to create a kernel | ||
| 54 | * thread in order to call it. | ||
| 55 | */ | ||
| 56 | kthread_run(sclp_cpu_kthread, NULL, "cpu_rescan"); | ||
| 57 | } | 46 | } |
| 58 | 47 | ||
| 59 | static void sclp_conf_receiver_fn(struct evbuf_header *evbuf) | 48 | static void sclp_conf_receiver_fn(struct evbuf_header *evbuf) |
