diff options
| author | Linas Vepstas <linas@austin.ibm.com> | 2007-04-13 18:34:15 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-05-02 22:02:39 -0400 |
| commit | ebf42c0edd5ee325043d4ae8fbb8caebd707e791 (patch) | |
| tree | c4149b7dd04cea14d4f4b934cd78ddb4ad055d00 | |
| parent | bf0af511fcc856649a2a39c627828695b580d124 (diff) | |
PCI: rpaphp: remove a call that does nothing but a pointer lookup
Delete another stovepipe: a call to a routine which does nothing.
Remove un-needed semaphore as well.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: John Rose <johnrose@austin.ibm.com>
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/pci/hotplug/rpaphp_core.c | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c index cab7cee65741..3970cacc0b86 100644 --- a/drivers/pci/hotplug/rpaphp_core.c +++ b/drivers/pci/hotplug/rpaphp_core.c | |||
| @@ -54,11 +54,6 @@ MODULE_LICENSE("GPL"); | |||
| 54 | 54 | ||
| 55 | module_param(debug, bool, 0644); | 55 | module_param(debug, bool, 0644); |
| 56 | 56 | ||
| 57 | static int rpaphp_get_attention_status(struct slot *slot) | ||
| 58 | { | ||
| 59 | return slot->hotplug_slot->info->attention_status; | ||
| 60 | } | ||
| 61 | |||
| 62 | /** | 57 | /** |
| 63 | * set_attention_status - set attention LED | 58 | * set_attention_status - set attention LED |
| 64 | * echo 0 > attention -- set LED OFF | 59 | * echo 0 > attention -- set LED OFF |
| @@ -95,8 +90,6 @@ static int set_attention_status(struct hotplug_slot *hotplug_slot, u8 value) | |||
| 95 | * get_power_status - get power status of a slot | 90 | * get_power_status - get power status of a slot |
| 96 | * @hotplug_slot: slot to get status | 91 | * @hotplug_slot: slot to get status |
| 97 | * @value: pointer to store status | 92 | * @value: pointer to store status |
| 98 | * | ||
| 99 | * | ||
| 100 | */ | 93 | */ |
| 101 | static int get_power_status(struct hotplug_slot *hotplug_slot, u8 * value) | 94 | static int get_power_status(struct hotplug_slot *hotplug_slot, u8 * value) |
| 102 | { | 95 | { |
| @@ -113,18 +106,12 @@ static int get_power_status(struct hotplug_slot *hotplug_slot, u8 * value) | |||
| 113 | 106 | ||
| 114 | /** | 107 | /** |
| 115 | * get_attention_status - get attention LED status | 108 | * get_attention_status - get attention LED status |
| 116 | * | ||
| 117 | * | ||
| 118 | */ | 109 | */ |
| 119 | static int get_attention_status(struct hotplug_slot *hotplug_slot, u8 * value) | 110 | static int get_attention_status(struct hotplug_slot *hotplug_slot, u8 * value) |
| 120 | { | 111 | { |
| 121 | int retval = 0; | ||
| 122 | struct slot *slot = (struct slot *)hotplug_slot->private; | 112 | struct slot *slot = (struct slot *)hotplug_slot->private; |
| 123 | 113 | *value = slot->hotplug_slot->info->attention_status; | |
| 124 | down(&rpaphp_sem); | 114 | return 0; |
| 125 | *value = rpaphp_get_attention_status(slot); | ||
| 126 | up(&rpaphp_sem); | ||
| 127 | return retval; | ||
| 128 | } | 115 | } |
| 129 | 116 | ||
| 130 | static int get_adapter_status(struct hotplug_slot *hotplug_slot, u8 * value) | 117 | static int get_adapter_status(struct hotplug_slot *hotplug_slot, u8 * value) |
