diff options
| author | Andi Kleen <ak@suse.de> | 2006-02-25 22:18:37 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-02-26 12:53:30 -0500 |
| commit | e78256b8f3e2850ad55c2d69e1429e6c2607afd3 (patch) | |
| tree | 0d0e0f7d49000d3b047beaaa7f47a273c16b047d | |
| parent | 6070f9ec6b03cc46cd0242523326f7a296f47c1c (diff) | |
[PATCH] x86-64/i386: Use common X86_PM_TIMER option and make it EMBEDDED
This makes x86-64 use the common X86_PM_TIMER Kconfig entry in drivers/acpi
And since PM timer is needed for correct timing on a lot of systems
now (e.g. AMD dual cores) and we often get bug reports from people
who forgot to set it make it depend on CONFIG_EMBEDDED. x86-64 had
this change before and it's a good thing.
I also fixed the description slightly to make this more clear.
Cc: len.brown@intel.com
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | arch/x86_64/Kconfig | 15 | ||||
| -rw-r--r-- | drivers/acpi/Kconfig | 8 |
2 files changed, 3 insertions, 20 deletions
diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig index 2f9deca31cc9..babc31b3ef12 100644 --- a/arch/x86_64/Kconfig +++ b/arch/x86_64/Kconfig | |||
| @@ -354,21 +354,6 @@ config HPET_TIMER | |||
| 354 | as it is off-chip. You can find the HPET spec at | 354 | as it is off-chip. You can find the HPET spec at |
| 355 | <http://www.intel.com/hardwaredesign/hpetspec.htm>. | 355 | <http://www.intel.com/hardwaredesign/hpetspec.htm>. |
| 356 | 356 | ||
| 357 | config X86_PM_TIMER | ||
| 358 | bool "PM timer" if EMBEDDED | ||
| 359 | depends on ACPI | ||
| 360 | default y | ||
| 361 | help | ||
| 362 | Support the ACPI PM timer for time keeping. This is slow, | ||
| 363 | but is useful on some chipsets without HPET on systems with more | ||
| 364 | than one CPU. On a single processor or single socket multi core | ||
| 365 | system it is normally not required. | ||
| 366 | When the PM timer is active 64bit vsyscalls are disabled | ||
| 367 | and should not be enabled (/proc/sys/kernel/vsyscall64 should | ||
| 368 | not be changed). | ||
| 369 | The kernel selects the PM timer only as a last resort, so it is | ||
| 370 | useful to enable just in case. | ||
| 371 | |||
| 372 | config HPET_EMULATE_RTC | 357 | config HPET_EMULATE_RTC |
| 373 | bool "Provide RTC interrupt" | 358 | bool "Provide RTC interrupt" |
| 374 | depends on HPET_TIMER && RTC=y | 359 | depends on HPET_TIMER && RTC=y |
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 0cce28c4025b..9dc2fbe6efa7 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig | |||
| @@ -285,9 +285,8 @@ config ACPI_SYSTEM | |||
| 285 | dump your ACPI DSDT table using /proc/acpi/dsdt. | 285 | dump your ACPI DSDT table using /proc/acpi/dsdt. |
| 286 | 286 | ||
| 287 | config X86_PM_TIMER | 287 | config X86_PM_TIMER |
| 288 | bool "Power Management Timer Support" | 288 | bool "Power Management Timer Support" if EMBEDDED |
| 289 | depends on X86 | 289 | depends on X86 |
| 290 | depends on !X86_64 | ||
| 291 | default y | 290 | default y |
| 292 | help | 291 | help |
| 293 | The Power Management Timer is available on all ACPI-capable, | 292 | The Power Management Timer is available on all ACPI-capable, |
| @@ -298,9 +297,8 @@ config X86_PM_TIMER | |||
| 298 | voltage scaling, unlike the commonly used Time Stamp Counter | 297 | voltage scaling, unlike the commonly used Time Stamp Counter |
| 299 | (TSC) timing source. | 298 | (TSC) timing source. |
| 300 | 299 | ||
| 301 | So, if you see messages like 'Losing too many ticks!' in the | 300 | You should nearly always say Y here because many modern |
| 302 | kernel logs, and/or you are using this on a notebook which | 301 | systems require this timer. |
| 303 | does not yet have an HPET, you should say "Y" here. | ||
| 304 | 302 | ||
| 305 | config ACPI_CONTAINER | 303 | config ACPI_CONTAINER |
| 306 | tristate "ACPI0004,PNP0A05 and PNP0A06 Container Driver (EXPERIMENTAL)" | 304 | tristate "ACPI0004,PNP0A05 and PNP0A06 Container Driver (EXPERIMENTAL)" |
