diff options
| author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2010-03-16 17:53:08 -0400 |
|---|---|---|
| committer | Jesse Barnes <jbarnes@virtuousgeek.org> | 2010-03-24 16:21:36 -0400 |
| commit | e1944c6b0fba80a7837c1cbc47dfbf46e1274a4b (patch) | |
| tree | b5431d6a428847b83b85e6762e94b2abbb781099 | |
| parent | 7b8ff6da028232aadae6bcc7c7406c8966d0b3c4 (diff) | |
PCI: print resources consistently with %pR
No functional change; just print resources in the conventional style.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
| -rw-r--r-- | drivers/pci/hotplug/pciehp_hpc.c | 5 | ||||
| -rw-r--r-- | drivers/pci/ioapic.c | 9 | ||||
| -rw-r--r-- | drivers/pcmcia/rsrc_nonstatic.c | 12 |
3 files changed, 10 insertions, 16 deletions
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 40b48f569b1e..9665d6b17a2a 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c | |||
| @@ -832,9 +832,8 @@ static inline void dbg_ctrl(struct controller *ctrl) | |||
| 832 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { | 832 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { |
| 833 | if (!pci_resource_len(pdev, i)) | 833 | if (!pci_resource_len(pdev, i)) |
| 834 | continue; | 834 | continue; |
| 835 | ctrl_info(ctrl, " PCI resource [%d] : 0x%llx@0x%llx\n", | 835 | ctrl_info(ctrl, " PCI resource [%d] : %pR\n", |
| 836 | i, (unsigned long long)pci_resource_len(pdev, i), | 836 | i, &pdev->resource[i]); |
| 837 | (unsigned long long)pci_resource_start(pdev, i)); | ||
| 838 | } | 837 | } |
| 839 | ctrl_info(ctrl, "Slot Capabilities : 0x%08x\n", ctrl->slot_cap); | 838 | ctrl_info(ctrl, "Slot Capabilities : 0x%08x\n", ctrl->slot_cap); |
| 840 | ctrl_info(ctrl, " Physical Slot Number : %d\n", PSN(ctrl)); | 839 | ctrl_info(ctrl, " Physical Slot Number : %d\n", PSN(ctrl)); |
diff --git a/drivers/pci/ioapic.c b/drivers/pci/ioapic.c index 3e0d7b5dd1b9..fb9fdf4a42bf 100644 --- a/drivers/pci/ioapic.c +++ b/drivers/pci/ioapic.c | |||
| @@ -31,9 +31,9 @@ static int ioapic_probe(struct pci_dev *dev, const struct pci_device_id *ent) | |||
| 31 | acpi_status status; | 31 | acpi_status status; |
| 32 | unsigned long long gsb; | 32 | unsigned long long gsb; |
| 33 | struct ioapic *ioapic; | 33 | struct ioapic *ioapic; |
| 34 | u64 addr; | ||
| 35 | int ret; | 34 | int ret; |
| 36 | char *type; | 35 | char *type; |
| 36 | struct resource *res; | ||
| 37 | 37 | ||
| 38 | handle = DEVICE_ACPI_HANDLE(&dev->dev); | 38 | handle = DEVICE_ACPI_HANDLE(&dev->dev); |
| 39 | if (!handle) | 39 | if (!handle) |
| @@ -69,13 +69,12 @@ static int ioapic_probe(struct pci_dev *dev, const struct pci_device_id *ent) | |||
| 69 | if (pci_request_region(dev, 0, type)) | 69 | if (pci_request_region(dev, 0, type)) |
| 70 | goto exit_disable; | 70 | goto exit_disable; |
| 71 | 71 | ||
| 72 | addr = pci_resource_start(dev, 0); | 72 | res = &dev->resource[0]; |
| 73 | if (acpi_register_ioapic(ioapic->handle, addr, ioapic->gsi_base)) | 73 | if (acpi_register_ioapic(ioapic->handle, res->start, ioapic->gsi_base)) |
| 74 | goto exit_release; | 74 | goto exit_release; |
| 75 | 75 | ||
| 76 | pci_set_drvdata(dev, ioapic); | 76 | pci_set_drvdata(dev, ioapic); |
| 77 | dev_info(&dev->dev, "%s at %#llx, GSI %u\n", type, addr, | 77 | dev_info(&dev->dev, "%s at %pR, GSI %u\n", type, res, ioapic->gsi_base); |
| 78 | ioapic->gsi_base); | ||
| 79 | return 0; | 78 | return 0; |
| 80 | 79 | ||
| 81 | exit_release: | 80 | exit_release: |
diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index 4663b3fa9f96..b4968ca5bc9d 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c | |||
| @@ -867,10 +867,8 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) | |||
| 867 | if (res == &ioport_resource) | 867 | if (res == &ioport_resource) |
| 868 | continue; | 868 | continue; |
| 869 | dev_printk(KERN_INFO, &s->cb_dev->dev, | 869 | dev_printk(KERN_INFO, &s->cb_dev->dev, |
| 870 | "pcmcia: parent PCI bridge I/O " | 870 | "pcmcia: parent PCI bridge window: %pR\n", |
| 871 | "window: 0x%llx - 0x%llx\n", | 871 | res); |
| 872 | (unsigned long long)res->start, | ||
| 873 | (unsigned long long)res->end); | ||
| 874 | if (!adjust_io(s, ADD_MANAGED_RESOURCE, res->start, res->end)) | 872 | if (!adjust_io(s, ADD_MANAGED_RESOURCE, res->start, res->end)) |
| 875 | done |= IORESOURCE_IO; | 873 | done |= IORESOURCE_IO; |
| 876 | 874 | ||
| @@ -880,10 +878,8 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) | |||
| 880 | if (res == &iomem_resource) | 878 | if (res == &iomem_resource) |
| 881 | continue; | 879 | continue; |
| 882 | dev_printk(KERN_INFO, &s->cb_dev->dev, | 880 | dev_printk(KERN_INFO, &s->cb_dev->dev, |
| 883 | "pcmcia: parent PCI bridge Memory " | 881 | "pcmcia: parent PCI bridge window: %pR\n", |
| 884 | "window: 0x%llx - 0x%llx\n", | 882 | res); |
| 885 | (unsigned long long)res->start, | ||
| 886 | (unsigned long long)res->end); | ||
| 887 | if (!adjust_memory(s, ADD_MANAGED_RESOURCE, res->start, res->end)) | 883 | if (!adjust_memory(s, ADD_MANAGED_RESOURCE, res->start, res->end)) |
| 888 | done |= IORESOURCE_MEM; | 884 | done |= IORESOURCE_MEM; |
| 889 | } | 885 | } |
