diff options
| author | Takashi Iwai <tiwai@suse.de> | 2009-02-16 04:13:03 -0500 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2009-02-16 04:16:27 -0500 |
| commit | d14a7e0bfc4aed6452a436c9836903fbd1a5d6ad (patch) | |
| tree | afe70ccdd66d893fd719ad4c528b30c79b890ef4 | |
| parent | 9411e21cd0cc4fd046b4f448417b0e103e80951c (diff) | |
Revert "Sound: hda - Restore PCI configuration space with interrupts off"
This reverts commit 32e176c14d7a425b681ef003c9061001ddb7fc7b.
That commit caused a regression with suspend on Thinkpad SL300.
Reference: kernel bug#12711
http://bugzilla.kernel.org/show_bug.cgi?id=12711
Tested-by: Alexandre Rostovtsev <tetromino@gmail.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/hda_intel.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 11e791b965f6..c8d9178f47e5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
| @@ -1947,16 +1947,13 @@ static int azx_suspend(struct pci_dev *pci, pm_message_t state) | |||
| 1947 | return 0; | 1947 | return 0; |
| 1948 | } | 1948 | } |
| 1949 | 1949 | ||
| 1950 | static int azx_resume_early(struct pci_dev *pci) | ||
| 1951 | { | ||
| 1952 | return pci_restore_state(pci); | ||
| 1953 | } | ||
| 1954 | |||
| 1955 | static int azx_resume(struct pci_dev *pci) | 1950 | static int azx_resume(struct pci_dev *pci) |
| 1956 | { | 1951 | { |
| 1957 | struct snd_card *card = pci_get_drvdata(pci); | 1952 | struct snd_card *card = pci_get_drvdata(pci); |
| 1958 | struct azx *chip = card->private_data; | 1953 | struct azx *chip = card->private_data; |
| 1959 | 1954 | ||
| 1955 | pci_set_power_state(pci, PCI_D0); | ||
| 1956 | pci_restore_state(pci); | ||
| 1960 | if (pci_enable_device(pci) < 0) { | 1957 | if (pci_enable_device(pci) < 0) { |
| 1961 | printk(KERN_ERR "hda-intel: pci_enable_device failed, " | 1958 | printk(KERN_ERR "hda-intel: pci_enable_device failed, " |
| 1962 | "disabling device\n"); | 1959 | "disabling device\n"); |
| @@ -2468,7 +2465,6 @@ static struct pci_driver driver = { | |||
| 2468 | .remove = __devexit_p(azx_remove), | 2465 | .remove = __devexit_p(azx_remove), |
| 2469 | #ifdef CONFIG_PM | 2466 | #ifdef CONFIG_PM |
| 2470 | .suspend = azx_suspend, | 2467 | .suspend = azx_suspend, |
| 2471 | .resume_early = azx_resume_early, | ||
| 2472 | .resume = azx_resume, | 2468 | .resume = azx_resume, |
| 2473 | #endif | 2469 | #endif |
| 2474 | }; | 2470 | }; |
