diff options
| author | Andy Currid <ACurrid@nvidia.com> | 2006-06-08 03:43:39 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-08 18:12:21 -0400 |
| commit | a2ef3a50f19f64d350bdc0aa15c31ae4b8973f57 (patch) | |
| tree | a34de089cfe8cf433eca46b0aaf3d81e208aae85 | |
| parent | d44647b0a6e48d18a1402dfa9052d85c4fe98341 (diff) | |
[PATCH] Fix HPET operation on 64-bit NVIDIA platforms
From: "Andy Currid" <ACurrid@nvidia.com>
This patch fixes a kernel panic during boot that occurs on NVIDIA platforms
that have HPET enabled.
When HPET is enabled, the standard timer IRQ is routed to IOAPIC pin 2 and is
advertised as such in the ACPI APIC table - but an earlier workaround in the
kernel was ignoring this override. The fix is to honor timer IRQ overrides
from ACPI when HPET is detected on an NVIDIA platform.
Signed-off-by: Andy Currid <acurrid@nvidia.com>
Cc: "Brown, Len" <len.brown@intel.com>
Cc: "Yu, Luming" <luming.yu@intel.com>
Cc: Andi Kleen <ak@muc.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | arch/x86_64/kernel/io_apic.c | 30 |
1 files changed, 25 insertions, 5 deletions
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c index 0de3ea938830..9cc7031b7151 100644 --- a/arch/x86_64/kernel/io_apic.c +++ b/arch/x86_64/kernel/io_apic.c | |||
| @@ -271,6 +271,18 @@ __setup("enable_8254_timer", setup_enable_8254_timer); | |||
| 271 | #include <linux/pci_ids.h> | 271 | #include <linux/pci_ids.h> |
| 272 | #include <linux/pci.h> | 272 | #include <linux/pci.h> |
| 273 | 273 | ||
| 274 | |||
| 275 | #ifdef CONFIG_ACPI | ||
| 276 | |||
| 277 | static int nvidia_hpet_detected __initdata; | ||
| 278 | |||
| 279 | static int __init nvidia_hpet_check(unsigned long phys, unsigned long size) | ||
| 280 | { | ||
| 281 | nvidia_hpet_detected = 1; | ||
| 282 | return 0; | ||
| 283 | } | ||
| 284 | #endif | ||
| 285 | |||
| 274 | /* Temporary Hack. Nvidia and VIA boards currently only work with IO-APIC | 286 | /* Temporary Hack. Nvidia and VIA boards currently only work with IO-APIC |
| 275 | off. Check for an Nvidia or VIA PCI bridge and turn it off. | 287 | off. Check for an Nvidia or VIA PCI bridge and turn it off. |
| 276 | Use pci direct infrastructure because this runs before the PCI subsystem. | 288 | Use pci direct infrastructure because this runs before the PCI subsystem. |
| @@ -317,11 +329,19 @@ void __init check_ioapic(void) | |||
| 317 | return; | 329 | return; |
| 318 | case PCI_VENDOR_ID_NVIDIA: | 330 | case PCI_VENDOR_ID_NVIDIA: |
| 319 | #ifdef CONFIG_ACPI | 331 | #ifdef CONFIG_ACPI |
| 320 | /* All timer overrides on Nvidia | 332 | /* |
| 321 | seem to be wrong. Skip them. */ | 333 | * All timer overrides on Nvidia are |
| 322 | acpi_skip_timer_override = 1; | 334 | * wrong unless HPET is enabled. |
| 323 | printk(KERN_INFO | 335 | */ |
| 324 | "Nvidia board detected. Ignoring ACPI timer override.\n"); | 336 | nvidia_hpet_detected = 0; |
| 337 | acpi_table_parse(ACPI_HPET, | ||
| 338 | nvidia_hpet_check); | ||
| 339 | if (nvidia_hpet_detected == 0) { | ||
| 340 | acpi_skip_timer_override = 1; | ||
| 341 | printk(KERN_INFO "Nvidia board " | ||
| 342 | "detected. Ignoring ACPI " | ||
| 343 | "timer override.\n"); | ||
| 344 | } | ||
| 325 | #endif | 345 | #endif |
| 326 | /* RED-PEN skip them on mptables too? */ | 346 | /* RED-PEN skip them on mptables too? */ |
| 327 | return; | 347 | return; |
