diff options
| author | David S. Miller <davem@davemloft.net> | 2010-03-28 21:58:28 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-28 21:58:28 -0400 |
| commit | 9ce41aed0d392246eb788786253f242e829fd5e1 (patch) | |
| tree | 1d6c9f820becf2fedec4d768bbb4a83dda235b72 | |
| parent | e4afb29fa3ea759d408fa537ab6a81800708396e (diff) | |
Revert "ide: skip probe if there are no devices on the port (v2)"
This reverts commit a20b2a44eca52818ef52a94959480b7e6ea2f528.
As requested by David Fries. This makes CDROMs which are slave drives
on a ribbon without a master disappear and causes other similar kinds
of badness.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/ide/ide-probe.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c index fbedd35feb44..4c3d1bfec0c5 100644 --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c | |||
| @@ -695,14 +695,8 @@ static int ide_probe_port(ide_hwif_t *hwif) | |||
| 695 | if (irqd) | 695 | if (irqd) |
| 696 | disable_irq(hwif->irq); | 696 | disable_irq(hwif->irq); |
| 697 | 697 | ||
| 698 | rc = ide_port_wait_ready(hwif); | 698 | if (ide_port_wait_ready(hwif) == -EBUSY) |
| 699 | if (rc == -ENODEV) { | 699 | printk(KERN_DEBUG "%s: Wait for ready failed before probe !\n", hwif->name); |
| 700 | printk(KERN_INFO "%s: no devices on the port\n", hwif->name); | ||
| 701 | goto out; | ||
| 702 | } else if (rc == -EBUSY) | ||
| 703 | printk(KERN_ERR "%s: not ready before the probe\n", hwif->name); | ||
| 704 | else | ||
| 705 | rc = -ENODEV; | ||
| 706 | 700 | ||
| 707 | /* | 701 | /* |
| 708 | * Second drive should only exist if first drive was found, | 702 | * Second drive should only exist if first drive was found, |
| @@ -713,7 +707,7 @@ static int ide_probe_port(ide_hwif_t *hwif) | |||
| 713 | if (drive->dev_flags & IDE_DFLAG_PRESENT) | 707 | if (drive->dev_flags & IDE_DFLAG_PRESENT) |
| 714 | rc = 0; | 708 | rc = 0; |
| 715 | } | 709 | } |
| 716 | out: | 710 | |
| 717 | /* | 711 | /* |
| 718 | * Use cached IRQ number. It might be (and is...) changed by probe | 712 | * Use cached IRQ number. It might be (and is...) changed by probe |
| 719 | * code above | 713 | * code above |
