diff options
| author | Andy Whitcroft <apw@canonical.com> | 2010-10-26 17:23:14 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-10-26 19:52:20 -0400 |
| commit | 8cf6de7145943caa38c56c61cd83b17687afd900 (patch) | |
| tree | f32e86109cce060816afdcbd9e55cd7c991a495b | |
| parent | 53a3c4487a05b8f26ef72fe434a750a3402c998f (diff) | |
checkpatch: add check for space after struct, union, and enum
Add spacing checks for struct, union, and enum definitions. Check the
spacing after type and before the equals (=) and open brace ({).
Based on a patch by Joe Perches.
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index bcdb54bd61a0..983ac1816da0 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -1905,6 +1905,16 @@ sub process { | |||
| 1905 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); | 1905 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); |
| 1906 | } | 1906 | } |
| 1907 | 1907 | ||
| 1908 | # missing space after union or struct definition | ||
| 1909 | if ($rawline =~ /^\+\s*(union|struct)\s+$Ident[=\{]/) { | ||
| 1910 | WARN("Missing space after struct or union definition\n" . $herecurr); | ||
| 1911 | } | ||
| 1912 | |||
| 1913 | # missing space after enum definition | ||
| 1914 | if ($rawline =~ /^\+\s*enum\{/) { | ||
| 1915 | WARN("Missing space after enum definition\n" . $herecurr); | ||
| 1916 | } | ||
| 1917 | |||
| 1908 | # open braces for enum, union and struct go on the same line. | 1918 | # open braces for enum, union and struct go on the same line. |
| 1909 | if ($line =~ /^.\s*{/ && | 1919 | if ($line =~ /^.\s*{/ && |
| 1910 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { | 1920 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { |
