diff options
| author | David S. Miller <davem@davemloft.net> | 2008-04-24 06:28:52 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-04-24 06:28:52 -0400 |
| commit | 77c664fa58624079f7a0fc29b46e8a32883633a5 (patch) | |
| tree | 8a672a6af5d461e1f95d1a41f52dac3d95edb6ae | |
| parent | 7697daaa894ca2bc5cd652269c316bcdc3ec441b (diff) | |
[SPARC64]: Detect trap frames in stack backtraces.
Now that we have a magic cookie in the pt_regs, we can
properly detect trap frames in stack bactraces.
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | arch/sparc64/kernel/stacktrace.c | 16 | ||||
| -rw-r--r-- | arch/sparc64/kernel/traps.c | 19 |
2 files changed, 28 insertions, 7 deletions
diff --git a/arch/sparc64/kernel/stacktrace.c b/arch/sparc64/kernel/stacktrace.c index 84d39e873e88..01b52f561af4 100644 --- a/arch/sparc64/kernel/stacktrace.c +++ b/arch/sparc64/kernel/stacktrace.c | |||
| @@ -20,6 +20,8 @@ void save_stack_trace(struct stack_trace *trace) | |||
| 20 | thread_base = (unsigned long) tp; | 20 | thread_base = (unsigned long) tp; |
| 21 | do { | 21 | do { |
| 22 | struct reg_window *rw; | 22 | struct reg_window *rw; |
| 23 | struct pt_regs *regs; | ||
| 24 | unsigned long pc; | ||
| 23 | 25 | ||
| 24 | /* Bogus frame pointer? */ | 26 | /* Bogus frame pointer? */ |
| 25 | if (fp < (thread_base + sizeof(struct thread_info)) || | 27 | if (fp < (thread_base + sizeof(struct thread_info)) || |
| @@ -27,11 +29,19 @@ void save_stack_trace(struct stack_trace *trace) | |||
| 27 | break; | 29 | break; |
| 28 | 30 | ||
| 29 | rw = (struct reg_window *) fp; | 31 | rw = (struct reg_window *) fp; |
| 32 | regs = (struct pt_regs *) (rw + 1); | ||
| 33 | |||
| 34 | if ((regs->magic & ~0x1ff) == PT_REGS_MAGIC) { | ||
| 35 | pc = regs->tpc; | ||
| 36 | fp = regs->u_regs[UREG_I6] + STACK_BIAS; | ||
| 37 | } else { | ||
| 38 | pc = rw->ins[7]; | ||
| 39 | fp = rw->ins[6] + STACK_BIAS; | ||
| 40 | } | ||
| 41 | |||
| 30 | if (trace->skip > 0) | 42 | if (trace->skip > 0) |
| 31 | trace->skip--; | 43 | trace->skip--; |
| 32 | else | 44 | else |
| 33 | trace->entries[trace->nr_entries++] = rw->ins[7]; | 45 | trace->entries[trace->nr_entries++] = pc; |
| 34 | |||
| 35 | fp = rw->ins[6] + STACK_BIAS; | ||
| 36 | } while (trace->nr_entries < trace->max_entries); | 46 | } while (trace->nr_entries < trace->max_entries); |
| 37 | } | 47 | } |
diff --git a/arch/sparc64/kernel/traps.c b/arch/sparc64/kernel/traps.c index 96da847023f3..d9b8d46707d1 100644 --- a/arch/sparc64/kernel/traps.c +++ b/arch/sparc64/kernel/traps.c | |||
| @@ -2091,9 +2091,8 @@ static void user_instruction_dump(unsigned int __user *pc) | |||
| 2091 | 2091 | ||
| 2092 | void show_stack(struct task_struct *tsk, unsigned long *_ksp) | 2092 | void show_stack(struct task_struct *tsk, unsigned long *_ksp) |
| 2093 | { | 2093 | { |
| 2094 | unsigned long pc, fp, thread_base, ksp; | 2094 | unsigned long fp, thread_base, ksp; |
| 2095 | struct thread_info *tp; | 2095 | struct thread_info *tp; |
| 2096 | struct reg_window *rw; | ||
| 2097 | int count = 0; | 2096 | int count = 0; |
| 2098 | 2097 | ||
| 2099 | ksp = (unsigned long) _ksp; | 2098 | ksp = (unsigned long) _ksp; |
| @@ -2117,15 +2116,27 @@ void show_stack(struct task_struct *tsk, unsigned long *_ksp) | |||
| 2117 | printk("\n"); | 2116 | printk("\n"); |
| 2118 | #endif | 2117 | #endif |
| 2119 | do { | 2118 | do { |
| 2119 | struct reg_window *rw; | ||
| 2120 | struct pt_regs *regs; | ||
| 2121 | unsigned long pc; | ||
| 2122 | |||
| 2120 | /* Bogus frame pointer? */ | 2123 | /* Bogus frame pointer? */ |
| 2121 | if (fp < (thread_base + sizeof(struct thread_info)) || | 2124 | if (fp < (thread_base + sizeof(struct thread_info)) || |
| 2122 | fp >= (thread_base + THREAD_SIZE)) | 2125 | fp >= (thread_base + THREAD_SIZE)) |
| 2123 | break; | 2126 | break; |
| 2124 | rw = (struct reg_window *)fp; | 2127 | rw = (struct reg_window *)fp; |
| 2125 | pc = rw->ins[7]; | 2128 | regs = (struct pt_regs *) (rw + 1); |
| 2129 | |||
| 2130 | if ((regs->magic & ~0x1ff) == PT_REGS_MAGIC) { | ||
| 2131 | pc = regs->tpc; | ||
| 2132 | fp = regs->u_regs[UREG_I6] + STACK_BIAS; | ||
| 2133 | } else { | ||
| 2134 | pc = rw->ins[7]; | ||
| 2135 | fp = rw->ins[6] + STACK_BIAS; | ||
| 2136 | } | ||
| 2137 | |||
| 2126 | printk(" [%016lx] ", pc); | 2138 | printk(" [%016lx] ", pc); |
| 2127 | print_symbol("%s\n", pc); | 2139 | print_symbol("%s\n", pc); |
| 2128 | fp = rw->ins[6] + STACK_BIAS; | ||
| 2129 | } while (++count < 16); | 2140 | } while (++count < 16); |
| 2130 | #ifndef CONFIG_KALLSYMS | 2141 | #ifndef CONFIG_KALLSYMS |
| 2131 | printk("\n"); | 2142 | printk("\n"); |
