diff options
| author | Andres Salomon <dilinger@queued.net> | 2010-06-28 22:00:29 -0400 |
|---|---|---|
| committer | H. Peter Anvin <hpa@linux.intel.com> | 2010-07-30 21:02:21 -0400 |
| commit | 54e5bc020ce1c959eaa7be18cedb734b6b13745e (patch) | |
| tree | 795e2f33eba14db1ed4f72de97d97695b30f1071 | |
| parent | 25971865d48a8d0ece5307a59dbd3f06d05a7567 (diff) | |
x86, olpc: Constify an olpc_ofw() arg
The arguments passed to OFW shouldn't be modified; update the 'args'
argument of olpc_ofw to reflect this. This saves us some later
casting away of consts.
Signed-off-by: Andres Salomon <dilinger@queued.net>
LKML-Reference: <20100628220029.1555ac24@debian>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
| -rw-r--r-- | arch/x86/include/asm/olpc_ofw.h | 2 | ||||
| -rw-r--r-- | arch/x86/kernel/olpc.c | 2 | ||||
| -rw-r--r-- | arch/x86/kernel/olpc_ofw.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/include/asm/olpc_ofw.h b/arch/x86/include/asm/olpc_ofw.h index 3e63d857c48f..08fde475cb3b 100644 --- a/arch/x86/include/asm/olpc_ofw.h +++ b/arch/x86/include/asm/olpc_ofw.h | |||
| @@ -12,7 +12,7 @@ | |||
| 12 | #define olpc_ofw(name, args, res) \ | 12 | #define olpc_ofw(name, args, res) \ |
| 13 | __olpc_ofw((name), ARRAY_SIZE(args), args, ARRAY_SIZE(res), res) | 13 | __olpc_ofw((name), ARRAY_SIZE(args), args, ARRAY_SIZE(res), res) |
| 14 | 14 | ||
| 15 | extern int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res, | 15 | extern int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res, |
| 16 | void **res); | 16 | void **res); |
| 17 | 17 | ||
| 18 | /* determine whether OFW is available and lives in the proper memory */ | 18 | /* determine whether OFW is available and lives in the proper memory */ |
diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c index f5ff3903b38b..0e0cdde519be 100644 --- a/arch/x86/kernel/olpc.c +++ b/arch/x86/kernel/olpc.c | |||
| @@ -188,7 +188,7 @@ static void __init platform_detect(void) | |||
| 188 | { | 188 | { |
| 189 | size_t propsize; | 189 | size_t propsize; |
| 190 | __be32 rev; | 190 | __be32 rev; |
| 191 | void *args[] = { NULL, "board-revision-int", &rev, (void *)4 }; | 191 | const void *args[] = { NULL, "board-revision-int", &rev, (void *)4 }; |
| 192 | void *res[] = { &propsize }; | 192 | void *res[] = { &propsize }; |
| 193 | 193 | ||
| 194 | if (olpc_ofw("getprop", args, res) || propsize != 4) { | 194 | if (olpc_ofw("getprop", args, res) || propsize != 4) { |
diff --git a/arch/x86/kernel/olpc_ofw.c b/arch/x86/kernel/olpc_ofw.c index f5d499fbe74f..3218aa71ab5e 100644 --- a/arch/x86/kernel/olpc_ofw.c +++ b/arch/x86/kernel/olpc_ofw.c | |||
| @@ -40,7 +40,7 @@ void __init setup_olpc_ofw_pgd(void) | |||
| 40 | early_iounmap(base, sizeof(olpc_ofw_pgd) * PTRS_PER_PGD); | 40 | early_iounmap(base, sizeof(olpc_ofw_pgd) * PTRS_PER_PGD); |
| 41 | } | 41 | } |
| 42 | 42 | ||
| 43 | int __olpc_ofw(const char *name, int nr_args, void **args, int nr_res, | 43 | int __olpc_ofw(const char *name, int nr_args, const void **args, int nr_res, |
| 44 | void **res) | 44 | void **res) |
| 45 | { | 45 | { |
| 46 | int ofw_args[MAXARGS + 3]; | 46 | int ofw_args[MAXARGS + 3]; |
