diff options
| author | Robert Richter <robert.richter@amd.com> | 2010-09-30 12:55:47 -0400 |
|---|---|---|
| committer | Robert Richter <robert.richter@amd.com> | 2010-10-01 11:05:47 -0400 |
| commit | 5140434d5f82f2e2119926272ada2e9731ec04f1 (patch) | |
| tree | abb2938ef04b4b2844a6960b4635f84a71ccb83c | |
| parent | f6dedecc37164a58bb80ae2ed9d204669ffc4850 (diff) | |
oprofile, x86: Simplify init/exit functions
Now, that we only call the exit function if init succeeds with commit:
979048e oprofile: don't call arch exit code from init code on failure
we can simplify the x86 init/exit functions too. Variable using_nmi
becomes obsolete.
Signed-off-by: Robert Richter <robert.richter@amd.com>
| -rw-r--r-- | arch/x86/oprofile/nmi_int.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c index f1575c9a2572..bd1489c3ce09 100644 --- a/arch/x86/oprofile/nmi_int.c +++ b/arch/x86/oprofile/nmi_int.c | |||
| @@ -695,9 +695,6 @@ static int __init ppro_init(char **cpu_type) | |||
| 695 | return 1; | 695 | return 1; |
| 696 | } | 696 | } |
| 697 | 697 | ||
| 698 | /* in order to get sysfs right */ | ||
| 699 | static int using_nmi; | ||
| 700 | |||
| 701 | int __init op_nmi_init(struct oprofile_operations *ops) | 698 | int __init op_nmi_init(struct oprofile_operations *ops) |
| 702 | { | 699 | { |
| 703 | __u8 vendor = boot_cpu_data.x86_vendor; | 700 | __u8 vendor = boot_cpu_data.x86_vendor; |
| @@ -705,8 +702,6 @@ int __init op_nmi_init(struct oprofile_operations *ops) | |||
| 705 | char *cpu_type = NULL; | 702 | char *cpu_type = NULL; |
| 706 | int ret = 0; | 703 | int ret = 0; |
| 707 | 704 | ||
| 708 | using_nmi = 0; | ||
| 709 | |||
| 710 | if (!cpu_has_apic) | 705 | if (!cpu_has_apic) |
| 711 | return -ENODEV; | 706 | return -ENODEV; |
| 712 | 707 | ||
| @@ -790,13 +785,11 @@ int __init op_nmi_init(struct oprofile_operations *ops) | |||
| 790 | if (ret) | 785 | if (ret) |
| 791 | return ret; | 786 | return ret; |
| 792 | 787 | ||
| 793 | using_nmi = 1; | ||
| 794 | printk(KERN_INFO "oprofile: using NMI interrupt.\n"); | 788 | printk(KERN_INFO "oprofile: using NMI interrupt.\n"); |
| 795 | return 0; | 789 | return 0; |
| 796 | } | 790 | } |
| 797 | 791 | ||
| 798 | void op_nmi_exit(void) | 792 | void op_nmi_exit(void) |
| 799 | { | 793 | { |
| 800 | if (using_nmi) | 794 | exit_sysfs(); |
| 801 | exit_sysfs(); | ||
| 802 | } | 795 | } |
