diff options
| author | HighPoint Linux Team <linux@highpoint-tech.com> | 2006-06-14 04:50:57 -0400 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-06-19 20:30:15 -0400 |
| commit | 4f2ddba39a550eba9233d9f0e8309092da0ba293 (patch) | |
| tree | 8fdfacf8a5b7ffcb58a093c5887ff1c9753e8d2e | |
| parent | a623e14dafe72329dd1defe36ee2cd4ff4b2e6f1 (diff) | |
[SCSI] hptiop: HighPoint RocketRAID 3xxx controller driver
Updates:
- don't bypass SYNCHRONIZE_CACHE command
- return SCSI_MLQUEUE_HOST_BUSY when no free request slots
- move scsi_remove_host() to the begin of hpt_remove(), or it will
not work after resources being released.
Signed-off-by: HighPoint Linux Team <linux@highpoint-tech.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
| -rw-r--r-- | drivers/scsi/hptiop.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c index 8302f3ba31ce..a96751cad8cf 100644 --- a/drivers/scsi/hptiop.c +++ b/drivers/scsi/hptiop.c | |||
| @@ -504,19 +504,10 @@ static int hptiop_queuecommand(struct scsi_cmnd *scp, | |||
| 504 | BUG_ON(!done); | 504 | BUG_ON(!done); |
| 505 | scp->scsi_done = done; | 505 | scp->scsi_done = done; |
| 506 | 506 | ||
| 507 | /* | ||
| 508 | * hptiop_shutdown will flash controller cache. | ||
| 509 | */ | ||
| 510 | if (scp->cmnd[0] == SYNCHRONIZE_CACHE) { | ||
| 511 | scp->result = DID_OK<<16; | ||
| 512 | goto cmd_done; | ||
| 513 | } | ||
| 514 | |||
| 515 | _req = get_req(hba); | 507 | _req = get_req(hba); |
| 516 | if (_req == NULL) { | 508 | if (_req == NULL) { |
| 517 | dprintk("hptiop_queuecmd : no free req\n"); | 509 | dprintk("hptiop_queuecmd : no free req\n"); |
| 518 | scp->result = DID_BUS_BUSY << 16; | 510 | return SCSI_MLQUEUE_HOST_BUSY; |
| 519 | goto cmd_done; | ||
| 520 | } | 511 | } |
| 521 | 512 | ||
| 522 | _req->scp = scp; | 513 | _req->scp = scp; |
| @@ -1429,6 +1420,8 @@ static void hptiop_remove(struct pci_dev *pcidev) | |||
| 1429 | 1420 | ||
| 1430 | dprintk("scsi%d: hptiop_remove\n", hba->host->host_no); | 1421 | dprintk("scsi%d: hptiop_remove\n", hba->host->host_no); |
| 1431 | 1422 | ||
| 1423 | scsi_remove_host(host); | ||
| 1424 | |||
| 1432 | spin_lock(&hptiop_hba_list_lock); | 1425 | spin_lock(&hptiop_hba_list_lock); |
| 1433 | list_del_init(&hba->link); | 1426 | list_del_init(&hba->link); |
| 1434 | spin_unlock(&hptiop_hba_list_lock); | 1427 | spin_unlock(&hptiop_hba_list_lock); |
| @@ -1448,7 +1441,6 @@ static void hptiop_remove(struct pci_dev *pcidev) | |||
| 1448 | pci_set_drvdata(hba->pcidev, NULL); | 1441 | pci_set_drvdata(hba->pcidev, NULL); |
| 1449 | pci_disable_device(hba->pcidev); | 1442 | pci_disable_device(hba->pcidev); |
| 1450 | 1443 | ||
| 1451 | scsi_remove_host(host); | ||
| 1452 | scsi_host_put(host); | 1444 | scsi_host_put(host); |
| 1453 | } | 1445 | } |
| 1454 | 1446 | ||
