diff options
| author | David Daney <ddaney@caviumnetworks.com> | 2010-10-19 18:50:31 -0400 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2010-10-21 13:10:11 -0400 |
| commit | 4c60071c1ea3e204b9dc25c7519f7beef355d47f (patch) | |
| tree | 4c9cb9f3b215182d5adba68b8a3c26fd47d47dd6 | |
| parent | f2ffa5ab74f4dfd598860f96ca37a71c4d0a28a8 (diff) | |
of/mips: Cleanup some include directives/files.
The __init directives should go on the definitions of things, not the
declaration, also __init is meaningless for inline functions, so
remove it from prom.h. This allows us to get rid of a useless
#include, but most of the rest of them are useless too, so kill them
as well.
If of_i2c.c needs irq definitions, it should include linux/irq.h
directly, not assume indirect inclusion via asm/prom.h.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | arch/mips/include/asm/prom.h | 8 | ||||
| -rw-r--r-- | drivers/of/of_i2c.c | 1 |
2 files changed, 3 insertions, 6 deletions
diff --git a/arch/mips/include/asm/prom.h b/arch/mips/include/asm/prom.h index 23f8237e18bb..f29b862d9db3 100644 --- a/arch/mips/include/asm/prom.h +++ b/arch/mips/include/asm/prom.h | |||
| @@ -12,10 +12,6 @@ | |||
| 12 | #define __ASM_MIPS_PROM_H | 12 | #define __ASM_MIPS_PROM_H |
| 13 | 13 | ||
| 14 | #ifdef CONFIG_OF | 14 | #ifdef CONFIG_OF |
| 15 | #include <linux/init.h> | ||
| 16 | |||
| 17 | #include <asm/setup.h> | ||
| 18 | #include <asm/irq.h> | ||
| 19 | #include <asm/bootinfo.h> | 15 | #include <asm/bootinfo.h> |
| 20 | 16 | ||
| 21 | /* which is compatible with the flattened device tree (FDT) */ | 17 | /* which is compatible with the flattened device tree (FDT) */ |
| @@ -27,9 +23,9 @@ extern int early_init_dt_scan_memory_arch(unsigned long node, | |||
| 27 | extern int reserve_mem_mach(unsigned long addr, unsigned long size); | 23 | extern int reserve_mem_mach(unsigned long addr, unsigned long size); |
| 28 | extern void free_mem_mach(unsigned long addr, unsigned long size); | 24 | extern void free_mem_mach(unsigned long addr, unsigned long size); |
| 29 | 25 | ||
| 30 | extern void __init device_tree_init(void); | 26 | extern void device_tree_init(void); |
| 31 | #else /* CONFIG_OF */ | 27 | #else /* CONFIG_OF */ |
| 32 | static inline void __init device_tree_init(void) { } | 28 | static inline void device_tree_init(void) { } |
| 33 | #endif /* CONFIG_OF */ | 29 | #endif /* CONFIG_OF */ |
| 34 | 30 | ||
| 35 | #endif /* _ASM_MIPS_PROM_H */ | 31 | #endif /* _ASM_MIPS_PROM_H */ |
diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c index 0a694debd226..c85d3c7421fc 100644 --- a/drivers/of/of_i2c.c +++ b/drivers/of/of_i2c.c | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | */ | 12 | */ |
| 13 | 13 | ||
| 14 | #include <linux/i2c.h> | 14 | #include <linux/i2c.h> |
| 15 | #include <linux/irq.h> | ||
| 15 | #include <linux/of.h> | 16 | #include <linux/of.h> |
| 16 | #include <linux/of_i2c.h> | 17 | #include <linux/of_i2c.h> |
| 17 | #include <linux/of_irq.h> | 18 | #include <linux/of_irq.h> |
