diff options
| author | Lubomir Rintel <lkundrak@v3.sk> | 2010-06-29 18:05:38 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-06-29 18:29:32 -0400 |
| commit | 46c23d7f520e315dde86881b38ba92ebdf34ced5 (patch) | |
| tree | 30a14e15710e9fe9ba38ac667ce7ed5734db3342 | |
| parent | 926b1e2ca35ccb3cbe0ea9b322c5330869b95046 (diff) | |
sysvfs: fix NULL deref. when allocating new inode
A call to sysv_write_inode() in sysv_new_inode() to its new interface that
replaced wait flag with writeback structure. This was broken by
a9185b41a4f84971b930c519f0c63bd450c4810d ("pass writeback_control to
->write_inode").
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@kernel.org> [2.6.34.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/sysv/ialloc.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/fs/sysv/ialloc.c b/fs/sysv/ialloc.c index bbd69bdb0fa8..fcc498ec9b33 100644 --- a/fs/sysv/ialloc.c +++ b/fs/sysv/ialloc.c | |||
| @@ -25,6 +25,7 @@ | |||
| 25 | #include <linux/stat.h> | 25 | #include <linux/stat.h> |
| 26 | #include <linux/string.h> | 26 | #include <linux/string.h> |
| 27 | #include <linux/buffer_head.h> | 27 | #include <linux/buffer_head.h> |
| 28 | #include <linux/writeback.h> | ||
| 28 | #include "sysv.h" | 29 | #include "sysv.h" |
| 29 | 30 | ||
| 30 | /* We don't trust the value of | 31 | /* We don't trust the value of |
| @@ -139,6 +140,9 @@ struct inode * sysv_new_inode(const struct inode * dir, mode_t mode) | |||
| 139 | struct inode *inode; | 140 | struct inode *inode; |
| 140 | sysv_ino_t ino; | 141 | sysv_ino_t ino; |
| 141 | unsigned count; | 142 | unsigned count; |
| 143 | struct writeback_control wbc = { | ||
| 144 | .sync_mode = WB_SYNC_NONE | ||
| 145 | }; | ||
| 142 | 146 | ||
| 143 | inode = new_inode(sb); | 147 | inode = new_inode(sb); |
| 144 | if (!inode) | 148 | if (!inode) |
| @@ -168,7 +172,7 @@ struct inode * sysv_new_inode(const struct inode * dir, mode_t mode) | |||
| 168 | insert_inode_hash(inode); | 172 | insert_inode_hash(inode); |
| 169 | mark_inode_dirty(inode); | 173 | mark_inode_dirty(inode); |
| 170 | 174 | ||
| 171 | sysv_write_inode(inode, 0); /* ensure inode not allocated again */ | 175 | sysv_write_inode(inode, &wbc); /* ensure inode not allocated again */ |
| 172 | mark_inode_dirty(inode); /* cleared by sysv_write_inode() */ | 176 | mark_inode_dirty(inode); /* cleared by sysv_write_inode() */ |
| 173 | /* That's it. */ | 177 | /* That's it. */ |
| 174 | unlock_super(sb); | 178 | unlock_super(sb); |
