diff options
| author | H. Peter Anvin <hpa@zytor.com> | 2006-06-19 10:35:36 -0400 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2006-06-19 10:35:36 -0400 |
| commit | 441ff855f3edf5d355bea30f557bbed6bcd42c6c (patch) | |
| tree | 6327490a1106630deb7fc20255c61072c85a943f | |
| parent | 5e6423871772b89120c9fb356d2eabb67fea60bd (diff) | |
[ARM] Fix byte order macros for Thumb
The byte order functions are visible to userspace. Unfortunately,
__arch_swab32() contains an assembly instruction which is invalid when
compiling for Thumb. This reverts to the C version when compiling for
Thumb.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
| -rw-r--r-- | include/asm-arm/byteorder.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/include/asm-arm/byteorder.h b/include/asm-arm/byteorder.h index 17eaf8bdf092..e6f7fcdc73b0 100644 --- a/include/asm-arm/byteorder.h +++ b/include/asm-arm/byteorder.h | |||
| @@ -22,16 +22,18 @@ static inline __attribute_const__ __u32 ___arch__swab32(__u32 x) | |||
| 22 | { | 22 | { |
| 23 | __u32 t; | 23 | __u32 t; |
| 24 | 24 | ||
| 25 | if (__builtin_constant_p(x)) { | 25 | #ifndef __thumb__ |
| 26 | t = x ^ ((x << 16) | (x >> 16)); /* eor r1,r0,r0,ror #16 */ | 26 | if (!__builtin_constant_p(x)) { |
| 27 | } else { | ||
| 28 | /* | 27 | /* |
| 29 | * The compiler needs a bit of a hint here to always do the | 28 | * The compiler needs a bit of a hint here to always do the |
| 30 | * right thing and not screw it up to different degrees | 29 | * right thing and not screw it up to different degrees |
| 31 | * depending on the gcc version. | 30 | * depending on the gcc version. |
| 32 | */ | 31 | */ |
| 33 | asm ("eor\t%0, %1, %1, ror #16" : "=r" (t) : "r" (x)); | 32 | asm ("eor\t%0, %1, %1, ror #16" : "=r" (t) : "r" (x)); |
| 34 | } | 33 | } else |
| 34 | #endif | ||
| 35 | t = x ^ ((x << 16) | (x >> 16)); /* eor r1,r0,r0,ror #16 */ | ||
| 36 | |||
| 35 | x = (x << 24) | (x >> 8); /* mov r0,r0,ror #8 */ | 37 | x = (x << 24) | (x >> 8); /* mov r0,r0,ror #8 */ |
| 36 | t &= ~0x00FF0000; /* bic r1,r1,#0x00FF0000 */ | 38 | t &= ~0x00FF0000; /* bic r1,r1,#0x00FF0000 */ |
| 37 | x ^= (t >> 8); /* eor r0,r0,r1,lsr #8 */ | 39 | x ^= (t >> 8); /* eor r0,r0,r1,lsr #8 */ |
