diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-07-16 15:05:41 -0400 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-07-18 17:53:28 -0400 |
| commit | 412edf654a04138805fcda2b46a842f681023eeb (patch) | |
| tree | 4f920eea62646900f3c6606c15cbea75ebaf9e14 | |
| parent | 9c9bdf4d50730fd04b06077e22d7a83b585f26b5 (diff) | |
firewire: fw-sbp2: convert to new SCSI data buffer accessors
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| -rw-r--r-- | drivers/firewire/fw-sbp2.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/drivers/firewire/fw-sbp2.c b/drivers/firewire/fw-sbp2.c index 7c53be0387fb..fc984474162c 100644 --- a/drivers/firewire/fw-sbp2.c +++ b/drivers/firewire/fw-sbp2.c | |||
| @@ -840,7 +840,6 @@ complete_command_orb(struct sbp2_orb *base_orb, struct sbp2_status *status) | |||
| 840 | container_of(base_orb, struct sbp2_command_orb, base); | 840 | container_of(base_orb, struct sbp2_command_orb, base); |
| 841 | struct fw_unit *unit = orb->unit; | 841 | struct fw_unit *unit = orb->unit; |
| 842 | struct fw_device *device = fw_device(unit->device.parent); | 842 | struct fw_device *device = fw_device(unit->device.parent); |
| 843 | struct scatterlist *sg; | ||
| 844 | int result; | 843 | int result; |
| 845 | 844 | ||
| 846 | if (status != NULL) { | 845 | if (status != NULL) { |
| @@ -876,11 +875,10 @@ complete_command_orb(struct sbp2_orb *base_orb, struct sbp2_status *status) | |||
| 876 | dma_unmap_single(device->card->device, orb->base.request_bus, | 875 | dma_unmap_single(device->card->device, orb->base.request_bus, |
| 877 | sizeof(orb->request), DMA_TO_DEVICE); | 876 | sizeof(orb->request), DMA_TO_DEVICE); |
| 878 | 877 | ||
| 879 | if (orb->cmd->use_sg > 0) { | 878 | if (scsi_sg_count(orb->cmd) > 0) |
| 880 | sg = (struct scatterlist *)orb->cmd->request_buffer; | 879 | dma_unmap_sg(device->card->device, scsi_sglist(orb->cmd), |
| 881 | dma_unmap_sg(device->card->device, sg, orb->cmd->use_sg, | 880 | scsi_sg_count(orb->cmd), |
| 882 | orb->cmd->sc_data_direction); | 881 | orb->cmd->sc_data_direction); |
| 883 | } | ||
| 884 | 882 | ||
| 885 | if (orb->page_table_bus != 0) | 883 | if (orb->page_table_bus != 0) |
| 886 | dma_unmap_single(device->card->device, orb->page_table_bus, | 884 | dma_unmap_single(device->card->device, orb->page_table_bus, |
| @@ -901,8 +899,8 @@ static int sbp2_command_orb_map_scatterlist(struct sbp2_command_orb *orb) | |||
| 901 | int sg_len, l, i, j, count; | 899 | int sg_len, l, i, j, count; |
| 902 | dma_addr_t sg_addr; | 900 | dma_addr_t sg_addr; |
| 903 | 901 | ||
| 904 | sg = (struct scatterlist *)orb->cmd->request_buffer; | 902 | sg = scsi_sglist(orb->cmd); |
| 905 | count = dma_map_sg(device->card->device, sg, orb->cmd->use_sg, | 903 | count = dma_map_sg(device->card->device, sg, scsi_sg_count(orb->cmd), |
| 906 | orb->cmd->sc_data_direction); | 904 | orb->cmd->sc_data_direction); |
| 907 | if (count == 0) | 905 | if (count == 0) |
| 908 | goto fail; | 906 | goto fail; |
| @@ -971,7 +969,7 @@ static int sbp2_command_orb_map_scatterlist(struct sbp2_command_orb *orb) | |||
| 971 | return 0; | 969 | return 0; |
| 972 | 970 | ||
| 973 | fail_page_table: | 971 | fail_page_table: |
| 974 | dma_unmap_sg(device->card->device, sg, orb->cmd->use_sg, | 972 | dma_unmap_sg(device->card->device, sg, scsi_sg_count(orb->cmd), |
| 975 | orb->cmd->sc_data_direction); | 973 | orb->cmd->sc_data_direction); |
| 976 | fail: | 974 | fail: |
| 977 | return -ENOMEM; | 975 | return -ENOMEM; |
| @@ -1031,7 +1029,7 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done) | |||
| 1031 | orb->request.misc |= | 1029 | orb->request.misc |= |
| 1032 | COMMAND_ORB_DIRECTION(SBP2_DIRECTION_TO_MEDIA); | 1030 | COMMAND_ORB_DIRECTION(SBP2_DIRECTION_TO_MEDIA); |
| 1033 | 1031 | ||
| 1034 | if (cmd->use_sg && sbp2_command_orb_map_scatterlist(orb) < 0) | 1032 | if (scsi_sg_count(cmd) && sbp2_command_orb_map_scatterlist(orb) < 0) |
| 1035 | goto fail_mapping; | 1033 | goto fail_mapping; |
| 1036 | 1034 | ||
| 1037 | fw_memcpy_to_be32(&orb->request, &orb->request, sizeof(orb->request)); | 1035 | fw_memcpy_to_be32(&orb->request, &orb->request, sizeof(orb->request)); |
