aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCharles Clément <caratorn@gmail.com>2010-05-18 13:08:14 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-05-18 17:55:05 -0400
commit21ec51f3df9fd3c83ce0a4ac6a18e5083984b8ae (patch)
treea369469e665ee012eb0b6a2842b3695f4307ff6b
parent7ec52ed25013533248d929d4405225d30c4272b2 (diff)
Staging: vt6656: use ETH_HLEN macro instead of custom one
Replace custom header length definition U_HEADER_LEN by ETH_HLEN from <linux/if_ether.h>. Also remove unused U_TYPE_LEN. Signed-off-by: Charles Clément <caratorn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/vt6656/rxtx.c20
-rw-r--r--drivers/staging/vt6656/tether.h6
2 files changed, 12 insertions, 14 deletions
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index 6a4b87f09545..c41105526a82 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -1483,7 +1483,7 @@ s_bPacketToWirelessUsb(
1483 cb802_1_H_len = 0; 1483 cb802_1_H_len = 0;
1484 } 1484 }
1485 1485
1486 cbFrameBodySize = uSkbPacketLen - U_HEADER_LEN + cb802_1_H_len; 1486 cbFrameBodySize = uSkbPacketLen - ETH_HLEN + cb802_1_H_len;
1487 1487
1488 //Set packet type 1488 //Set packet type
1489 pTxBufHead->wFIFOCtl |= (WORD)(byPktType<<8); 1489 pTxBufHead->wFIFOCtl |= (WORD)(byPktType<<8);
@@ -1729,13 +1729,13 @@ s_bPacketToWirelessUsb(
1729 if (pPacket != NULL) { 1729 if (pPacket != NULL) {
1730 // Copy the Packet into a tx Buffer 1730 // Copy the Packet into a tx Buffer
1731 memcpy((pbyPayloadHead + cb802_1_H_len), 1731 memcpy((pbyPayloadHead + cb802_1_H_len),
1732 (pPacket + U_HEADER_LEN), 1732 (pPacket + ETH_HLEN),
1733 uSkbPacketLen - U_HEADER_LEN 1733 uSkbPacketLen - ETH_HLEN
1734 ); 1734 );
1735 1735
1736 } else { 1736 } else {
1737 // while bRelayPacketSend psEthHeader is point to header+payload 1737 // while bRelayPacketSend psEthHeader is point to header+payload
1738 memcpy((pbyPayloadHead + cb802_1_H_len), ((PBYTE)psEthHeader)+U_HEADER_LEN, uSkbPacketLen - U_HEADER_LEN); 1738 memcpy((pbyPayloadHead + cb802_1_H_len), ((PBYTE)psEthHeader) + ETH_HLEN, uSkbPacketLen - ETH_HLEN);
1739 } 1739 }
1740 1740
1741 ASSERT(uLength == cbNdisBodySize); 1741 ASSERT(uLength == cbNdisBodySize);
@@ -2849,7 +2849,7 @@ nsDMA_tx_packet(
2849 return STATUS_RESOURCES; 2849 return STATUS_RESOURCES;
2850 } 2850 }
2851 2851
2852 memcpy(pDevice->sTxEthHeader.abyDstAddr, (PBYTE)(skb->data), U_HEADER_LEN); 2852 memcpy(pDevice->sTxEthHeader.abyDstAddr, (PBYTE)(skb->data), ETH_HLEN);
2853 2853
2854//mike add:station mode check eapol-key challenge---> 2854//mike add:station mode check eapol-key challenge--->
2855{ 2855{
@@ -2858,10 +2858,10 @@ nsDMA_tx_packet(
2858 BYTE Descriptor_type; 2858 BYTE Descriptor_type;
2859 WORD Key_info; 2859 WORD Key_info;
2860 2860
2861 Protocol_Version = skb->data[U_HEADER_LEN]; 2861 Protocol_Version = skb->data[ETH_HLEN];
2862 Packet_Type = skb->data[U_HEADER_LEN+1]; 2862 Packet_Type = skb->data[ETH_HLEN+1];
2863 Descriptor_type = skb->data[U_HEADER_LEN+1+1+2]; 2863 Descriptor_type = skb->data[ETH_HLEN+1+1+2];
2864 Key_info = (skb->data[U_HEADER_LEN+1+1+2+1] << 8)|(skb->data[U_HEADER_LEN+1+1+2+2]); 2864 Key_info = (skb->data[ETH_HLEN+1+1+2+1] << 8)|(skb->data[ETH_HLEN+1+1+2+2]);
2865 if (pDevice->sTxEthHeader.wType == TYPE_PKT_802_1x) { 2865 if (pDevice->sTxEthHeader.wType == TYPE_PKT_802_1x) {
2866 if(((Protocol_Version==1) ||(Protocol_Version==2)) && 2866 if(((Protocol_Version==1) ||(Protocol_Version==2)) &&
2867 (Packet_Type==3)) { //802.1x OR eapol-key challenge frame transfer 2867 (Packet_Type==3)) { //802.1x OR eapol-key challenge frame transfer
@@ -3195,7 +3195,7 @@ bRelayPacketSend (
3195 return FALSE; 3195 return FALSE;
3196 } 3196 }
3197 3197
3198 memcpy(pDevice->sTxEthHeader.abyDstAddr, (PBYTE)pbySkbData, U_HEADER_LEN); 3198 memcpy(pDevice->sTxEthHeader.abyDstAddr, (PBYTE)pbySkbData, ETH_HLEN);
3199 3199
3200 if (pDevice->bEncryptionEnable == TRUE) { 3200 if (pDevice->bEncryptionEnable == TRUE) {
3201 bNeedEncryption = TRUE; 3201 bNeedEncryption = TRUE;
diff --git a/drivers/staging/vt6656/tether.h b/drivers/staging/vt6656/tether.h
index f5819a7aee27..d63586d5cdb2 100644
--- a/drivers/staging/vt6656/tether.h
+++ b/drivers/staging/vt6656/tether.h
@@ -36,19 +36,17 @@
36// 36//
37// constants 37// constants
38// 38//
39#define U_TYPE_LEN 2 //
40#define U_CRC_LEN 4 // 39#define U_CRC_LEN 4 //
41#define U_HEADER_LEN (ETH_ALEN * 2 + U_TYPE_LEN)
42#define U_ETHER_ADDR_STR_LEN (ETH_ALEN * 2 + 1) 40#define U_ETHER_ADDR_STR_LEN (ETH_ALEN * 2 + 1)
43 // Ethernet address string length 41 // Ethernet address string length
44 42
45#define MIN_DATA_LEN 46 // min data length 43#define MIN_DATA_LEN 46 // min data length
46#define MAX_DATA_LEN 1500 // max data length 44#define MAX_DATA_LEN 1500 // max data length
47 45
48#define MIN_PACKET_LEN (MIN_DATA_LEN + U_HEADER_LEN) 46#define MIN_PACKET_LEN (MIN_DATA_LEN + ETH_HLEN)
49 // 60 47 // 60
50 // min total packet length (tx) 48 // min total packet length (tx)
51#define MAX_PACKET_LEN (MAX_DATA_LEN + U_HEADER_LEN) 49#define MAX_PACKET_LEN (MAX_DATA_LEN + ETH_HLEN)
52 // 1514 50 // 1514
53 // max total packet length (tx) 51 // max total packet length (tx)
54 52