diff options
| author | Ben Dooks <ben-linux@fluff.org> | 2009-01-08 10:42:42 -0500 |
|---|---|---|
| committer | Ben Dooks <ben-linux@fluff.org> | 2009-01-08 10:53:08 -0500 |
| commit | 0dc6c490c0e2b81af32db3851040c109f7b3a54b (patch) | |
| tree | 5bbbcfa401d53fd7e1229e45891f638b67c2faf3 | |
| parent | 39ebfd3f0d58a89f29097f99a1de50c096375ee2 (diff) | |
[ARM] footbridge: dc21285.c warning fixes
The dc21285 requests a number of IRQs that it doesn't really
care whether they get added. Change to use a macro that ensures
that at-least the user gets warned if they fail to add, which
also stops the warnings from __unused_result on request_irq().
dc21285.c:337: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:339: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:341: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:343: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
dc21285.c:345: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
| -rw-r--r-- | arch/arm/mach-footbridge/dc21285.c | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/arch/arm/mach-footbridge/dc21285.c b/arch/arm/mach-footbridge/dc21285.c index 133086019e3e..3ffa54841ec5 100644 --- a/arch/arm/mach-footbridge/dc21285.c +++ b/arch/arm/mach-footbridge/dc21285.c | |||
| @@ -287,6 +287,9 @@ struct pci_bus * __init dc21285_scan_bus(int nr, struct pci_sys_data *sys) | |||
| 287 | return pci_scan_bus(0, &dc21285_ops, sys); | 287 | return pci_scan_bus(0, &dc21285_ops, sys); |
| 288 | } | 288 | } |
| 289 | 289 | ||
| 290 | #define dc21285_request_irq(_a, _b, _c, _d, _e) \ | ||
| 291 | WARN_ON(request_irq(_a, _b, _c, _d, _e) < 0) | ||
| 292 | |||
| 290 | void __init dc21285_preinit(void) | 293 | void __init dc21285_preinit(void) |
| 291 | { | 294 | { |
| 292 | unsigned int mem_size, mem_mask; | 295 | unsigned int mem_size, mem_mask; |
| @@ -335,16 +338,16 @@ void __init dc21285_preinit(void) | |||
| 335 | /* | 338 | /* |
| 336 | * We don't care if these fail. | 339 | * We don't care if these fail. |
| 337 | */ | 340 | */ |
| 338 | request_irq(IRQ_PCI_SERR, dc21285_serr_irq, IRQF_DISABLED, | 341 | dc21285_request_irq(IRQ_PCI_SERR, dc21285_serr_irq, IRQF_DISABLED, |
| 339 | "PCI system error", &serr_timer); | 342 | "PCI system error", &serr_timer); |
| 340 | request_irq(IRQ_PCI_PERR, dc21285_parity_irq, IRQF_DISABLED, | 343 | dc21285_request_irq(IRQ_PCI_PERR, dc21285_parity_irq, IRQF_DISABLED, |
| 341 | "PCI parity error", &perr_timer); | 344 | "PCI parity error", &perr_timer); |
| 342 | request_irq(IRQ_PCI_ABORT, dc21285_abort_irq, IRQF_DISABLED, | 345 | dc21285_request_irq(IRQ_PCI_ABORT, dc21285_abort_irq, IRQF_DISABLED, |
| 343 | "PCI abort", NULL); | 346 | "PCI abort", NULL); |
| 344 | request_irq(IRQ_DISCARD_TIMER, dc21285_discard_irq, IRQF_DISABLED, | 347 | dc21285_request_irq(IRQ_DISCARD_TIMER, dc21285_discard_irq, IRQF_DISABLED, |
| 345 | "Discard timer", NULL); | 348 | "Discard timer", NULL); |
| 346 | request_irq(IRQ_PCI_DPERR, dc21285_dparity_irq, IRQF_DISABLED, | 349 | dc21285_request_irq(IRQ_PCI_DPERR, dc21285_dparity_irq, IRQF_DISABLED, |
| 347 | "PCI data parity", NULL); | 350 | "PCI data parity", NULL); |
| 348 | 351 | ||
| 349 | if (cfn_mode) { | 352 | if (cfn_mode) { |
| 350 | static struct resource csrio; | 353 | static struct resource csrio; |
