diff options
| author | NeilBrown <neilb@suse.de> | 2009-09-23 04:09:45 -0400 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2009-09-23 04:09:45 -0400 |
| commit | 0da3c6194ec2f32617b272df4505a1cf022faea5 (patch) | |
| tree | 5864b61b8fac2e7477668bdb9a493d2a64d0b3dd | |
| parent | ee305acef5c7841dc25cc32e84bb94f744e1e9b9 (diff) | |
md: Improve name of threads created by md_register_thread
The management thread for raid4,5,6 arrays are all called
mdX_raid5, independent of the actual raid level, which is wrong and
can be confusion.
So change md_register_thread to use the name from the personality
unless no alternate name (like 'resync' or 'reshape') is given.
This is simpler and more correct.
Cc: Jinzc <zhenchengjin@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/md.c | 9 | ||||
| -rw-r--r-- | drivers/md/multipath.c | 2 | ||||
| -rw-r--r-- | drivers/md/raid1.c | 2 | ||||
| -rw-r--r-- | drivers/md/raid10.c | 2 | ||||
| -rw-r--r-- | drivers/md/raid5.c | 6 |
5 files changed, 12 insertions, 9 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index f64b33085255..a3dd3c8ea681 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c | |||
| @@ -4218,7 +4218,7 @@ static int do_md_run(mddev_t * mddev) | |||
| 4218 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); | 4218 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); |
| 4219 | mddev->sync_thread = md_register_thread(md_do_sync, | 4219 | mddev->sync_thread = md_register_thread(md_do_sync, |
| 4220 | mddev, | 4220 | mddev, |
| 4221 | "%s_resync"); | 4221 | "resync"); |
| 4222 | if (!mddev->sync_thread) { | 4222 | if (!mddev->sync_thread) { |
| 4223 | printk(KERN_ERR "%s: could not start resync" | 4223 | printk(KERN_ERR "%s: could not start resync" |
| 4224 | " thread...\n", | 4224 | " thread...\n", |
| @@ -5631,7 +5631,10 @@ mdk_thread_t *md_register_thread(void (*run) (mddev_t *), mddev_t *mddev, | |||
| 5631 | thread->run = run; | 5631 | thread->run = run; |
| 5632 | thread->mddev = mddev; | 5632 | thread->mddev = mddev; |
| 5633 | thread->timeout = MAX_SCHEDULE_TIMEOUT; | 5633 | thread->timeout = MAX_SCHEDULE_TIMEOUT; |
| 5634 | thread->tsk = kthread_run(md_thread, thread, name, mdname(thread->mddev)); | 5634 | thread->tsk = kthread_run(md_thread, thread, |
| 5635 | "%s_%s", | ||
| 5636 | mdname(thread->mddev), | ||
| 5637 | name ?: mddev->pers->name); | ||
| 5635 | if (IS_ERR(thread->tsk)) { | 5638 | if (IS_ERR(thread->tsk)) { |
| 5636 | kfree(thread); | 5639 | kfree(thread); |
| 5637 | return NULL; | 5640 | return NULL; |
| @@ -6745,7 +6748,7 @@ void md_check_recovery(mddev_t *mddev) | |||
| 6745 | } | 6748 | } |
| 6746 | mddev->sync_thread = md_register_thread(md_do_sync, | 6749 | mddev->sync_thread = md_register_thread(md_do_sync, |
| 6747 | mddev, | 6750 | mddev, |
| 6748 | "%s_resync"); | 6751 | "resync"); |
| 6749 | if (!mddev->sync_thread) { | 6752 | if (!mddev->sync_thread) { |
| 6750 | printk(KERN_ERR "%s: could not start resync" | 6753 | printk(KERN_ERR "%s: could not start resync" |
| 6751 | " thread...\n", | 6754 | " thread...\n", |
diff --git a/drivers/md/multipath.c b/drivers/md/multipath.c index d2d3fd54cc68..94c21c11b9bc 100644 --- a/drivers/md/multipath.c +++ b/drivers/md/multipath.c | |||
| @@ -504,7 +504,7 @@ static int multipath_run (mddev_t *mddev) | |||
| 504 | } | 504 | } |
| 505 | 505 | ||
| 506 | { | 506 | { |
| 507 | mddev->thread = md_register_thread(multipathd, mddev, "%s_multipath"); | 507 | mddev->thread = md_register_thread(multipathd, mddev, NULL); |
| 508 | if (!mddev->thread) { | 508 | if (!mddev->thread) { |
| 509 | printk(KERN_ERR "multipath: couldn't allocate thread" | 509 | printk(KERN_ERR "multipath: couldn't allocate thread" |
| 510 | " for %s\n", mdname(mddev)); | 510 | " for %s\n", mdname(mddev)); |
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index ff7ed3335995..7efdeb44097f 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c | |||
| @@ -2047,7 +2047,7 @@ static int run(mddev_t *mddev) | |||
| 2047 | conf->last_used = j; | 2047 | conf->last_used = j; |
| 2048 | 2048 | ||
| 2049 | 2049 | ||
| 2050 | mddev->thread = md_register_thread(raid1d, mddev, "%s_raid1"); | 2050 | mddev->thread = md_register_thread(raid1d, mddev, NULL); |
| 2051 | if (!mddev->thread) { | 2051 | if (!mddev->thread) { |
| 2052 | printk(KERN_ERR | 2052 | printk(KERN_ERR |
| 2053 | "raid1: couldn't allocate thread for %s\n", | 2053 | "raid1: couldn't allocate thread for %s\n", |
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 8bca3835c9fd..7872968fdfcc 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c | |||
| @@ -2188,7 +2188,7 @@ static int run(mddev_t *mddev) | |||
| 2188 | } | 2188 | } |
| 2189 | 2189 | ||
| 2190 | 2190 | ||
| 2191 | mddev->thread = md_register_thread(raid10d, mddev, "%s_raid10"); | 2191 | mddev->thread = md_register_thread(raid10d, mddev, NULL); |
| 2192 | if (!mddev->thread) { | 2192 | if (!mddev->thread) { |
| 2193 | printk(KERN_ERR | 2193 | printk(KERN_ERR |
| 2194 | "raid10: couldn't allocate thread for %s\n", | 2194 | "raid10: couldn't allocate thread for %s\n", |
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 763dcc40e513..bee3573ed1bd 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
| @@ -4448,7 +4448,7 @@ static raid5_conf_t *setup_conf(mddev_t *mddev) | |||
| 4448 | printk(KERN_INFO "raid5: allocated %dkB for %s\n", | 4448 | printk(KERN_INFO "raid5: allocated %dkB for %s\n", |
| 4449 | memory, mdname(mddev)); | 4449 | memory, mdname(mddev)); |
| 4450 | 4450 | ||
| 4451 | conf->thread = md_register_thread(raid5d, mddev, "%s_raid5"); | 4451 | conf->thread = md_register_thread(raid5d, mddev, NULL); |
| 4452 | if (!conf->thread) { | 4452 | if (!conf->thread) { |
| 4453 | printk(KERN_ERR | 4453 | printk(KERN_ERR |
| 4454 | "raid5: couldn't allocate thread for %s\n", | 4454 | "raid5: couldn't allocate thread for %s\n", |
| @@ -4614,7 +4614,7 @@ static int run(mddev_t *mddev) | |||
| 4614 | set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery); | 4614 | set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery); |
| 4615 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); | 4615 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); |
| 4616 | mddev->sync_thread = md_register_thread(md_do_sync, mddev, | 4616 | mddev->sync_thread = md_register_thread(md_do_sync, mddev, |
| 4617 | "%s_reshape"); | 4617 | "reshape"); |
| 4618 | } | 4618 | } |
| 4619 | 4619 | ||
| 4620 | /* read-ahead size must cover two whole stripes, which is | 4620 | /* read-ahead size must cover two whole stripes, which is |
| @@ -5032,7 +5032,7 @@ static int raid5_start_reshape(mddev_t *mddev) | |||
| 5032 | set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery); | 5032 | set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery); |
| 5033 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); | 5033 | set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); |
| 5034 | mddev->sync_thread = md_register_thread(md_do_sync, mddev, | 5034 | mddev->sync_thread = md_register_thread(md_do_sync, mddev, |
| 5035 | "%s_reshape"); | 5035 | "reshape"); |
| 5036 | if (!mddev->sync_thread) { | 5036 | if (!mddev->sync_thread) { |
| 5037 | mddev->recovery = 0; | 5037 | mddev->recovery = 0; |
| 5038 | spin_lock_irq(&conf->device_lock); | 5038 | spin_lock_irq(&conf->device_lock); |
