diff options
| author | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-06 16:05:50 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-06 16:05:50 -0400 |
| commit | 07bbeaf12310263d808b1958f8413b95f98786ea (patch) | |
| tree | 5a739fb75f8e14b8c5f2274d8f1efa6fed145b34 | |
| parent | 184f6eb8c46afc2a4aa6cb7c51ebc423c36d9c9d (diff) | |
ieee1394: fix broken signed char assumption.
"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char". Which only works if "char" is signed - which it
necessarily isn't.
So make that signedness assumption specific.
| -rw-r--r-- | drivers/ieee1394/ieee1394_core.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ieee1394/ieee1394_core.h b/drivers/ieee1394/ieee1394_core.h index 73bd8efd2b6c..0b31429d0a68 100644 --- a/drivers/ieee1394/ieee1394_core.h +++ b/drivers/ieee1394/ieee1394_core.h | |||
| @@ -38,8 +38,8 @@ struct hpsb_packet { | |||
| 38 | 38 | ||
| 39 | /* These are core internal. */ | 39 | /* These are core internal. */ |
| 40 | signed char tlabel; | 40 | signed char tlabel; |
| 41 | char ack_code; | 41 | signed char ack_code; |
| 42 | char tcode; | 42 | unsigned char tcode; |
| 43 | 43 | ||
| 44 | unsigned expect_response:1; | 44 | unsigned expect_response:1; |
| 45 | unsigned no_waiter:1; | 45 | unsigned no_waiter:1; |