diff options
| author | Andi Kleen <andi@firstfloor.org> | 2010-06-10 07:10:53 -0400 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2010-07-21 10:01:47 -0400 |
| commit | 0411ba7902e09111d6f2041b4697a597d2cf7736 (patch) | |
| tree | 65927286bf15ae9161c3ffd2a0f65bea1e8faa6a | |
| parent | 189eef59e70e3e56edf726864629f310d114eefb (diff) | |
ext3: Fix set but unused variables
[tytso@mit.edu: Fix compilation with CONFIG_JBD_DEBUG enabled]
Acked-by: tytso@mit.edu
cc: linux-ext4@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/ext3/namei.c | 3 | ||||
| -rw-r--r-- | fs/ext3/resize.c | 2 | ||||
| -rw-r--r-- | fs/jbd/journal.c | 7 | ||||
| -rw-r--r-- | fs/jbd/recovery.c | 11 |
4 files changed, 3 insertions, 20 deletions
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index ee184084ca42..2b35ddb70d65 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c | |||
| @@ -1447,7 +1447,6 @@ static int ext3_add_entry (handle_t *handle, struct dentry *dentry, | |||
| 1447 | struct inode *inode) | 1447 | struct inode *inode) |
| 1448 | { | 1448 | { |
| 1449 | struct inode *dir = dentry->d_parent->d_inode; | 1449 | struct inode *dir = dentry->d_parent->d_inode; |
| 1450 | unsigned long offset; | ||
| 1451 | struct buffer_head * bh; | 1450 | struct buffer_head * bh; |
| 1452 | struct ext3_dir_entry_2 *de; | 1451 | struct ext3_dir_entry_2 *de; |
| 1453 | struct super_block * sb; | 1452 | struct super_block * sb; |
| @@ -1469,7 +1468,7 @@ static int ext3_add_entry (handle_t *handle, struct dentry *dentry, | |||
| 1469 | ext3_mark_inode_dirty(handle, dir); | 1468 | ext3_mark_inode_dirty(handle, dir); |
| 1470 | } | 1469 | } |
| 1471 | blocks = dir->i_size >> sb->s_blocksize_bits; | 1470 | blocks = dir->i_size >> sb->s_blocksize_bits; |
| 1472 | for (block = 0, offset = 0; block < blocks; block++) { | 1471 | for (block = 0; block < blocks; block++) { |
| 1473 | bh = ext3_bread(handle, dir, block, 0, &retval); | 1472 | bh = ext3_bread(handle, dir, block, 0, &retval); |
| 1474 | if(!bh) | 1473 | if(!bh) |
| 1475 | return retval; | 1474 | return retval; |
diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c index 54351ac7cef9..0ccd7b12b73c 100644 --- a/fs/ext3/resize.c +++ b/fs/ext3/resize.c | |||
| @@ -964,7 +964,6 @@ int ext3_group_extend(struct super_block *sb, struct ext3_super_block *es, | |||
| 964 | ext3_fsblk_t n_blocks_count) | 964 | ext3_fsblk_t n_blocks_count) |
| 965 | { | 965 | { |
| 966 | ext3_fsblk_t o_blocks_count; | 966 | ext3_fsblk_t o_blocks_count; |
| 967 | unsigned long o_groups_count; | ||
| 968 | ext3_grpblk_t last; | 967 | ext3_grpblk_t last; |
| 969 | ext3_grpblk_t add; | 968 | ext3_grpblk_t add; |
| 970 | struct buffer_head * bh; | 969 | struct buffer_head * bh; |
| @@ -976,7 +975,6 @@ int ext3_group_extend(struct super_block *sb, struct ext3_super_block *es, | |||
| 976 | * yet: we're going to revalidate es->s_blocks_count after | 975 | * yet: we're going to revalidate es->s_blocks_count after |
| 977 | * taking the s_resize_lock below. */ | 976 | * taking the s_resize_lock below. */ |
| 978 | o_blocks_count = le32_to_cpu(es->s_blocks_count); | 977 | o_blocks_count = le32_to_cpu(es->s_blocks_count); |
| 979 | o_groups_count = EXT3_SB(sb)->s_groups_count; | ||
| 980 | 978 | ||
| 981 | if (test_opt(sb, DEBUG)) | 979 | if (test_opt(sb, DEBUG)) |
| 982 | printk(KERN_DEBUG "EXT3-fs: extending last group from "E3FSBLK" uto "E3FSBLK" blocks\n", | 980 | printk(KERN_DEBUG "EXT3-fs: extending last group from "E3FSBLK" uto "E3FSBLK" blocks\n", |
diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 93d1e47647bd..f19ce94693d8 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c | |||
| @@ -1281,13 +1281,9 @@ int journal_check_used_features (journal_t *journal, unsigned long compat, | |||
| 1281 | int journal_check_available_features (journal_t *journal, unsigned long compat, | 1281 | int journal_check_available_features (journal_t *journal, unsigned long compat, |
| 1282 | unsigned long ro, unsigned long incompat) | 1282 | unsigned long ro, unsigned long incompat) |
| 1283 | { | 1283 | { |
| 1284 | journal_superblock_t *sb; | ||
| 1285 | |||
| 1286 | if (!compat && !ro && !incompat) | 1284 | if (!compat && !ro && !incompat) |
| 1287 | return 1; | 1285 | return 1; |
| 1288 | 1286 | ||
| 1289 | sb = journal->j_superblock; | ||
| 1290 | |||
| 1291 | /* We can support any known requested features iff the | 1287 | /* We can support any known requested features iff the |
| 1292 | * superblock is in version 2. Otherwise we fail to support any | 1288 | * superblock is in version 2. Otherwise we fail to support any |
| 1293 | * extended sb features. */ | 1289 | * extended sb features. */ |
| @@ -1481,7 +1477,6 @@ int journal_flush(journal_t *journal) | |||
| 1481 | 1477 | ||
| 1482 | int journal_wipe(journal_t *journal, int write) | 1478 | int journal_wipe(journal_t *journal, int write) |
| 1483 | { | 1479 | { |
| 1484 | journal_superblock_t *sb; | ||
| 1485 | int err = 0; | 1480 | int err = 0; |
| 1486 | 1481 | ||
| 1487 | J_ASSERT (!(journal->j_flags & JFS_LOADED)); | 1482 | J_ASSERT (!(journal->j_flags & JFS_LOADED)); |
| @@ -1490,8 +1485,6 @@ int journal_wipe(journal_t *journal, int write) | |||
| 1490 | if (err) | 1485 | if (err) |
| 1491 | return err; | 1486 | return err; |
| 1492 | 1487 | ||
| 1493 | sb = journal->j_superblock; | ||
| 1494 | |||
| 1495 | if (!journal->j_tail) | 1488 | if (!journal->j_tail) |
| 1496 | goto no_recovery; | 1489 | goto no_recovery; |
| 1497 | 1490 | ||
diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c index 54c9bc9e1b17..81051dafebf5 100644 --- a/fs/jbd/recovery.c +++ b/fs/jbd/recovery.c | |||
| @@ -283,12 +283,9 @@ int journal_recover(journal_t *journal) | |||
| 283 | int journal_skip_recovery(journal_t *journal) | 283 | int journal_skip_recovery(journal_t *journal) |
| 284 | { | 284 | { |
| 285 | int err; | 285 | int err; |
| 286 | journal_superblock_t * sb; | ||
| 287 | |||
| 288 | struct recovery_info info; | 286 | struct recovery_info info; |
| 289 | 287 | ||
| 290 | memset (&info, 0, sizeof(info)); | 288 | memset (&info, 0, sizeof(info)); |
| 291 | sb = journal->j_superblock; | ||
| 292 | 289 | ||
| 293 | err = do_one_pass(journal, &info, PASS_SCAN); | 290 | err = do_one_pass(journal, &info, PASS_SCAN); |
| 294 | 291 | ||
| @@ -297,7 +294,8 @@ int journal_skip_recovery(journal_t *journal) | |||
| 297 | ++journal->j_transaction_sequence; | 294 | ++journal->j_transaction_sequence; |
| 298 | } else { | 295 | } else { |
| 299 | #ifdef CONFIG_JBD_DEBUG | 296 | #ifdef CONFIG_JBD_DEBUG |
| 300 | int dropped = info.end_transaction - be32_to_cpu(sb->s_sequence); | 297 | int dropped = info.end_transaction - |
| 298 | be32_to_cpu(journal->j_superblock->s_sequence); | ||
| 301 | #endif | 299 | #endif |
| 302 | jbd_debug(1, | 300 | jbd_debug(1, |
| 303 | "JBD: ignoring %d transaction%s from the journal.\n", | 301 | "JBD: ignoring %d transaction%s from the journal.\n", |
| @@ -321,11 +319,6 @@ static int do_one_pass(journal_t *journal, | |||
| 321 | unsigned int sequence; | 319 | unsigned int sequence; |
| 322 | int blocktype; | 320 | int blocktype; |
| 323 | 321 | ||
| 324 | /* Precompute the maximum metadata descriptors in a descriptor block */ | ||
| 325 | int MAX_BLOCKS_PER_DESC; | ||
| 326 | MAX_BLOCKS_PER_DESC = ((journal->j_blocksize-sizeof(journal_header_t)) | ||
| 327 | / sizeof(journal_block_tag_t)); | ||
| 328 | |||
| 329 | /* | 322 | /* |
| 330 | * First thing is to establish what we expect to find in the log | 323 | * First thing is to establish what we expect to find in the log |
| 331 | * (in terms of transaction IDs), and where (in terms of log | 324 | * (in terms of transaction IDs), and where (in terms of log |
