aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>2009-01-06 17:41:11 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-06 18:59:14 -0500
commit350eaf791bebccb9ad5999351f3e328319545f03 (patch)
tree7a9b18b1c2ab34cf62ae5862fbf1cc629ed383fa
parent26e5438e4b77f04a51870f9415ffed68004fac1d (diff)
do_coredump(): check return from argv_split()
do_coredump() accesses helper_argv[0] without checking helper_argv != NULL. This can happen if page allocation failed. Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--fs/exec.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/exec.c b/fs/exec.c
index 6ca4e3d22a3d..6b09d6fa4f7e 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1770,6 +1770,11 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs)
1770 1770
1771 if (ispipe) { 1771 if (ispipe) {
1772 helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc); 1772 helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
1773 if (!helper_argv) {
1774 printk(KERN_WARNING "%s failed to allocate memory\n",
1775 __func__);
1776 goto fail_unlock;
1777 }
1773 /* Terminate the string before the first option */ 1778 /* Terminate the string before the first option */
1774 delimit = strchr(corename, ' '); 1779 delimit = strchr(corename, ' ');
1775 if (delimit) 1780 if (delimit)