diff options
author | Michael Krufky <mkrufky@linuxtv.org> | 2006-02-07 03:25:36 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2006-02-07 03:25:36 -0500 |
commit | 99d33d5012c31c6c2b7ad5658654d7c5f0d606d1 (patch) | |
tree | d156a988421c4953b63c9ede689cc517dfe5a560 | |
parent | bd0d0f59ca56c7ef063d714e9b602fcaa5c11072 (diff) |
V4L/DVB (3271): Update tuner comments
Right now, all tuners are using the first tuner_params[]
array element for analog mode. We are now ready to begin merging
similar tuner definitions together, such that each tuner definition
will have a tuner_params struct for each available video standard.
The tuner_params[] array element will be chosen based on the video
standard in use.
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r-- | drivers/media/video/tuner-simple.c | 10 | ||||
-rw-r--r-- | drivers/media/video/tuner-types.c | 15 |
2 files changed, 9 insertions, 16 deletions
diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c index 17e29cc60c90..2e680cf515a2 100644 --- a/drivers/media/video/tuner-simple.c +++ b/drivers/media/video/tuner-simple.c | |||
@@ -79,16 +79,6 @@ MODULE_PARM_DESC(offset,"Allows to specify an offset for tuner"); | |||
79 | #define TUNER_PLL_LOCKED 0x40 | 79 | #define TUNER_PLL_LOCKED 0x40 |
80 | #define TUNER_STEREO_MK3 0x04 | 80 | #define TUNER_STEREO_MK3 0x04 |
81 | 81 | ||
82 | /* FIXME: | ||
83 | * Right now, all tuners are using the first tuner_params[] array element | ||
84 | * for analog mode. In the future, we will be merging similar tuner | ||
85 | * definitions together, such that each tuner definition will have a | ||
86 | * tuner_params struct for each available video standard. At that point, | ||
87 | * the tuner_params[] array element will be chosen based on the video | ||
88 | * standard in use. | ||
89 | * | ||
90 | */ | ||
91 | |||
92 | /* ---------------------------------------------------------------------- */ | 82 | /* ---------------------------------------------------------------------- */ |
93 | 83 | ||
94 | static int tuner_getstatus(struct i2c_client *c) | 84 | static int tuner_getstatus(struct i2c_client *c) |
diff --git a/drivers/media/video/tuner-types.c b/drivers/media/video/tuner-types.c index 27fc4d06b1d2..9786e590624a 100644 --- a/drivers/media/video/tuner-types.c +++ b/drivers/media/video/tuner-types.c | |||
@@ -23,13 +23,16 @@ | |||
23 | * Each tuner_params array may contain one or more elements, one | 23 | * Each tuner_params array may contain one or more elements, one |
24 | * for each video standard. | 24 | * for each video standard. |
25 | * | 25 | * |
26 | * FIXME: Some tuner_range definitions are duplicated, and | 26 | * FIXME: tuner_params struct contains an element, tda988x. We must |
27 | * should be eliminated. | 27 | * set this for all tuners that contain a tda988x chip, and then we |
28 | * can remove this setting from the various card structs. | ||
28 | * | 29 | * |
29 | * FIXME: tunertype struct contains an element, has_tda988x. | 30 | * FIXME: Right now, all tuners are using the first tuner_params[] |
30 | * We must set this for all tunertypes that contain a tda988x | 31 | * array element for analog mode. In the future, we will be merging |
31 | * chip, and then we can remove this setting from the various | 32 | * similar tuner definitions together, such that each tuner definition |
32 | * card structs. | 33 | * will have a tuner_params struct for each available video standard. |
34 | * At that point, the tuner_params[] array element will be chosen | ||
35 | * based on the video standard in use. | ||
33 | */ | 36 | */ |
34 | 37 | ||
35 | /* 0-9 */ | 38 | /* 0-9 */ |