diff options
author | Christoph Lameter <clameter@sgi.com> | 2008-01-14 03:55:14 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-01-14 11:52:22 -0500 |
commit | 96990a4ae979df9e235d01097d6175759331e88c (patch) | |
tree | ba545616c7deb1cca99565655a80564564d39bd4 | |
parent | 8f4c79ce79d1552014af3c115d03e13092443905 (diff) |
quicklists: Only consider memory that can be used with GFP_KERNEL
Quicklists calculates the size of the quicklists based on the number of
free pages. This must be the number of free pages that can be allocated
with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/quicklist.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/mm/quicklist.c b/mm/quicklist.c index ae8189c2799e..3f703f7cb398 100644 --- a/mm/quicklist.c +++ b/mm/quicklist.c | |||
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quicklist)[CONFIG_NR_QUICK]; | |||
26 | static unsigned long max_pages(unsigned long min_pages) | 26 | static unsigned long max_pages(unsigned long min_pages) |
27 | { | 27 | { |
28 | unsigned long node_free_pages, max; | 28 | unsigned long node_free_pages, max; |
29 | struct zone *zones = NODE_DATA(numa_node_id())->node_zones; | ||
30 | |||
31 | node_free_pages = | ||
32 | #ifdef CONFIG_ZONE_DMA | ||
33 | zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) + | ||
34 | #endif | ||
35 | #ifdef CONFIG_ZONE_DMA32 | ||
36 | zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) + | ||
37 | #endif | ||
38 | zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES); | ||
29 | 39 | ||
30 | node_free_pages = node_page_state(numa_node_id(), | ||
31 | NR_FREE_PAGES); | ||
32 | max = node_free_pages / FRACTION_OF_NODE_MEM; | 40 | max = node_free_pages / FRACTION_OF_NODE_MEM; |
33 | return max(max, min_pages); | 41 | return max(max, min_pages); |
34 | } | 42 | } |