aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael J. Wysocki <rjw@sisk.pl>2009-01-13 08:44:19 -0500
committerJesse Barnes <jbarnes@hobbes.lan>2009-03-19 22:29:23 -0400
commit0516c8bcd25293f438573101c439ce25a18916ad (patch)
tree00e0e113810e565c9b234f9528e84b0d061c5413
parent87d2e2ecf6026efa64b01f7f71802b20da736d35 (diff)
PCI: PCIe portdrv: Simplily probe callback of service drivers
The second argument of the ->probe() callback in struct pcie_port_service_driver is unnecessary and never used. Remove it. Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
-rw-r--r--drivers/pci/hotplug/pciehp_acpi.c3
-rw-r--r--drivers/pci/hotplug/pciehp_core.c2
-rw-r--r--drivers/pci/pcie/aer/aerdrv.c6
-rw-r--r--drivers/pci/pcie/portdrv_core.c2
-rw-r--r--include/linux/pcieport_if.h3
5 files changed, 6 insertions, 10 deletions
diff --git a/drivers/pci/hotplug/pciehp_acpi.c b/drivers/pci/hotplug/pciehp_acpi.c
index 438d795f9fe3..ad8835758a17 100644
--- a/drivers/pci/hotplug/pciehp_acpi.c
+++ b/drivers/pci/hotplug/pciehp_acpi.c
@@ -82,8 +82,7 @@ static int __initdata acpi_slot_detected;
82static struct list_head __initdata dummy_slots = LIST_HEAD_INIT(dummy_slots); 82static struct list_head __initdata dummy_slots = LIST_HEAD_INIT(dummy_slots);
83 83
84/* Dummy driver for dumplicate name detection */ 84/* Dummy driver for dumplicate name detection */
85static int __init dummy_probe(struct pcie_device *dev, 85static int __init dummy_probe(struct pcie_device *dev)
86 const struct pcie_port_service_id *id)
87{ 86{
88 int pos; 87 int pos;
89 u32 slot_cap; 88 u32 slot_cap;
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
index 681e3912b821..3429b21dbb53 100644
--- a/drivers/pci/hotplug/pciehp_core.c
+++ b/drivers/pci/hotplug/pciehp_core.c
@@ -401,7 +401,7 @@ static int get_cur_bus_speed(struct hotplug_slot *hotplug_slot, enum pci_bus_spe
401 return 0; 401 return 0;
402} 402}
403 403
404static int pciehp_probe(struct pcie_device *dev, const struct pcie_port_service_id *id) 404static int pciehp_probe(struct pcie_device *dev)
405{ 405{
406 int rc; 406 int rc;
407 struct controller *ctrl; 407 struct controller *ctrl;
diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c
index e390707661dd..57c41204c549 100644
--- a/drivers/pci/pcie/aer/aerdrv.c
+++ b/drivers/pci/pcie/aer/aerdrv.c
@@ -38,8 +38,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
38MODULE_DESCRIPTION(DRIVER_DESC); 38MODULE_DESCRIPTION(DRIVER_DESC);
39MODULE_LICENSE("GPL"); 39MODULE_LICENSE("GPL");
40 40
41static int __devinit aer_probe (struct pcie_device *dev, 41static int __devinit aer_probe (struct pcie_device *dev);
42 const struct pcie_port_service_id *id );
43static void aer_remove(struct pcie_device *dev); 42static void aer_remove(struct pcie_device *dev);
44static int aer_suspend(struct pcie_device *dev, pm_message_t state) 43static int aer_suspend(struct pcie_device *dev, pm_message_t state)
45{return 0;} 44{return 0;}
@@ -207,8 +206,7 @@ static void aer_remove(struct pcie_device *dev)
207 * 206 *
208 * Invoked when PCI Express bus loads AER service driver. 207 * Invoked when PCI Express bus loads AER service driver.
209 **/ 208 **/
210static int __devinit aer_probe (struct pcie_device *dev, 209static int __devinit aer_probe (struct pcie_device *dev)
211 const struct pcie_port_service_id *id )
212{ 210{
213 int status; 211 int status;
214 struct aer_rpc *rpc; 212 struct aer_rpc *rpc;
diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index 91ecbc43155f..682524b0c93a 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -402,7 +402,7 @@ static int pcie_port_probe_service(struct device *dev)
402 return -ENODEV; 402 return -ENODEV;
403 403
404 pciedev = to_pcie_device(dev); 404 pciedev = to_pcie_device(dev);
405 status = driver->probe(pciedev, driver->id_table); 405 status = driver->probe(pciedev);
406 if (!status) { 406 if (!status) {
407 dev_printk(KERN_DEBUG, dev, "service driver %s loaded\n", 407 dev_printk(KERN_DEBUG, dev, "service driver %s loaded\n",
408 driver->name); 408 driver->name);
diff --git a/include/linux/pcieport_if.h b/include/linux/pcieport_if.h
index 8e1ae1fd92f6..59e90b8a7839 100644
--- a/include/linux/pcieport_if.h
+++ b/include/linux/pcieport_if.h
@@ -56,8 +56,7 @@ static inline void* get_service_data(struct pcie_device *dev)
56 56
57struct pcie_port_service_driver { 57struct pcie_port_service_driver {
58 const char *name; 58 const char *name;
59 int (*probe) (struct pcie_device *dev, 59 int (*probe) (struct pcie_device *dev);
60 const struct pcie_port_service_id *id);
61 void (*remove) (struct pcie_device *dev); 60 void (*remove) (struct pcie_device *dev);
62 int (*suspend) (struct pcie_device *dev, pm_message_t state); 61 int (*suspend) (struct pcie_device *dev, pm_message_t state);
63 int (*resume) (struct pcie_device *dev); 62 int (*resume) (struct pcie_device *dev);