diff options
author | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2008-09-08 05:10:11 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-09-08 09:50:06 -0400 |
commit | de9f521fb72dd091aa4989fe2e004ecf4785a850 (patch) | |
tree | 7e19aa05aec7f859ac2ca036da3cad19a055806e | |
parent | 3a80b6aa271eb08a3da1a04b5cbdcdc19d4a5ae0 (diff) |
x86: move pci-nommu's dma_mask check to common code
The check to see if dev->dma_mask is NULL in pci-nommu is more
appropriate for dma_alloc_coherent().
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | arch/x86/kernel/pci-nommu.c | 3 | ||||
-rw-r--r-- | include/asm-x86/dma-mapping.h | 3 |
2 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/kernel/pci-nommu.c b/arch/x86/kernel/pci-nommu.c index 73853d3fdcac..0f51883cc6a8 100644 --- a/arch/x86/kernel/pci-nommu.c +++ b/arch/x86/kernel/pci-nommu.c | |||
@@ -80,9 +80,6 @@ nommu_alloc_coherent(struct device *hwdev, size_t size, | |||
80 | int node; | 80 | int node; |
81 | struct page *page; | 81 | struct page *page; |
82 | 82 | ||
83 | if (hwdev->dma_mask == NULL) | ||
84 | return NULL; | ||
85 | |||
86 | gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32); | 83 | gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32); |
87 | gfp |= __GFP_ZERO; | 84 | gfp |= __GFP_ZERO; |
88 | 85 | ||
diff --git a/include/asm-x86/dma-mapping.h b/include/asm-x86/dma-mapping.h index 3a9a6f5e681a..088c56814aa3 100644 --- a/include/asm-x86/dma-mapping.h +++ b/include/asm-x86/dma-mapping.h | |||
@@ -254,6 +254,9 @@ dma_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, | |||
254 | gfp |= GFP_DMA; | 254 | gfp |= GFP_DMA; |
255 | } | 255 | } |
256 | 256 | ||
257 | if (!dev->dma_mask) | ||
258 | return NULL; | ||
259 | |||
257 | if (ops->alloc_coherent) | 260 | if (ops->alloc_coherent) |
258 | return ops->alloc_coherent(dev, size, | 261 | return ops->alloc_coherent(dev, size, |
259 | dma_handle, gfp); | 262 | dma_handle, gfp); |