diff options
author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 17:43:23 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:47 -0400 |
commit | dd98acf74762764fbc4382a1d9a244f11a2658cc (patch) | |
tree | e194cc516ccc8812a0424dfd2ca1c32bf1052cd4 | |
parent | 5089a9768041206c76fac299ccd82a528c24c254 (diff) |
keyctl_session_to_parent(): use thread_group_empty() to check singlethreadness
No functional changes.
keyctl_session_to_parent() is the only user of signal->count which needs
the correct value. Change it to use thread_group_empty() instead, this
must be strictly equivalent under tasklist, and imho looks better.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | security/keys/keyctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index 8f4dce1987c4..13074b454743 100644 --- a/security/keys/keyctl.c +++ b/security/keys/keyctl.c | |||
@@ -1269,7 +1269,7 @@ long keyctl_session_to_parent(void) | |||
1269 | goto not_permitted; | 1269 | goto not_permitted; |
1270 | 1270 | ||
1271 | /* the parent must be single threaded */ | 1271 | /* the parent must be single threaded */ |
1272 | if (atomic_read(&parent->signal->count) != 1) | 1272 | if (!thread_group_empty(parent)) |
1273 | goto not_permitted; | 1273 | goto not_permitted; |
1274 | 1274 | ||
1275 | /* the parent and the child must have different session keyrings or | 1275 | /* the parent and the child must have different session keyrings or |