aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartyn Welch <martyn.welch@ge.com>2010-02-18 10:13:12 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2010-03-03 19:43:01 -0500
commit8fafb47638012d93134d0ff38adcc5fc661beeb1 (patch)
tree2ce2ce14c179368618d6d9a148b65ce8e398ca9b
parent29848ac9f3b33bf171439ae2d66d40e6a71446c4 (diff)
Staging: vme: Make vme_master_resource naming bus neutral
The vme_master_resource structure contains an item called "pci_resource". Rename to make bus agnostic. Signed-off-by: Martyn Welch <martyn.welch@ge.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/vme/TODO1
-rw-r--r--drivers/staging/vme/bridges/vme_ca91cx42.c48
-rw-r--r--drivers/staging/vme/bridges/vme_tsi148.c50
-rw-r--r--drivers/staging/vme/vme_bridge.h2
4 files changed, 50 insertions, 51 deletions
diff --git a/drivers/staging/vme/TODO b/drivers/staging/vme/TODO
index 83d44cbf9a5f..00c0ddcfe2a0 100644
--- a/drivers/staging/vme/TODO
+++ b/drivers/staging/vme/TODO
@@ -37,7 +37,6 @@ chips. They are currently not supported at all by the API.
37Core 37Core
38==== 38====
39 39
40- Rename vme_master_resource's "pci_resource" to be bus agnostic.
41- Improve generic sanity checks (Such as does an offset and size fit within a 40- Improve generic sanity checks (Such as does an offset and size fit within a
42 window and parameter checking). 41 window and parameter checking).
43 42
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index c2f86a6996d5..ae2f69cd9d23 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -526,8 +526,8 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
526 } 526 }
527 pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev); 527 pdev = container_of(ca91cx42_bridge->parent, struct pci_dev, dev);
528 528
529 existing_size = (unsigned long long)(image->pci_resource.end - 529 existing_size = (unsigned long long)(image->bus_resource.end -
530 image->pci_resource.start); 530 image->bus_resource.start);
531 531
532 /* If the existing size is OK, return */ 532 /* If the existing size is OK, return */
533 if (existing_size == (size - 1)) 533 if (existing_size == (size - 1))
@@ -536,15 +536,15 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
536 if (existing_size != 0) { 536 if (existing_size != 0) {
537 iounmap(image->kern_base); 537 iounmap(image->kern_base);
538 image->kern_base = NULL; 538 image->kern_base = NULL;
539 if (image->pci_resource.name != NULL) 539 if (image->bus_resource.name != NULL)
540 kfree(image->pci_resource.name); 540 kfree(image->bus_resource.name);
541 release_resource(&(image->pci_resource)); 541 release_resource(&(image->bus_resource));
542 memset(&(image->pci_resource), 0, sizeof(struct resource)); 542 memset(&(image->bus_resource), 0, sizeof(struct resource));
543 } 543 }
544 544
545 if (image->pci_resource.name == NULL) { 545 if (image->bus_resource.name == NULL) {
546 image->pci_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL); 546 image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL);
547 if (image->pci_resource.name == NULL) { 547 if (image->bus_resource.name == NULL) {
548 printk(KERN_ERR "Unable to allocate memory for resource" 548 printk(KERN_ERR "Unable to allocate memory for resource"
549 " name\n"); 549 " name\n");
550 retval = -ENOMEM; 550 retval = -ENOMEM;
@@ -552,26 +552,26 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
552 } 552 }
553 } 553 }
554 554
555 sprintf((char *)image->pci_resource.name, "%s.%d", 555 sprintf((char *)image->bus_resource.name, "%s.%d",
556 ca91cx42_bridge->name, image->number); 556 ca91cx42_bridge->name, image->number);
557 557
558 image->pci_resource.start = 0; 558 image->bus_resource.start = 0;
559 image->pci_resource.end = (unsigned long)size; 559 image->bus_resource.end = (unsigned long)size;
560 image->pci_resource.flags = IORESOURCE_MEM; 560 image->bus_resource.flags = IORESOURCE_MEM;
561 561
562 retval = pci_bus_alloc_resource(pdev->bus, 562 retval = pci_bus_alloc_resource(pdev->bus,
563 &(image->pci_resource), size, size, PCIBIOS_MIN_MEM, 563 &(image->bus_resource), size, size, PCIBIOS_MIN_MEM,
564 0, NULL, NULL); 564 0, NULL, NULL);
565 if (retval) { 565 if (retval) {
566 printk(KERN_ERR "Failed to allocate mem resource for " 566 printk(KERN_ERR "Failed to allocate mem resource for "
567 "window %d size 0x%lx start 0x%lx\n", 567 "window %d size 0x%lx start 0x%lx\n",
568 image->number, (unsigned long)size, 568 image->number, (unsigned long)size,
569 (unsigned long)image->pci_resource.start); 569 (unsigned long)image->bus_resource.start);
570 goto err_resource; 570 goto err_resource;
571 } 571 }
572 572
573 image->kern_base = ioremap_nocache( 573 image->kern_base = ioremap_nocache(
574 image->pci_resource.start, size); 574 image->bus_resource.start, size);
575 if (image->kern_base == NULL) { 575 if (image->kern_base == NULL) {
576 printk(KERN_ERR "Failed to remap resource\n"); 576 printk(KERN_ERR "Failed to remap resource\n");
577 retval = -ENOMEM; 577 retval = -ENOMEM;
@@ -583,10 +583,10 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
583 iounmap(image->kern_base); 583 iounmap(image->kern_base);
584 image->kern_base = NULL; 584 image->kern_base = NULL;
585err_remap: 585err_remap:
586 release_resource(&(image->pci_resource)); 586 release_resource(&(image->bus_resource));
587err_resource: 587err_resource:
588 kfree(image->pci_resource.name); 588 kfree(image->bus_resource.name);
589 memset(&(image->pci_resource), 0, sizeof(struct resource)); 589 memset(&(image->bus_resource), 0, sizeof(struct resource));
590err_name: 590err_name:
591 return retval; 591 return retval;
592} 592}
@@ -598,9 +598,9 @@ static void ca91cx42_free_resource(struct vme_master_resource *image)
598{ 598{
599 iounmap(image->kern_base); 599 iounmap(image->kern_base);
600 image->kern_base = NULL; 600 image->kern_base = NULL;
601 release_resource(&(image->pci_resource)); 601 release_resource(&(image->bus_resource));
602 kfree(image->pci_resource.name); 602 kfree(image->bus_resource.name);
603 memset(&(image->pci_resource), 0, sizeof(struct resource)); 603 memset(&(image->bus_resource), 0, sizeof(struct resource));
604} 604}
605 605
606 606
@@ -646,7 +646,7 @@ int ca91cx42_master_set(struct vme_master_resource *image, int enabled,
646 goto err_res; 646 goto err_res;
647 } 647 }
648 648
649 pci_base = (unsigned long long)image->pci_resource.start; 649 pci_base = (unsigned long long)image->bus_resource.start;
650 650
651 /* 651 /*
652 * Bound address is a valid address for the window, adjust 652 * Bound address is a valid address for the window, adjust
@@ -1102,7 +1102,7 @@ static int ca91cx42_probe(struct pci_dev *pdev, const struct pci_device_id *id)
1102 master_image->cycle_attr = VME_SCT | VME_BLT | VME_MBLT | 1102 master_image->cycle_attr = VME_SCT | VME_BLT | VME_MBLT |
1103 VME_SUPER | VME_USER | VME_PROG | VME_DATA; 1103 VME_SUPER | VME_USER | VME_PROG | VME_DATA;
1104 master_image->width_attr = VME_D8 | VME_D16 | VME_D32 | VME_D64; 1104 master_image->width_attr = VME_D8 | VME_D16 | VME_D32 | VME_D64;
1105 memset(&(master_image->pci_resource), 0, 1105 memset(&(master_image->bus_resource), 0,
1106 sizeof(struct resource)); 1106 sizeof(struct resource));
1107 master_image->kern_base = NULL; 1107 master_image->kern_base = NULL;
1108 list_add_tail(&(master_image->list), 1108 list_add_tail(&(master_image->list),
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index e3d300c9bfba..a6f853a3dc24 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -855,8 +855,8 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
855 } 855 }
856 pdev = container_of(tsi148_bridge->parent, struct pci_dev, dev); 856 pdev = container_of(tsi148_bridge->parent, struct pci_dev, dev);
857 857
858 existing_size = (unsigned long long)(image->pci_resource.end - 858 existing_size = (unsigned long long)(image->bus_resource.end -
859 image->pci_resource.start); 859 image->bus_resource.start);
860 860
861 /* If the existing size is OK, return */ 861 /* If the existing size is OK, return */
862 if ((size != 0) && (existing_size == (size - 1))) 862 if ((size != 0) && (existing_size == (size - 1)))
@@ -865,10 +865,10 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
865 if (existing_size != 0) { 865 if (existing_size != 0) {
866 iounmap(image->kern_base); 866 iounmap(image->kern_base);
867 image->kern_base = NULL; 867 image->kern_base = NULL;
868 if (image->pci_resource.name != NULL) 868 if (image->bus_resource.name != NULL)
869 kfree(image->pci_resource.name); 869 kfree(image->bus_resource.name);
870 release_resource(&(image->pci_resource)); 870 release_resource(&(image->bus_resource));
871 memset(&(image->pci_resource), 0, sizeof(struct resource)); 871 memset(&(image->bus_resource), 0, sizeof(struct resource));
872 } 872 }
873 873
874 /* Exit here if size is zero */ 874 /* Exit here if size is zero */
@@ -876,9 +876,9 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
876 return 0; 876 return 0;
877 } 877 }
878 878
879 if (image->pci_resource.name == NULL) { 879 if (image->bus_resource.name == NULL) {
880 image->pci_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL); 880 image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_KERNEL);
881 if (image->pci_resource.name == NULL) { 881 if (image->bus_resource.name == NULL) {
882 printk(KERN_ERR "Unable to allocate memory for resource" 882 printk(KERN_ERR "Unable to allocate memory for resource"
883 " name\n"); 883 " name\n");
884 retval = -ENOMEM; 884 retval = -ENOMEM;
@@ -886,26 +886,26 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
886 } 886 }
887 } 887 }
888 888
889 sprintf((char *)image->pci_resource.name, "%s.%d", tsi148_bridge->name, 889 sprintf((char *)image->bus_resource.name, "%s.%d", tsi148_bridge->name,
890 image->number); 890 image->number);
891 891
892 image->pci_resource.start = 0; 892 image->bus_resource.start = 0;
893 image->pci_resource.end = (unsigned long)size; 893 image->bus_resource.end = (unsigned long)size;
894 image->pci_resource.flags = IORESOURCE_MEM; 894 image->bus_resource.flags = IORESOURCE_MEM;
895 895
896 retval = pci_bus_alloc_resource(pdev->bus, 896 retval = pci_bus_alloc_resource(pdev->bus,
897 &(image->pci_resource), size, size, PCIBIOS_MIN_MEM, 897 &(image->bus_resource), size, size, PCIBIOS_MIN_MEM,
898 0, NULL, NULL); 898 0, NULL, NULL);
899 if (retval) { 899 if (retval) {
900 printk(KERN_ERR "Failed to allocate mem resource for " 900 printk(KERN_ERR "Failed to allocate mem resource for "
901 "window %d size 0x%lx start 0x%lx\n", 901 "window %d size 0x%lx start 0x%lx\n",
902 image->number, (unsigned long)size, 902 image->number, (unsigned long)size,
903 (unsigned long)image->pci_resource.start); 903 (unsigned long)image->bus_resource.start);
904 goto err_resource; 904 goto err_resource;
905 } 905 }
906 906
907 image->kern_base = ioremap_nocache( 907 image->kern_base = ioremap_nocache(
908 image->pci_resource.start, size); 908 image->bus_resource.start, size);
909 if (image->kern_base == NULL) { 909 if (image->kern_base == NULL) {
910 printk(KERN_ERR "Failed to remap resource\n"); 910 printk(KERN_ERR "Failed to remap resource\n");
911 retval = -ENOMEM; 911 retval = -ENOMEM;
@@ -917,10 +917,10 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
917 iounmap(image->kern_base); 917 iounmap(image->kern_base);
918 image->kern_base = NULL; 918 image->kern_base = NULL;
919err_remap: 919err_remap:
920 release_resource(&(image->pci_resource)); 920 release_resource(&(image->bus_resource));
921err_resource: 921err_resource:
922 kfree(image->pci_resource.name); 922 kfree(image->bus_resource.name);
923 memset(&(image->pci_resource), 0, sizeof(struct resource)); 923 memset(&(image->bus_resource), 0, sizeof(struct resource));
924err_name: 924err_name:
925 return retval; 925 return retval;
926} 926}
@@ -932,9 +932,9 @@ static void tsi148_free_resource(struct vme_master_resource *image)
932{ 932{
933 iounmap(image->kern_base); 933 iounmap(image->kern_base);
934 image->kern_base = NULL; 934 image->kern_base = NULL;
935 release_resource(&(image->pci_resource)); 935 release_resource(&(image->bus_resource));
936 kfree(image->pci_resource.name); 936 kfree(image->bus_resource.name);
937 memset(&(image->pci_resource), 0, sizeof(struct resource)); 937 memset(&(image->bus_resource), 0, sizeof(struct resource));
938} 938}
939 939
940/* 940/*
@@ -987,7 +987,7 @@ int tsi148_master_set( struct vme_master_resource *image, int enabled,
987 pci_bound = 0; 987 pci_bound = 0;
988 vme_offset = 0; 988 vme_offset = 0;
989 } else { 989 } else {
990 pci_base = (unsigned long long)image->pci_resource.start; 990 pci_base = (unsigned long long)image->bus_resource.start;
991 991
992 /* 992 /*
993 * Bound address is a valid address for the window, adjust 993 * Bound address is a valid address for the window, adjust
@@ -2423,7 +2423,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
2423 VME_2eSST160 | VME_2eSST267 | VME_2eSST320 | VME_SUPER | 2423 VME_2eSST160 | VME_2eSST267 | VME_2eSST320 | VME_SUPER |
2424 VME_USER | VME_PROG | VME_DATA; 2424 VME_USER | VME_PROG | VME_DATA;
2425 tsi148_device->flush_image->width_attr = VME_D16 | VME_D32; 2425 tsi148_device->flush_image->width_attr = VME_D16 | VME_D32;
2426 memset(&(tsi148_device->flush_image->pci_resource), 0, 2426 memset(&(tsi148_device->flush_image->bus_resource), 0,
2427 sizeof(struct resource)); 2427 sizeof(struct resource));
2428 tsi148_device->flush_image->kern_base = NULL; 2428 tsi148_device->flush_image->kern_base = NULL;
2429 } 2429 }
@@ -2450,7 +2450,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
2450 VME_2eSST267 | VME_2eSST320 | VME_SUPER | VME_USER | 2450 VME_2eSST267 | VME_2eSST320 | VME_SUPER | VME_USER |
2451 VME_PROG | VME_DATA; 2451 VME_PROG | VME_DATA;
2452 master_image->width_attr = VME_D16 | VME_D32; 2452 master_image->width_attr = VME_D16 | VME_D32;
2453 memset(&(master_image->pci_resource), 0, 2453 memset(&(master_image->bus_resource), 0,
2454 sizeof(struct resource)); 2454 sizeof(struct resource));
2455 master_image->kern_base = NULL; 2455 master_image->kern_base = NULL;
2456 list_add_tail(&(master_image->list), 2456 list_add_tail(&(master_image->list),
diff --git a/drivers/staging/vme/vme_bridge.h b/drivers/staging/vme/vme_bridge.h
index 6dc472f613e2..a2cfc1014726 100644
--- a/drivers/staging/vme/vme_bridge.h
+++ b/drivers/staging/vme/vme_bridge.h
@@ -19,7 +19,7 @@ struct vme_master_resource {
19 vme_address_t address_attr; 19 vme_address_t address_attr;
20 vme_cycle_t cycle_attr; 20 vme_cycle_t cycle_attr;
21 vme_width_t width_attr; 21 vme_width_t width_attr;
22 struct resource pci_resource; /* XXX Rename to be bus agnostic */ 22 struct resource bus_resource;
23 void *kern_base; 23 void *kern_base;
24}; 24};
25 25