aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2009-09-15 11:30:38 -0400
committerSteven Whitehouse <swhiteho@redhat.com>2009-12-03 06:50:51 -0500
commit6a6ada81e4ffc222bf7e54ea7503c7cc98b4f0d8 (patch)
tree499596295831a822090b57a16a072fad25ced852
parent33a82529e7007ed7beceebc6b3f3cddadb5b67f0 (diff)
GFS2: Remove constant argument from qd_get()
This function was only ever called with the "create" argument set to true, so we can remove it. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
-rw-r--r--fs/gfs2/quota.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index f790f5af74e3..db124af8998e 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -165,7 +165,7 @@ fail:
165 return error; 165 return error;
166} 166}
167 167
168static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create, 168static int qd_get(struct gfs2_sbd *sdp, int user, u32 id,
169 struct gfs2_quota_data **qdp) 169 struct gfs2_quota_data **qdp)
170{ 170{
171 struct gfs2_quota_data *qd = NULL, *new_qd = NULL; 171 struct gfs2_quota_data *qd = NULL, *new_qd = NULL;
@@ -203,7 +203,7 @@ static int qd_get(struct gfs2_sbd *sdp, int user, u32 id, int create,
203 203
204 spin_unlock(&qd_lru_lock); 204 spin_unlock(&qd_lru_lock);
205 205
206 if (qd || !create) { 206 if (qd) {
207 if (new_qd) { 207 if (new_qd) {
208 gfs2_glock_put(new_qd->qd_gl); 208 gfs2_glock_put(new_qd->qd_gl);
209 kmem_cache_free(gfs2_quotad_cachep, new_qd); 209 kmem_cache_free(gfs2_quotad_cachep, new_qd);
@@ -467,7 +467,7 @@ static int qdsb_get(struct gfs2_sbd *sdp, int user, u32 id,
467{ 467{
468 int error; 468 int error;
469 469
470 error = qd_get(sdp, user, id, CREATE, qdp); 470 error = qd_get(sdp, user, id, qdp);
471 if (error) 471 if (error)
472 return error; 472 return error;
473 473
@@ -1117,7 +1117,7 @@ int gfs2_quota_refresh(struct gfs2_sbd *sdp, int user, u32 id)
1117 struct gfs2_holder q_gh; 1117 struct gfs2_holder q_gh;
1118 int error; 1118 int error;
1119 1119
1120 error = qd_get(sdp, user, id, CREATE, &qd); 1120 error = qd_get(sdp, user, id, &qd);
1121 if (error) 1121 if (error)
1122 return error; 1122 return error;
1123 1123