diff options
| author | Chris Metcalf <cmetcalf@tilera.com> | 2011-02-28 15:58:39 -0500 |
|---|---|---|
| committer | Chris Metcalf <cmetcalf@tilera.com> | 2011-03-10 13:14:03 -0500 |
| commit | 5fb682b0644cd20015d9b0e3ca6921ad5533f4ba (patch) | |
| tree | 0a2520197ebf92b6a27e69241bd4f242d1b39be3 | |
| parent | 00dce03134689a257120ae2aa18ba7d1a736bef7 (diff) | |
arch/tile: fix some comments and whitespace
This is a grab bag of changes with no actual change to generated code.
This includes whitespace and comment typos, plus a couple of stale
comments being removed.
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
| -rw-r--r-- | arch/tile/Kconfig | 20 | ||||
| -rw-r--r-- | arch/tile/include/asm/bitops_32.h | 2 | ||||
| -rw-r--r-- | arch/tile/include/asm/processor.h | 1 | ||||
| -rw-r--r-- | arch/tile/kernel/intvec_32.S | 4 | ||||
| -rw-r--r-- | arch/tile/lib/atomic_32.c | 2 | ||||
| -rw-r--r-- | arch/tile/lib/atomic_asm_32.S | 2 | ||||
| -rw-r--r-- | arch/tile/mm/fault.c | 8 |
7 files changed, 15 insertions, 24 deletions
diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig index 9e4eb51b673f..92f7ea070b62 100644 --- a/arch/tile/Kconfig +++ b/arch/tile/Kconfig | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | # For a description of the syntax of this configuration file, | 1 | # For a description of the syntax of this configuration file, |
| 2 | # see Documentation/kbuild/config-language.txt. | 2 | # see Documentation/kbuild/kconfig-language.txt. |
| 3 | 3 | ||
| 4 | config TILE | 4 | config TILE |
| 5 | def_bool y | 5 | def_bool y |
| @@ -15,14 +15,14 @@ config TILE | |||
| 15 | 15 | ||
| 16 | # FIXME: investigate whether we need/want these options. | 16 | # FIXME: investigate whether we need/want these options. |
| 17 | # select HAVE_IOREMAP_PROT | 17 | # select HAVE_IOREMAP_PROT |
| 18 | # select HAVE_OPTPROBES | 18 | # select HAVE_OPTPROBES |
| 19 | # select HAVE_REGS_AND_STACK_ACCESS_API | 19 | # select HAVE_REGS_AND_STACK_ACCESS_API |
| 20 | # select HAVE_HW_BREAKPOINT | 20 | # select HAVE_HW_BREAKPOINT |
| 21 | # select PERF_EVENTS | 21 | # select PERF_EVENTS |
| 22 | # select HAVE_USER_RETURN_NOTIFIER | 22 | # select HAVE_USER_RETURN_NOTIFIER |
| 23 | # config NO_BOOTMEM | 23 | # config NO_BOOTMEM |
| 24 | # config ARCH_SUPPORTS_DEBUG_PAGEALLOC | 24 | # config ARCH_SUPPORTS_DEBUG_PAGEALLOC |
| 25 | # config HUGETLB_PAGE_SIZE_VARIABLE | 25 | # config HUGETLB_PAGE_SIZE_VARIABLE |
| 26 | 26 | ||
| 27 | config MMU | 27 | config MMU |
| 28 | def_bool y | 28 | def_bool y |
| @@ -40,7 +40,7 @@ config HAVE_SETUP_PER_CPU_AREA | |||
| 40 | def_bool y | 40 | def_bool y |
| 41 | 41 | ||
| 42 | config NEED_PER_CPU_PAGE_FIRST_CHUNK | 42 | config NEED_PER_CPU_PAGE_FIRST_CHUNK |
| 43 | def_bool y | 43 | def_bool y |
| 44 | 44 | ||
| 45 | config SYS_SUPPORTS_HUGETLBFS | 45 | config SYS_SUPPORTS_HUGETLBFS |
| 46 | def_bool y | 46 | def_bool y |
diff --git a/arch/tile/include/asm/bitops_32.h b/arch/tile/include/asm/bitops_32.h index 7a93c001ac19..2638be51a164 100644 --- a/arch/tile/include/asm/bitops_32.h +++ b/arch/tile/include/asm/bitops_32.h | |||
| @@ -122,7 +122,7 @@ static inline int test_and_change_bit(unsigned nr, | |||
| 122 | return (_atomic_xor(addr, mask) & mask) != 0; | 122 | return (_atomic_xor(addr, mask) & mask) != 0; |
| 123 | } | 123 | } |
| 124 | 124 | ||
| 125 | /* See discussion at smp_mb__before_atomic_dec() in <asm/atomic.h>. */ | 125 | /* See discussion at smp_mb__before_atomic_dec() in <asm/atomic_32.h>. */ |
| 126 | #define smp_mb__before_clear_bit() smp_mb() | 126 | #define smp_mb__before_clear_bit() smp_mb() |
| 127 | #define smp_mb__after_clear_bit() do {} while (0) | 127 | #define smp_mb__after_clear_bit() do {} while (0) |
| 128 | 128 | ||
diff --git a/arch/tile/include/asm/processor.h b/arch/tile/include/asm/processor.h index a9e7c8760334..e6889474038a 100644 --- a/arch/tile/include/asm/processor.h +++ b/arch/tile/include/asm/processor.h | |||
| @@ -269,7 +269,6 @@ extern char chip_model[64]; | |||
| 269 | /* Data on which physical memory controller corresponds to which NUMA node. */ | 269 | /* Data on which physical memory controller corresponds to which NUMA node. */ |
| 270 | extern int node_controller[]; | 270 | extern int node_controller[]; |
| 271 | 271 | ||
| 272 | |||
| 273 | /* Do we dump information to the console when a user application crashes? */ | 272 | /* Do we dump information to the console when a user application crashes? */ |
| 274 | extern int show_crashinfo; | 273 | extern int show_crashinfo; |
| 275 | 274 | ||
diff --git a/arch/tile/kernel/intvec_32.S b/arch/tile/kernel/intvec_32.S index abf92f51af47..eabf1ef02cb2 100644 --- a/arch/tile/kernel/intvec_32.S +++ b/arch/tile/kernel/intvec_32.S | |||
| @@ -1584,7 +1584,7 @@ ENTRY(sys_cmpxchg) | |||
| 1584 | * about aliasing among multiple mappings of the same physical page, | 1584 | * about aliasing among multiple mappings of the same physical page, |
| 1585 | * and we ignore the low 3 bits so we have one lock that covers | 1585 | * and we ignore the low 3 bits so we have one lock that covers |
| 1586 | * both a cmpxchg64() and a cmpxchg() on either its low or high word. | 1586 | * both a cmpxchg64() and a cmpxchg() on either its low or high word. |
| 1587 | * NOTE: this code must match __atomic_hashed_lock() in lib/atomic.c. | 1587 | * NOTE: this must match __atomic_hashed_lock() in lib/atomic_32.c. |
| 1588 | */ | 1588 | */ |
| 1589 | 1589 | ||
| 1590 | #if ATOMIC_LOCKS_FOUND_VIA_TABLE() | 1590 | #if ATOMIC_LOCKS_FOUND_VIA_TABLE() |
| @@ -1718,7 +1718,7 @@ ENTRY(sys_cmpxchg) | |||
| 1718 | 1718 | ||
| 1719 | /* | 1719 | /* |
| 1720 | * Perform the actual cmpxchg or atomic_update. | 1720 | * Perform the actual cmpxchg or atomic_update. |
| 1721 | * Note that __futex_mark_unlocked() in uClibc relies on | 1721 | * Note that the system <arch/atomic.h> header relies on |
| 1722 | * atomic_update() to always perform an "mf", so don't make | 1722 | * atomic_update() to always perform an "mf", so don't make |
| 1723 | * it optional or conditional without modifying that code. | 1723 | * it optional or conditional without modifying that code. |
| 1724 | */ | 1724 | */ |
diff --git a/arch/tile/lib/atomic_32.c b/arch/tile/lib/atomic_32.c index 20c31626f72f..f02040d3614e 100644 --- a/arch/tile/lib/atomic_32.c +++ b/arch/tile/lib/atomic_32.c | |||
| @@ -52,7 +52,7 @@ int atomic_locks[PAGE_SIZE / sizeof(int)] __page_aligned_bss; | |||
| 52 | 52 | ||
| 53 | static inline int *__atomic_hashed_lock(volatile void *v) | 53 | static inline int *__atomic_hashed_lock(volatile void *v) |
| 54 | { | 54 | { |
| 55 | /* NOTE: this code must match "sys_cmpxchg" in kernel/intvec.S */ | 55 | /* NOTE: this code must match "sys_cmpxchg" in kernel/intvec_32.S */ |
| 56 | #if ATOMIC_LOCKS_FOUND_VIA_TABLE() | 56 | #if ATOMIC_LOCKS_FOUND_VIA_TABLE() |
| 57 | unsigned long i = | 57 | unsigned long i = |
| 58 | (unsigned long) v & ((PAGE_SIZE-1) & -sizeof(long long)); | 58 | (unsigned long) v & ((PAGE_SIZE-1) & -sizeof(long long)); |
diff --git a/arch/tile/lib/atomic_asm_32.S b/arch/tile/lib/atomic_asm_32.S index 5a5514b77e78..82f64cc63658 100644 --- a/arch/tile/lib/atomic_asm_32.S +++ b/arch/tile/lib/atomic_asm_32.S | |||
| @@ -14,7 +14,7 @@ | |||
| 14 | * Support routines for atomic operations. Each function takes: | 14 | * Support routines for atomic operations. Each function takes: |
| 15 | * | 15 | * |
| 16 | * r0: address to manipulate | 16 | * r0: address to manipulate |
| 17 | * r1: pointer to atomic lock guarding this operation (for FUTEX_LOCK_REG) | 17 | * r1: pointer to atomic lock guarding this operation (for ATOMIC_LOCK_REG) |
| 18 | * r2: new value to write, or for cmpxchg/add_unless, value to compare against | 18 | * r2: new value to write, or for cmpxchg/add_unless, value to compare against |
| 19 | * r3: (cmpxchg/xchg_add_unless) new value to write or add; | 19 | * r3: (cmpxchg/xchg_add_unless) new value to write or add; |
| 20 | * (atomic64 ops) high word of value to write | 20 | * (atomic64 ops) high word of value to write |
diff --git a/arch/tile/mm/fault.c b/arch/tile/mm/fault.c index dcebfc831cd6..758f597f488c 100644 --- a/arch/tile/mm/fault.c +++ b/arch/tile/mm/fault.c | |||
| @@ -655,14 +655,6 @@ struct intvec_state do_page_fault_ics(struct pt_regs *regs, int fault_num, | |||
| 655 | } | 655 | } |
| 656 | 656 | ||
| 657 | /* | 657 | /* |
| 658 | * NOTE: the one other type of access that might bring us here | ||
| 659 | * are the memory ops in __tns_atomic_acquire/__tns_atomic_release, | ||
| 660 | * but we don't have to check specially for them since we can | ||
| 661 | * always safely return to the address of the fault and retry, | ||
| 662 | * since no separate atomic locks are involved. | ||
| 663 | */ | ||
| 664 | |||
| 665 | /* | ||
| 666 | * Now that we have released the atomic lock (if necessary), | 658 | * Now that we have released the atomic lock (if necessary), |
| 667 | * it's safe to spin if the PTE that caused the fault was migrating. | 659 | * it's safe to spin if the PTE that caused the fault was migrating. |
| 668 | */ | 660 | */ |
