aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Engelhardt <jengelh@medozas.de>2010-04-19 10:07:47 -0400
committerPatrick McHardy <kaber@trash.net>2010-04-19 10:07:47 -0400
commit5b775eb1c04c2ef33f5e17035e368214214ef9c2 (patch)
treeebc631a1f1212aacdcceb629537ed273f32732b0
parentcd58bcd9787ef4c16ab6e442c4f1bf3539b3ab39 (diff)
netfilter: xtables: remove old comments about reentrancy
Signed-off-by: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Patrick McHardy <kaber@trash.net>
-rw-r--r--net/ipv4/netfilter/ip_tables.c2
-rw-r--r--net/ipv4/netfilter/ipt_REJECT.c3
-rw-r--r--net/ipv6/netfilter/ip6_tables.c2
-rw-r--r--net/ipv6/netfilter/ip6t_REJECT.c3
4 files changed, 0 insertions, 10 deletions
diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
index 70900ecf88e2..bb5e0d9b8137 100644
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4/netfilter/ip_tables.c
@@ -434,8 +434,6 @@ ipt_do_table(struct sk_buff *skb,
434 continue; 434 continue;
435 } 435 }
436 436
437 /* Targets which reenter must return
438 abs. verdicts */
439 tgpar.target = t->u.kernel.target; 437 tgpar.target = t->u.kernel.target;
440 tgpar.targinfo = t->data; 438 tgpar.targinfo = t->data;
441 439
diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT.c
index b026014e7a5b..038fa0bb8f6b 100644
--- a/net/ipv4/netfilter/ipt_REJECT.c
+++ b/net/ipv4/netfilter/ipt_REJECT.c
@@ -139,9 +139,6 @@ reject_tg(struct sk_buff *skb, const struct xt_target_param *par)
139{ 139{
140 const struct ipt_reject_info *reject = par->targinfo; 140 const struct ipt_reject_info *reject = par->targinfo;
141 141
142 /* WARNING: This code causes reentry within iptables.
143 This means that the iptables jump stack is now crap. We
144 must return an absolute verdict. --RR */
145 switch (reject->with) { 142 switch (reject->with) {
146 case IPT_ICMP_NET_UNREACHABLE: 143 case IPT_ICMP_NET_UNREACHABLE:
147 send_unreach(skb, ICMP_NET_UNREACH); 144 send_unreach(skb, ICMP_NET_UNREACH);
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index 2a2770bcd640..7afa11773164 100644
--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -451,8 +451,6 @@ ip6t_do_table(struct sk_buff *skb,
451 continue; 451 continue;
452 } 452 }
453 453
454 /* Targets which reenter must return
455 abs. verdicts */
456 tgpar.target = t->u.kernel.target; 454 tgpar.target = t->u.kernel.target;
457 tgpar.targinfo = t->data; 455 tgpar.targinfo = t->data;
458 456
diff --git a/net/ipv6/netfilter/ip6t_REJECT.c b/net/ipv6/netfilter/ip6t_REJECT.c
index 55b9b2da1340..dad97622ed72 100644
--- a/net/ipv6/netfilter/ip6t_REJECT.c
+++ b/net/ipv6/netfilter/ip6t_REJECT.c
@@ -179,9 +179,6 @@ reject_tg6(struct sk_buff *skb, const struct xt_target_param *par)
179 struct net *net = dev_net((par->in != NULL) ? par->in : par->out); 179 struct net *net = dev_net((par->in != NULL) ? par->in : par->out);
180 180
181 pr_debug("%s: medium point\n", __func__); 181 pr_debug("%s: medium point\n", __func__);
182 /* WARNING: This code causes reentry within ip6tables.
183 This means that the ip6tables jump stack is now crap. We
184 must return an absolute verdict. --RR */
185 switch (reject->with) { 182 switch (reject->with) {
186 case IP6T_ICMP6_NO_ROUTE: 183 case IP6T_ICMP6_NO_ROUTE:
187 send_unreach(net, skb, ICMPV6_NOROUTE, par->hooknum); 184 send_unreach(net, skb, ICMPV6_NOROUTE, par->hooknum);