diff options
author | Nathan Fontenot <nfont@austin.ibm.com> | 2008-08-25 15:33:34 -0400 |
---|---|---|
committer | Paul Mackerras <paulus@samba.org> | 2008-09-15 14:07:52 -0400 |
commit | 525c411d400603665f8416f7e84bb14a43830027 (patch) | |
tree | bda961397337b725615eba8e1d8514c54ff581db | |
parent | 57dda6ef5bd5b9e60410477ad29e654097e2cca1 (diff) |
powerpc: Check rc of notifier chain for memory remove
The return code from invocation of the notifier for
pSeries_reconfig_chain during update of the device tree is not
checked. This causes writes to /proc/ppc64/ofdt to update memory
properties (i.e. ibm,dyamic-reconfiguration-memory) to always
return success, instead of the result of the notifier chain.
This happens specifically when we remove/add memory from the
device tree on machines using memory specified in the
ibm,dynamic-reconfiguration-memory property of the device tree.
Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
-rw-r--r-- | arch/powerpc/platforms/pseries/reconfig.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/powerpc/platforms/pseries/reconfig.c b/arch/powerpc/platforms/pseries/reconfig.c index 7637bd38c795..c591a25b0b0d 100644 --- a/arch/powerpc/platforms/pseries/reconfig.c +++ b/arch/powerpc/platforms/pseries/reconfig.c | |||
@@ -466,11 +466,11 @@ static int do_update_property(char *buf, size_t bufsize) | |||
466 | else | 466 | else |
467 | action = PSERIES_DRCONF_MEM_REMOVE; | 467 | action = PSERIES_DRCONF_MEM_REMOVE; |
468 | 468 | ||
469 | blocking_notifier_call_chain(&pSeries_reconfig_chain, | 469 | rc = blocking_notifier_call_chain(&pSeries_reconfig_chain, |
470 | action, value); | 470 | action, value); |
471 | } | 471 | } |
472 | 472 | ||
473 | return 0; | 473 | return rc; |
474 | } | 474 | } |
475 | 475 | ||
476 | /** | 476 | /** |