aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-02-15 16:33:13 -0500
committerJames Bottomley <James.Bottomley@suse.de>2011-02-18 13:34:38 -0500
commit382be668c5a284844f9dcbb5b1cb8ffba2386d80 (patch)
treef32e381380abebd99a3ee77566efc494541e2347
parentba95e2ac6bfeb9af92153058a353fc47e1addc02 (diff)
[SCSI] hpsa: fix bad comparison
'!' has higher precedence than '&'. CFGTBL_ChangeReq is 0x1 so the original code is equivelent to if (!doorbell_value) {... Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rw-r--r--drivers/scsi/hpsa.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index eb6938fe77b0..c30591f84a06 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3614,7 +3614,7 @@ static void __devinit hpsa_wait_for_mode_change_ack(struct ctlr_info *h)
3614 spin_lock_irqsave(&h->lock, flags); 3614 spin_lock_irqsave(&h->lock, flags);
3615 doorbell_value = readl(h->vaddr + SA5_DOORBELL); 3615 doorbell_value = readl(h->vaddr + SA5_DOORBELL);
3616 spin_unlock_irqrestore(&h->lock, flags); 3616 spin_unlock_irqrestore(&h->lock, flags);
3617 if (!doorbell_value & CFGTBL_ChangeReq) 3617 if (!(doorbell_value & CFGTBL_ChangeReq))
3618 break; 3618 break;
3619 /* delay and try again */ 3619 /* delay and try again */
3620 usleep_range(10000, 20000); 3620 usleep_range(10000, 20000);