diff options
author | Oleg Nesterov <oleg@tv-sign.ru> | 2006-08-21 02:33:23 -0400 |
---|---|---|
committer | Jens Axboe <axboe@suse.de> | 2006-08-21 02:33:23 -0400 |
commit | 78bd4d484f81a611ef6ff02f909e576cb9aac7f2 (patch) | |
tree | 9ba30e54a16d47b3cf4a9ea0123f7261d52462ab | |
parent | ef7d1b244fa6c94fb76d5f787b8629df64ea4046 (diff) |
[PATCH] sys_ioprio_set: minor do_each_thread+break fix
From include/linux/sched.h:
* Careful: do_each_thread/while_each_thread is a double loop so
* 'break' will not work as expected - use goto instead.
*/
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Jens Axboe <axboe@suse.de>
-rw-r--r-- | fs/ioprio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ioprio.c b/fs/ioprio.c index 93aa5715f224..3db31038e9ab 100644 --- a/fs/ioprio.c +++ b/fs/ioprio.c | |||
@@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which, int who, int ioprio) | |||
111 | continue; | 111 | continue; |
112 | ret = set_task_ioprio(p, ioprio); | 112 | ret = set_task_ioprio(p, ioprio); |
113 | if (ret) | 113 | if (ret) |
114 | break; | 114 | goto free_uid; |
115 | } while_each_thread(g, p); | 115 | } while_each_thread(g, p); |
116 | 116 | free_uid: | |
117 | if (who) | 117 | if (who) |
118 | free_uid(user); | 118 | free_uid(user); |
119 | break; | 119 | break; |