diff options
author | Julia Lawall <julia@diku.dk> | 2009-12-10 15:17:49 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-12-15 21:18:41 -0500 |
commit | 909d15a70d6a269ba599c539c55a574482355ff1 (patch) | |
tree | f59e507a598e8418ac41af235efbc9a7e8bf8b18 | |
parent | ddb0b34f1345e1fec60f168bd99c487699f65212 (diff) |
V4L/DVB (13611): radio-tea5764: Correct size given to memset
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T *x;
expression E;
@@
memset(x, E, sizeof(
+ *
x))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/radio/radio-tea5764.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/radio/radio-tea5764.c b/drivers/media/radio/radio-tea5764.c index 1d357b79b2fd..8e718bfcdad3 100644 --- a/drivers/media/radio/radio-tea5764.c +++ b/drivers/media/radio/radio-tea5764.c | |||
@@ -314,7 +314,7 @@ static int vidioc_g_tuner(struct file *file, void *priv, | |||
314 | if (v->index > 0) | 314 | if (v->index > 0) |
315 | return -EINVAL; | 315 | return -EINVAL; |
316 | 316 | ||
317 | memset(v, 0, sizeof(v)); | 317 | memset(v, 0, sizeof(*v)); |
318 | strcpy(v->name, "FM"); | 318 | strcpy(v->name, "FM"); |
319 | v->type = V4L2_TUNER_RADIO; | 319 | v->type = V4L2_TUNER_RADIO; |
320 | tea5764_i2c_read(radio); | 320 | tea5764_i2c_read(radio); |
@@ -373,7 +373,7 @@ static int vidioc_g_frequency(struct file *file, void *priv, | |||
373 | if (f->tuner != 0) | 373 | if (f->tuner != 0) |
374 | return -EINVAL; | 374 | return -EINVAL; |
375 | tea5764_i2c_read(radio); | 375 | tea5764_i2c_read(radio); |
376 | memset(f, 0, sizeof(f)); | 376 | memset(f, 0, sizeof(*f)); |
377 | f->type = V4L2_TUNER_RADIO; | 377 | f->type = V4L2_TUNER_RADIO; |
378 | if (r->tnctrl & TEA5764_TNCTRL_PUPD0) | 378 | if (r->tnctrl & TEA5764_TNCTRL_PUPD0) |
379 | f->frequency = (tea5764_get_freq(radio) * 2) / 125; | 379 | f->frequency = (tea5764_get_freq(radio) * 2) / 125; |